FAILED: patch "[PATCH] iio: adc: ad_sigma_delta: fix use-after-free on unbind" failed to apply to 6.12-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 6.12-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y
git checkout FETCH_HEAD
git cherry-pick -x 9ee8306121495d2a25aa5d1bfd519f2748786b83
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026100620-buzz-swell-fdb1@gregkh' --subject-prefix 'PATCH 6.12.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 9ee8306121495d2a25aa5d1bfd519f2748786b83 Mon Sep 17 00:00:00 2001
From: Fan Wu <[email protected]>
Date: Wed, 23 Sep 2026 09:48:07 +0000
Subject: [PATCH] iio: adc: ad_sigma_delta: fix use-after-free on unbind
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
ad_sd_buffer_postenable() allocates sigma_delta->samples_buf with devm_krealloc() at runtime, so its devres entry sits after all probe-time entries of the driver. devm resources are released in reverse allocation order, which means unbind frees samples_buf before iio_device_unregister() disables the buffers and detaches the trigger pollfunc. The data ready IRQ is still enabled at that point, so ad_sd_trigger_handler() can still run and memcpy() incoming samples into the freed samples_buf.
Fix this by preallocating the buffer in devm_ad_sd_setup_buffer_and_trigger(), before the triggered buffer and the IRQ are set up, so it is freed only after iio_device_unregister() has drained the trigger handler via free_irq(). Size it for the worst case of all sequencer slots being active; ad_sd_validate_scan_mask() already caps the number of active channels at num_slots.
This issue was found by an in-house static analysis tool.
drivers/iio/adc/ad_sigma_delta.c +18 -13
@@ -498,7 +498,6 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev)const struct iio_scan_type *scan_type = &indio_dev->channels[0 ].scan_type;struct spi_transfer *xfer = sigma_delta->sample_xfer;unsigned int i, slot, channel; -u8 *samples_buf;int ret;if (sigma_delta->num_slots ==1 ) {
@@ -530,7 +529,7 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev) xfer[1 ].bits_per_word = scan_type->realbits; xfer[1 ].len =spi_bpw_to_bytes (scan_type->realbits); }else { -unsigned int samples_buf_size, scan_size; +unsigned int scan_size;if (sigma_delta->active_slots >1 ) { ret =ad_sigma_delta_append_status (sigma_delta, true);
@@ -538,17 +537,6 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev)return ret; } - samples_buf_size = -ALIGN (slot *BITS_TO_BYTES (scan_type->storagebits), -sizeof (s64)); - samples_buf_size +=sizeof (s64); - samples_buf =devm_krealloc (&sigma_delta->spi->dev, - sigma_delta->samples_buf, - samples_buf_size,GFP_KERNEL ); -if (!samples_buf) -return -ENOMEM ; - - sigma_delta->samples_buf = samples_buf; scan_size =BITS_TO_BYTES (scan_type->realbits + scan_type->shift);/* For 24-bit data, there is an extra byte of padding. */ xfer[1 ].rx_buf = &sigma_delta->rx_buf[scan_size ==3 ?1 :0 ];
@@ -855,6 +843,23 @@ int devm_ad_sd_setup_buffer_and_trigger(struct device *dev, struct iio_dev *indi indio_dev->setup_ops = &ad_sd_buffer_setup_ops; }else { +const struct iio_scan_type *scan_type = + &indio_dev->channels[0 ].scan_type; +unsigned int samples_buf_size; + +/* +* Worst-case size: all sequencer slots can be active, capped +* at num_slots by ad_sd_validate_scan_mask(). +*/ + samples_buf_size = +ALIGN (sigma_delta->num_slots * +BITS_TO_BYTES (scan_type->storagebits), +sizeof (s64)); + samples_buf_size +=sizeof (s64); + sigma_delta->samples_buf =devm_kzalloc (dev, samples_buf_size,GFP_KERNEL ); +if (!sigma_delta->samples_buf) +return -ENOMEM ; + ret = devm_iio_triggered_buffer_setup(dev, indio_dev, &iio_pollfunc_store_time, &ad_sd_trigger_handler,
Sasha Levin
maintainerPATCH 1/1 iio: adc: ad_sigma_delta: fix use-after-free on unbind
From: Fan Wu <[email protected]>
[ Upstream commit 9ee8306121495d2a25aa5d1bfd519f2748786b83 ]
ad_sd_buffer_postenable() allocates sigma_delta->samples_buf with devm_krealloc() at runtime, so its devres entry sits after all probe-time entries of the driver. devm resources are released in reverse allocation order, which means unbind frees samples_buf before iio_device_unregister() disables the buffers and detaches the trigger pollfunc. The data ready IRQ is still enabled at that point, so ad_sd_trigger_handler() can still run and memcpy() incoming samples into the freed samples_buf.
Fix this by preallocating the buffer in devm_ad_sd_setup_buffer_and_trigger(), before the triggered buffer and the IRQ are set up, so it is freed only after iio_device_unregister() has drained the trigger handler via free_irq(). Size it for the worst case of all sequencer slots being active; ad_sd_validate_scan_mask() already caps the number of active channels at num_slots.
This issue was found by an in-house static analysis tool.
--- drivers/iio/adc/ad_sigma_delta.c | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-)
drivers/iio/adc/ad_sigma_delta.c +16 -11
@@ -344,9 +344,8 @@ EXPORT_SYMBOL_NS_GPL(ad_sigma_delta_single_conversion, IIO_AD_SIGMA_DELTA);static int ad_sd_buffer_postenable (struct iio_dev *indio_dev) {struct ad_sigma_delta *sigma_delta =iio_device_get_drvdata (indio_dev); -unsigned int i, slot, samples_buf_size; +unsigned int i, slot;unsigned int channel; -uint8_t *samples_buf;int ret;if (sigma_delta->num_slots ==1 ) {
@@ -379,15 +378,6 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev)return ret; } - samples_buf_size =ALIGN (slot * indio_dev->channels[0 ].scan_type.storagebits /8 ,8 ); - samples_buf_size +=sizeof (int64_t ); - samples_buf =devm_krealloc (&sigma_delta->spi->dev, sigma_delta->samples_buf, - samples_buf_size,GFP_KERNEL ); -if (!samples_buf) -return -ENOMEM ; - - sigma_delta->samples_buf = samples_buf; -spi_bus_lock (sigma_delta->spi->controller); sigma_delta->bus_locked = true; sigma_delta->keep_cs_asserted = true;
@@ -626,6 +616,8 @@ static int devm_ad_sd_probe_trigger(struct device *dev, struct iio_dev *indio_deint devm_ad_sd_setup_buffer_and_trigger (struct device *dev,struct iio_dev *indio_dev) {struct ad_sigma_delta *sigma_delta =iio_device_get_drvdata (indio_dev); +const struct iio_scan_type *scan_type = &indio_dev->channels[0 ].scan_type; +unsigned int samples_buf_size;int ret; sigma_delta->slots = devm_kcalloc(dev, sigma_delta->num_slots,
@@ -633,6 +625,19 @@ int devm_ad_sd_setup_buffer_and_trigger(struct device *dev, struct iio_dev *indiif (!sigma_delta->slots)return -ENOMEM ; +/* +* Worst-case size: all sequencer slots can be active, capped +* at num_slots by ad_sd_validate_scan_mask(). +*/ + samples_buf_size = +ALIGN (sigma_delta->num_slots * +BITS_TO_BYTES (scan_type->storagebits), +sizeof (s64)); + samples_buf_size +=sizeof (s64); + sigma_delta->samples_buf =devm_kzalloc (dev, samples_buf_size,GFP_KERNEL ); +if (!sigma_delta->samples_buf) +return -ENOMEM ; + ret = devm_iio_triggered_buffer_setup(dev, indio_dev, &iio_pollfunc_store_time, &ad_sd_trigger_handler,
Signature · 1 line
2.53.0