init-main-fix-off-by-one-in-argv_init-cleanup.patch removed from -mm tree
The quilt patch titled
Subject: init/main: fix off-by-one in argv_init cleanup
has been removed from the -mm tree. Its filename was
init-main-fix-off-by-one-in-argv_init-cleanup.patch
This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Wilson Felipe Pereira <[email protected]>
Subject: init/main: fix off-by-one in argv_init cleanup
Date: Tue, 18 Aug 2026 04:53:46 +0000
Patch series "init: fix array boundary bugs in boot parameter parsing".
This series fixes two distinct boundary logic edge-case bugs in init/main.c related to parsing boot command-line arguments and environment variables. Both bugs have been present since the early git history (Linux-2.6.12-rc2).
1. The first patch fixes an off-by-one error in init_setup() where the final slot of the argv_init array was left uncleared. This allowed a stale kernel parameter to leak into the init process's user-space command line if exactly MAX_INIT_ARGS unknown parameters were passed.
2. The second patch fixes a false-positive kernel panic in unknown_bootoption(). If a user filled the environment variable array up to its exact limit (32) and then attempted to overwrite the final variable, the kernel would panic before evaluating whether it was a harmless duplicate.
Exact QEMU reproduction steps for both edge cases are documented inside their respective commit descriptions.
This patch (of 2):
When cleaning up argv_init in init_setup() and rdinit_setup(), the loop terminates one element early due to using '<' instead of '<='. Since argv_init is sized MAX_INIT_ARGS+2, index MAX_INIT_ARGS is a valid element that should be cleared to NULL.
If exactly MAX_INIT_ARGS unknown arguments are passed before 'init=', the uncleared argv_init[MAX_INIT_ARGS] can act as a ghost argument to /sbin/init or cause a spurious kernel panic when later appended to.
To verify the argument leak, boot a VM into a shell with 32 unknown kernel arguments, the init parameter, and 31 user arguments:
STALE_ARGS=$(for i in {1..32}; do echo -n "stale$i "; done)
USER_ARGS=$(for i in {1..31}; do echo -n "user$i "; done)
qemu-system-x86_64 -kernel bzImage \
-append "$STALE_ARGS init=/bin/sh $USER_ARGS"Running cat /proc/1/cmdline inside the shell reveals that the 32nd kernel argument ('stale32') incorrectly leaked into the init process's command line. This patch zeroes the final slot, cleanly terminating the array.
---
init/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
init/main.c renamed from init/main.c~init-main-fix-off-by-one-in-argv_init-cleanup +2 -2
@@ -581,7 +581,7 @@ static int __init init_setup(char *str)* the shell think it should execute a script with such name. * So we ignore all arguments entered _before_ init=... [MJ] */ -for (i =1 ; i <MAX_INIT_ARGS ; i++) +for (i =1 ; i <=MAX_INIT_ARGS ; i++) argv_init[i] =NULL ;return 1 ; }
@@ -594,7 +594,7 @@ static int __init rdinit_setup(char *str ramdisk_execute_command = str; ramdisk_execute_command_set = true;/* See "auto" comment in init_setup */ -for (i =1 ; i <MAX_INIT_ARGS ; i++) +for (i =1 ; i <=MAX_INIT_ARGS ; i++) argv_init[i] =NULL ;return 1 ; }
_
Patches currently in -mm which might be from [email protected] are
mm-zswap-convert-zswap_store_page-and-zswap_compress-to-take-a-folio.patch