Skip to contentSkip to conversation

staging: rtl8723bs: hal: fix a multi-line comment in hal_btcoex.c

PATCH In review Cen Zhang 2 participants 3 messages Oct 7 Staging

lore
Share & tools
lore

Cen Zhang

author
#0 lore raw

PATCH 1/1 staging: rtl8723bs: hal: fix a multi-line comment in hal_btcoex.c

From: "Cen Zhang (Microsoft)" <[email protected]>

The comment in the BTC_GET_BL_WIFI_SCAN switch case of halbtcoutsrc_Get() has coding style issues.

Fix them by placing the opening and closing comment delimiters on separate lines, and keeping each line within 80 columns.

---
 drivers/staging/rtl8723bs/hal/hal_btcoex.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/hal_btcoex.c +5 -2
index a06e2e5b516c..d231b0277b76 100644
@@ -290,8 +290,11 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getType, void *pOutBuf)
 		break;
 
 	case BTC_GET_BL_WIFI_SCAN:
-		/* Use the value of the new variable GLBtcWiFiInScanState to judge whether WiFi is in scan state or not, since the originally used flag
-			WIFI_SITE_MONITOR in fwstate may not be cleared in time */
+		/*
+		 * Use the value of the new variable GLBtcWiFiInScanState to judge
+		 * whether WiFi is in scan state or not, since the originally used
+		 * flag WIFI_SITE_MONITOR in fwstate may not be cleared in time.
+		 */
 		*pu8 = GLBtcWiFiInScanState;
 		break;
 
Signature · 1 line
2.55.0
#1 lore raw
Quoted 11 lines · Cen Zhang

From: "Cen Zhang (Microsoft)" <[email protected]>

The comment in the BTC_GET_BL_WIFI_SCAN switch case of halbtcoutsrc_Get() has coding style issues.

Fix them by placing the opening and closing comment delimiters on separate lines, and keeping each line within 80 columns.

---

[...]

Hi Cen,

I'm just letting you know that this change is no longer needed as the entire staging/rtl8723bs driver is being deprecated and removed. Support for RTL8723BS has been ported to rtw88 (rtw-next) and a pull request that will get it into wireless-next is being sent tomorrow.

Best regards,
Luka Gejak

author
#2 lore raw

Hi Luka,

Thanks for letting me know. I will drop this patch.

Best regards,
Cen