wwan: wwan_hwsim: Pin module for debugfs file operations
Subsystems (4)
PATCH 1/1 wwan: wwan_hwsim: Pin module for debugfs file operations
An open debugfs file retains its file_operations pointer in the debugfs proxy state. However, wwan_hwsim_debugfs_portdestroy_fops, wwan_hwsim_debugfs_portcreate_fops, wwan_hwsim_debugfs_devdestroy_fops, and wwan_hwsim_debugfs_devcreate_fops in wwan_hwsim.c have no .owner set to THIS_MODULE.
As a result, full_proxy_open_regular() calls fops_get() which succeeds without taking a reference to the wwan_hwsim module. When a userspace process opens any of these debugfs files, a subsequent module unload (rmmod wwan_hwsim) can succeed while the file descriptor remains open.
When the userspace process subsequently closes the descriptor, full_proxy_release() accesses the already unmapped file_operations structure, triggering a kernel oops in full_proxy_release():
BUG: unable to handle page fault for address: fffffbfff84f90ef Oops: 0000 [#2] SMP KASAN NOPTI RIP: 0010:full_proxy_release+0x8e/0x140 Call Trace: <TASK> __fput+0x357/0xaa0 fput_close_sync+0xe6/0x1a0 file_close_fd_locked+0x17e/0x2f0 do_close+0x33/0x70 __x64_sys_close+0x44/0x80 do_syscall_64+0xc3/0x590 entry_SYSCALL_64_after_hwframe+0x76/0x7e </TASK>
The issue was discovered via manual code audit of wwan_hwsim.c and reproduced on a Linux 7.3-rc6 test VM with CONFIG_WWAN_HWSIM=m.
Set .owner = THIS_MODULE on all four debugfs file_operations structures in wwan_hwsim.c so that debugfs pins the module until close has completed.
--- drivers/net/wwan/wwan_hwsim.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/wwan/wwan_hwsim.c +4 -0
@@ -500,6 +500,7 @@ static ssize_t wwan_hwsim_debugfs_portdestroy_write(struct file *file, }static const struct file_operations wwan_hwsim_debugfs_portdestroy_fops = { + .owner =THIS_MODULE , .write = wwan_hwsim_debugfs_portdestroy_write, .open = simple_open, .llseek = noop_llseek,
@@ -524,6 +525,7 @@ static ssize_t wwan_hwsim_debugfs_portcreate_write(struct file *file, }static const struct file_operations wwan_hwsim_debugfs_portcreate_fops = { + .owner =THIS_MODULE , .write = wwan_hwsim_debugfs_portcreate_write, .open = simple_open, .llseek = noop_llseek,
@@ -545,6 +547,7 @@ static ssize_t wwan_hwsim_debugfs_devdestroy_write(struct file *file, }static const struct file_operations wwan_hwsim_debugfs_devdestroy_fops = { + .owner =THIS_MODULE , .write = wwan_hwsim_debugfs_devdestroy_write, .open = simple_open, .llseek = noop_llseek,
@@ -568,6 +571,7 @@ static ssize_t wwan_hwsim_debugfs_devcreate_write(struct file *file, }static const struct file_operations wwan_hwsim_debugfs_devcreate_fops = { + .owner =THIS_MODULE , .write = wwan_hwsim_debugfs_devcreate_write, .open = simple_open, .llseek = noop_llseek,
Signature · 1 line
2.43.0
Quoted 33 lines · Bui Viet Dung
An open debugfs file retains its
file_operationspointer in the debugfs proxy state. However,wwan_hwsim_debugfs_portdestroy_fops,wwan_hwsim_debugfs_portcreate_fops,wwan_hwsim_debugfs_devdestroy_fops, andwwan_hwsim_debugfs_devcreate_fopsinwwan_hwsim.chave no .owner set toTHIS_MODULE.As a result,
full_proxy_open_regular()callsfops_get()which succeeds without taking a reference to thewwan_hwsimmodule. When a userspace process opens any of these debugfs files, a subsequent module unload (rmmodwwan_hwsim) can succeed while the file descriptor remains open.When the userspace process subsequently closes the descriptor,
full_proxy_release()accesses the already unmappedfile_operationsstructure, triggering a kernel oops infull_proxy_release():BUG: unable to handle page fault for address: fffffbfff84f90ef Oops: 0000 [#2] SMP KASAN NOPTI RIP: 0010:full_proxy_release+0x8e/0x140 Call Trace: <TASK> __fput+0x357/0xaa0 fput_close_sync+0xe6/0x1a0 file_close_fd_locked+0x17e/0x2f0 do_close+0x33/0x70 __x64_sys_close+0x44/0x80 do_syscall_64+0xc3/0x590 entry_SYSCALL_64_after_hwframe+0x76/0x7e </TASK>The issue was discovered via manual code audit of
wwan_hwsim.cand reproduced on a Linux 7.3-rc6 test VM withCONFIG_WWAN_HWSIM=m.
Quoted 7 lines
Set .owner =
THIS_MODULEon all four debugfsfile_operationsstructures inwwan_hwsim.cso that debugfs pins the module until close has completed.Fixes 9ee23f48f670 ("wwan_hwsim: add debugfs management interface")Signed-off-by Bui Viet Dung <[email protected]>
Quoted 43 lines
--- drivers/net/wwan/wwan_hwsim.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/net/wwan/wwan_hwsim.c +4
-1@@ -500,6 +500,7 @@ static ssize_t wwan_hwsim_debugfs_portdestroy_write(struct file *file, }static const struct file_operations wwan_hwsim_debugfs_portdestroy_fops = { + .owner =THIS_MODULE , .write = wwan_hwsim_debugfs_portdestroy_write, .open = simple_open, .llseek = noop_llseek,@@ -524,6 +525,7 @@ static ssize_t wwan_hwsim_debugfs_portcreate_write(struct file *file, }static const struct file_operations wwan_hwsim_debugfs_portcreate_fops = { + .owner =THIS_MODULE , .write = wwan_hwsim_debugfs_portcreate_write, .open = simple_open, .llseek = noop_llseek,@@ -545,6 +547,7 @@ static ssize_t wwan_hwsim_debugfs_devdestroy_write(struct file *file, }static const struct file_operations wwan_hwsim_debugfs_devdestroy_fops = { + .owner =THIS_MODULE , .write = wwan_hwsim_debugfs_devdestroy_write, .open = simple_open, .llseek = noop_llseek,@@ -568,6 +571,7 @@ static ssize_t wwan_hwsim_debugfs_devcreate_write(struct file *file, }static const struct file_operations wwan_hwsim_debugfs_devcreate_fops = { + .owner =THIS_MODULE , .write = wwan_hwsim_debugfs_devcreate_write, .open = simple_open, .llseek = noop_llseek, --2.43.0
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:
Quoted 6 lines · On Thu, 8 Oct 2026 20:07:53 +0700 you wrote:
An open debugfs file retains its
file_operationspointer in the debugfs proxy state. However,wwan_hwsim_debugfs_portdestroy_fops,wwan_hwsim_debugfs_portcreate_fops,wwan_hwsim_debugfs_devdestroy_fops, andwwan_hwsim_debugfs_devcreate_fopsinwwan_hwsim.chave no .owner set toTHIS_MODULE.
Quoted 6 lines
As a result,
full_proxy_open_regular()callsfops_get()which succeeds without taking a reference to thewwan_hwsimmodule. When a userspace process opens any of these debugfs files, a subsequent module unload (rmmodwwan_hwsim) can succeed while the file descriptor remains open.[...]
Here is the summary with links:
- wwan: wwan_hwsim: Pin module for debugfs file operations
https://git.kernel.org/netdev/net-next/c/a388f17e23b7
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html