wifi: b43: fix use-after-free in b43_bcma_remove()
Subsystems (2)
PATCH 1/1 wifi: b43: fix use-after-free in b43_bcma_remove()
b43_one_core_detach() frees the struct b43_wldev it is given the bus device of. b43_bcma_remove() then reads wldev->dev again to free the bus device, which is a read of freed memory.
b43_ssb_remove() does not have the problem: it takes a copy of wldev->dev at the start. Do the same here.
--- drivers/net/wireless/broadcom/b43/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/wireless/broadcom/b43/main.c +3 -2
@@ -5677,6 +5677,7 @@ static void b43_bcma_remove(struct bcma_device *core) {struct b43_wldev *wldev =bcma_get_drvdata (core);struct b43_wl *wl = wldev->wl; +struct b43_bus_dev *dev = wldev->dev;/* We must cancel any work here before unregistering from ieee80211, * as the ieee80211 unreg will destroy the workqueue. */
@@ -5691,14 +5692,14 @@ static void b43_bcma_remove(struct bcma_device *core)ieee80211_unregister_hw (wl->hw); } -b43_one_core_detach (wldev->dev); +b43_one_core_detach (dev);/* Unregister HW RNG driver */ b43_rng_exit (wl);b43_leds_unregister (wl);ieee80211_free_hw (wl->hw); -kfree (wldev->dev); +kfree (dev); }static struct bcma_driver b43_bcma_driver = {
Signature · 1 line
2.54.0
Adding the people the CI bot listed as not CCed (b43 author and others working on b43), for information. No changes to the patch.
The bug is in mainline: b43_bcma_remove() reads wldev->dev after b43_one_core_detach() has freed wldev. b43_ssb_remove() already takes a copy, so the patch does the same.
Andreas
Quoted 17 lines · On Tue, 13 Oct 2026 02:01:24 +0200 Andreas Wendleder <[email protected]> wrote:
drivers/net/wireless/broadcom/b43/main.c +2
-1@@ -5677,6 +5677,7 @@ static void b43_bcma_remove(struct bcma_device *core) {struct b43_wldev *wldev =bcma_get_drvdata (core);struct b43_wl *wl = wldev->wl; +struct b43_bus_dev *dev = wldev->dev;/* We must cancel any work here before unregistering from ieee80211, * as the ieee80211 unreg will destroy the workqueue. */ @@ -5691,14 +5692,14 @@ static void b43_bcma_remove(struct bcma_device *core)ieee80211_unregister_hw (wl->hw); } -b43_one_core_detach (wldev->dev); +b43_one_core_detach (dev);
drivers/net/wireless/broadcom/b43/main.c static void b43_bcma_remove(struct bcma_device *core) · line 5705
Quoted 10 lines
drivers/net/wireless/broadcom/b43/main.c +1
-1/* Unregister HW RNG driver */ b43_rng_exit (wl);b43_leds_unregister (wl);ieee80211_free_hw (wl->hw); -kfree (wldev->dev); +kfree (dev); }static struct bcma_driver b43_bcma_driver = {
Signature · 2 lines
Michael Büsch https://bues.ch/
_______________________________________________
b43-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/b43-dev