Skip to contentSkip to conversation

mm-mglru-restore-accidentally-removed-seq-max_seq-check.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Oct 13

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/mglru: restore accidentally removed seq < max_seq check
has been removed from the -mm tree. Its filename was
mm-mglru-restore-accidentally-removed-seq-max_seq-check.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: "Barry Song (Xiaomi)" <[email protected]>
Subject: mm/mglru: restore accidentally removed seq < max_seq check
Date: Tue, 15 Sep 2026 18:15:56 +0800

Since commit 798c0330c2ca ("mm/mglru: rework aging feedback"), the following sanity check was accidentally removed:

if (seq < max_seq)
return 0;

That means we can perform aging for any value less than or equal to max_gen_nr.

This has been inconsistent with Documentation/admin-guide/mm/multigen_lru.rst, which states:

Users can write the following command to ``lru_gen`` to create a new generation ``max_gen_nr+1``:

     ``+ memcg_id node_id max_gen_nr [can_swap [force_scan]]``

The correct semantics are that writing a value smaller than max_gen_nr should return 0, since the requested generation already exists.

Fixes 798c0330c2ca ("mm/mglru: rework aging feedback")
Cc Axel Rasmussen <[email protected]>
Cc Baoquan He <[email protected]>
Cc David Hildenbrand <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Shakeel Butt <[email protected]>
Cc Wei Xu <[email protected]>
Cc Yuanchu Xie <[email protected]>
Cc Yu Zhao <[email protected]>

---

 mm/vmscan.c |    3 +++
 1 file changed, 3 insertions(+)
mm/vmscan.c renamed from mm/vmscan.c~mm-mglru-restore-accidentally-removed-seq-max_seq-check +3 -0
@@ -5839,6 +5839,9 @@ static int run_aging(struct lruvec *lruv
 {
 	DEFINE_MAX_SEQ(lruvec);
 
+	if (seq < max_seq)
+		return 0;
+
 	if (seq > max_seq)
 		return -EINVAL;
 

_

Patches currently in -mm which might be from [email protected] are