Skip to contentSkip to conversation

rpmsg: mtk: release channel OF node on device teardown

PATCH Applied Avi Weiss 2 participants 2 messages Oct 13 – Oct 14

Subsystems (2)
lore
Share & tools
lore

Avi Weiss

author
#0 lore raw

PATCH 1/1 rpmsg: mtk: release channel OF node on device teardown

mtk_rpmsg_match_device_subnode() returns a referenced OF child node, which is stored in rpdev->dev.of_node.

mtk_rpmsg_release_device() later frees the containing allocation without dropping that ref.

Release the OF node when the RPMsg device is destroyed.

Fixes 7017996951fd ("rpmsg: add rpmsg support for mt8183 SCP.")
---
 drivers/rpmsg/mtk_rpmsg.c | 1 +
 1 file changed, 1 insertion(+)
drivers/rpmsg/mtk_rpmsg.c +1 -0
index 1b670ed54cfa2..430a9b2aa7bb9 100644
@@ -168,6 +168,7 @@ static void mtk_rpmsg_release_device(struct device *dev)
 	struct rpmsg_device *rpdev = to_rpmsg_device(dev);
 	struct mtk_rpmsg_device *mdev = to_mtk_rpmsg_device(rpdev);
 
+	of_node_put(dev->of_node);
 	kfree(mdev);
 }
 

base-commit: 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907

Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 19 lines · Avi Weiss

mtk_rpmsg_match_device_subnode() returns a referenced OF child node, which is stored in rpdev->dev.of_node.

mtk_rpmsg_release_device() later frees the containing allocation without dropping that ref.

Release the OF node when the RPMsg device is destroyed.

Fixes 7017996951fd ("rpmsg: add rpmsg support for mt8183 SCP.")
---
 drivers/rpmsg/mtk_rpmsg.c | 1 +
 1 file changed, 1 insertion(+)
drivers/rpmsg/mtk_rpmsg.c +0 -0
index 1b670ed54cfa2..430a9b2aa7bb9 100644

drivers/rpmsg/mtk_rpmsg.c static void mtk_rpmsg_release_device(struct device *dev) · line 173

Quoted 6 lines
drivers/rpmsg/mtk_rpmsg.c +1 -0
@@ -168,6 +168,7 @@ static void mtk_rpmsg_release_device(struct device *dev)
 	struct rpmsg_device *rpdev = to_rpmsg_device(dev);
 	struct mtk_rpmsg_device *mdev = to_mtk_rpmsg_device(rpdev);
 
+	of_node_put(dev->of_node);
 	kfree(mdev);
 }

Applied.

Thanks,
Mathieu

Quoted 6 lines

base-commit: 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907

Signature · 1 line
2.43.0