Skip to contentSkip to conversation

rtl8723bs: Remove redundant macro in basic_types.h

PATCH In review [email protected] 2 participants 3 messages Oct 16 – Oct 17 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtl8723bs: Remove redundant macro in basic_types.h

From: Alexis Buttler <[email protected]>

LE_BITS_CLEARED_TO_1BYTE_8BIT() is only used by SET_BITS_TO_LE_1BYTE_8BIT(),
and its implementation simply expands to LE_P1BYTE_TO_HOST_1BYTE().
Remove LE_BITS_CLEARED_TO_1BYTE_8BIT() and replace its original invocation with the definition.

---
 drivers/staging/rtl8723bs/include/basic_types.h | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/staging/rtl8723bs/include/basic_types.h +1 -6
index d2436459cff6..e2abbf691e21 100644
@@ -143,16 +143,11 @@
 		((((u8)__val) & BIT_LEN_MASK_8(__bitlen)) << (__bitoffset)) \
 		))
 
-#define LE_BITS_CLEARED_TO_1BYTE_8BIT(__pStart, __BitOffset, __BitLen) \
-	(\
-		LE_P1BYTE_TO_HOST_1BYTE(__pStart) \
-	)
-
 #define SET_BITS_TO_LE_1BYTE_8BIT(__pStart, __BitOffset, __BitLen, __Value) \
 { \
 	*((u8 *)(__pStart)) = \
 		EF1Byte(\
-			LE_BITS_CLEARED_TO_1BYTE_8BIT(__pStart, __BitOffset, __BitLen) \
+			LE_P1BYTE_TO_HOST_1BYTE(__pStart) \
 			| \
 			((u8)__Value) \
 		); \
Signature · 1 line
2.53.0
#1 lore raw
Quoted 8 lines · iuseacosbtw

From: Alexis Buttler <[email protected]>

LE_BITS_CLEARED_TO_1BYTE_8BIT() is only used by SET_BITS_TO_LE_1BYTE_8BIT(),
and its implementation simply expands to LE_P1BYTE_TO_HOST_1BYTE().
Remove LE_BITS_CLEARED_TO_1BYTE_8BIT() and replace its original invocation with the definition.

---

No more patches for this driver are being accepted. This driver is being deleted in the next merge window.

Thanks,
ET

#2 lore raw
Quoted 2 lines

No more patches for this driver are being accepted. This driver is being deleted in the next merge window.

Thank you, this saves me a lot of time!