ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD
PATCH 1/1 ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD
There have been reports about a regression with the recent boot quirk for Behringer devices; it broke UMC204HD models(1397:0508 and 1397:0509). The quirk was to just run usb_get_descriptor(), so I expected it rather harmful, but in this case, it doesn't look so, resulting in an error like 'failed to read device descriptor: -110' that leads to a fatal probe error.
As a quick workaround, skip the quirk for those UMC204HD models.
--- sound/usb/quirks.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
sound/usb/quirks.c +8 -1
@@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev, }/* Behringer devices may need explicit device descriptor read at boot */ -if (USB_ID_VENDOR (id) ==0x1397 ) +if (USB_ID_VENDOR (id) ==0x1397 ) { +/* the quirk seems breaking on some Behringer devices */ +switch (id) { +case USB_ID (0x1397 ,0x0508 ):/* UMC204HD */ +case USB_ID (0x1397 ,0x0509 ):/* UMC204HD */ +return 0 ; + }return snd_usb_cm1a_boot_quirk (dev); + }return 0 ; }
Signature · 1 line
2.55.0
Hi Takashi,
Quoted 23 lines · Takashi Iwai
There have been reports about a regression with the recent boot quirk for Behringer devices; it broke UMC204HD models(1397:0508 and 1397:0509). The quirk was to just run
usb_get_descriptor(), so I expected it rather harmful, but in this case, it doesn't look so, resulting in an error like 'failed to read device descriptor: -110' that leads to a fatal probe error.As a quick workaround, skip the quirk for those UMC204HD models.
Fixes b5c4823cf3e4 ("ALSA: usb-audio: Apply boot quirk for Behringer models generically")Reported-by Will Bush <[email protected]>Signed-off-by Takashi Iwai <[email protected]>--- sound/usb/quirks.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)sound/usb/quirks.c +0
-0
sound/usb/quirks.c int snd_usb_apply_boot_quirk_once(struct usb_device *dev, · line 1797
Quoted 9 lines
sound/usb/quirks.c +5
-1@@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev, }/* Behringer devices may need explicit device descriptor read at boot */ -if (USB_ID_VENDOR (id) ==0x1397 ) +if (USB_ID_VENDOR (id) ==0x1397 ) { +/* the quirk seems breaking on some Behringer devices */ +switch (id) { +case USB_ID (0x1397 ,0x0508 ):/* UMC204HD */ +case USB_ID (0x1397 ,0x0509 ):/* UMC204HD */
0x0509 is the UMC404HD
https://linux-hardware.org/?id=usb:1397-0509
Best regards,
Gergo
Quoted 39 lines · Gergo Koteles
Hi Takashi,
Quoted 23 lines · Takashi Iwai
There have been reports about a regression with the recent boot quirk for Behringer devices; it broke UMC204HD models(1397:0508 and 1397:0509). The quirk was to just run
usb_get_descriptor(), so I expected it rather harmful, but in this case, it doesn't look so, resulting in an error like 'failed to read device descriptor: -110' that leads to a fatal probe error.As a quick workaround, skip the quirk for those UMC204HD models.
Fixes b5c4823cf3e4 ("ALSA: usb-audio: Apply boot quirk for Behringer models generically")Reported-by Will Bush <[email protected]>Signed-off-by Takashi Iwai <[email protected]>--- sound/usb/quirks.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)sound/usb/quirks.c +0
-0sound/usb/quirks.c int snd_usb_apply_boot_quirk_once(struct usb_device *dev, · line 1797
Quoted 9 lines
sound/usb/quirks.c +5
-1@@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev, }/* Behringer devices may need explicit device descriptor read at boot */ -if (USB_ID_VENDOR (id) ==0x1397 ) +if (USB_ID_VENDOR (id) ==0x1397 ) { +/* the quirk seems breaking on some Behringer devices */ +switch (id) { +case USB_ID (0x1397 ,0x0508 ):/* UMC204HD */ +case USB_ID (0x1397 ,0x0509 ):/* UMC204HD */
0x0509is the UMC404HD
Quoted 1 line
You're right. I'll correct it.
thanks,
Takashi
Quoted 1 line · Takashi Iwai
As a quick workaround, skip the quirk for those UMC204HD models.
I tested your patch on 7.2.10 with my UMC204HD (1397:0508) and it works. Thanks!
Best,
Will