Skip to contentSkip to conversation

ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD

PATCH In review Takashi Iwai 3 participants 4 messages Oct 19 – Oct 24 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD

There have been reports about a regression with the recent boot quirk for Behringer devices; it broke UMC204HD models(1397:0508 and 1397:0509). The quirk was to just run usb_get_descriptor(), so I expected it rather harmful, but in this case, it doesn't look so, resulting in an error like 'failed to read device descriptor: -110' that leads to a fatal probe error.

As a quick workaround, skip the quirk for those UMC204HD models.

Fixes b5c4823cf3e4 ("ALSA: usb-audio: Apply boot quirk for Behringer models generically")
---
 sound/usb/quirks.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
sound/usb/quirks.c +8 -1
index 4fadb1fdcdea..4ac4aef47dd7 100644
@@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev,
 	}
 
 	/* Behringer devices may need explicit device descriptor read at boot */
-	if (USB_ID_VENDOR(id) == 0x1397)
+	if (USB_ID_VENDOR(id) == 0x1397) {
+		/* the quirk seems breaking on some Behringer devices */
+		switch (id) {
+		case USB_ID(0x1397, 0x0508): /* UMC204HD */
+		case USB_ID(0x1397, 0x0509): /* UMC204HD */
+			return 0;
+		}
 		return snd_usb_cm1a_boot_quirk(dev);
+	}
 
 	return 0;
 }
Signature · 1 line
2.55.0
#1 lore raw

Hi Takashi,

Quoted 23 lines · Takashi Iwai

There have been reports about a regression with the recent boot quirk for Behringer devices; it broke UMC204HD models(1397:0508 and 1397:0509). The quirk was to just run usb_get_descriptor(), so I expected it rather harmful, but in this case, it doesn't look so, resulting in an error like 'failed to read device descriptor: -110' that leads to a fatal probe error.

As a quick workaround, skip the quirk for those UMC204HD models.

Fixes b5c4823cf3e4 ("ALSA: usb-audio: Apply boot quirk for Behringer models generically")
---
 sound/usb/quirks.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
sound/usb/quirks.c +0 -0
index 4fadb1fdcdea..4ac4aef47dd7 100644

sound/usb/quirks.c int snd_usb_apply_boot_quirk_once(struct usb_device *dev, · line 1797

Quoted 9 lines
sound/usb/quirks.c +5 -1
@@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev,
 	}
 
 	/* Behringer devices may need explicit device descriptor read at boot */
-	if (USB_ID_VENDOR(id) == 0x1397)
+	if (USB_ID_VENDOR(id) == 0x1397) {
+		/* the quirk seems breaking on some Behringer devices */
+		switch (id) {
+		case USB_ID(0x1397, 0x0508): /* UMC204HD */
+		case USB_ID(0x1397, 0x0509): /* UMC204HD */

0x0509 is the UMC404HD

https://linux-hardware.org/?id=usb:1397-0509

Best regards,
Gergo

#2 lore raw
Quoted 39 lines · Gergo Koteles

Hi Takashi,

Quoted 23 lines · Takashi Iwai

There have been reports about a regression with the recent boot quirk for Behringer devices; it broke UMC204HD models(1397:0508 and 1397:0509). The quirk was to just run usb_get_descriptor(), so I expected it rather harmful, but in this case, it doesn't look so, resulting in an error like 'failed to read device descriptor: -110' that leads to a fatal probe error.

As a quick workaround, skip the quirk for those UMC204HD models.

Fixes b5c4823cf3e4 ("ALSA: usb-audio: Apply boot quirk for Behringer models generically")
---
 sound/usb/quirks.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
sound/usb/quirks.c +0 -0
index 4fadb1fdcdea..4ac4aef47dd7 100644

sound/usb/quirks.c int snd_usb_apply_boot_quirk_once(struct usb_device *dev, · line 1797

Quoted 9 lines
sound/usb/quirks.c +5 -1
@@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev,
 	}
 
 	/* Behringer devices may need explicit device descriptor read at boot */
-	if (USB_ID_VENDOR(id) == 0x1397)
+	if (USB_ID_VENDOR(id) == 0x1397) {
+		/* the quirk seems breaking on some Behringer devices */
+		switch (id) {
+		case USB_ID(0x1397, 0x0508): /* UMC204HD */
+		case USB_ID(0x1397, 0x0509): /* UMC204HD */

0x0509 is the UMC404HD

Quoted 1 line

https://linux-hardware.org/?id=usb:1397-0509

You're right. I'll correct it.

thanks,

Takashi