profiling: fix sampling step on 64-bit big-endian systems
PATCH 1/1 profiling: fix sampling step on 64-bit big-endian systems
read_profile() stores the sampling step in an unsigned long but copies only four bytes to userspace. On 64-bit big-endian systems (not common obviously), this copies the upper 32 bits and discards teh rest, causing /proc/profile to report zero for normal shift values.
Cast to unsigned int so we get the correct 4 bytes, while keeping the shift calculation in unsigned long.
A small C reproducer under qemu-s390x reproduced this and proved the fix works for prof_shift=2.
---
kernel/profile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/profile.c +1 -1
@@ -156,7 +156,7 @@ read_profile(struct file *file, char __user *buf, size_t count, loff_t *ppos)unsigned long p = *ppos;ssize_t read;char *pnt; -unsigned long sample_step =1UL << prof_shift; +unsigned int sample_step = (unsigned int )(1UL << prof_shift);if (p >= (prof_len+1 )*sizeof (unsigned int ))return 0 ;
Signature · 1 line
2.43.0
Quoted 11 lines · Avi Weiss
read_profile()stores the sampling step in an unsigned long but copies only four bytes to userspace. On 64-bit big-endian systems (not common obviously), this copies the upper 32 bits and discards teh rest, causing/proc/profileto report zero for normal shift values.Cast to unsigned int so we get the correct 4 bytes, while keeping the shift calculation in unsigned long.
A small C reproducer under qemu-s390x reproduced this and proved the fix works for prof_shift=2.
If you wanna be 100% sure that this is regression free, you could test building on all arches. Sometimes linking fails in cases.
Quoted 13 lines
Fixes 2d186afd04d6 ("profiling: fix shift-out-of-bounds bugs")Signed-off-by Avi Weiss <[email protected]>---
kernel/profile.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)kernel/profile.c +0
-0
kernel/profile.c read_profile(struct file *file, char __user *buf, size_t count, loff_t *ppos) · line 159
Quoted 5 lines
kernel/profile.c +1
-1@@ -156,7 +156,7 @@ read_profile(struct file *file, char __user *buf, size_t count, loff_t *ppos)unsigned long p = *ppos;ssize_t read;char *pnt; -unsigned long sample_step =1UL << prof_shift; +unsigned int sample_step = (unsigned int )(1UL << prof_shift);
But this would compile anyway.
kernel/profile.c read_profile(struct file *file, char __user *buf, size_t count, loff_t *ppos)
Quoted 4 lines
kernel/profile.c +0
-0if (p >= (prof_len+1 )*sizeof (unsigned int ))return 0 ;
--- Thanks!
"I'm not a very positive person" - Linus torvalds
I'm happy to try it anyway - just so I know how for future patches. I'll see how many I can run through before my laptop gives up ;-)
Quoted 48 lines · Bradley Morgan
Quoted 11 lines · Avi Weiss
read_profile()stores the sampling step in an unsigned long but copies only four bytes to userspace. On 64-bit big-endian systems (not common obviously), this copies the upper 32 bits and discards teh rest, causing/proc/profileto report zero for normal shift values.Cast to unsigned int so we get the correct 4 bytes, while keeping the shift calculation in unsigned long.
A small C reproducer under qemu-s390x reproduced this and proved the fix works for prof_shift=2.
If you wanna be 100% sure that this is regression free, you could test building on all arches. Sometimes linking fails in cases.
Quoted 13 lines
Fixes 2d186afd04d6 ("profiling: fix shift-out-of-bounds bugs")Signed-off-by Avi Weiss <[email protected]>---
kernel/profile.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)kernel/profile.c +0
-0kernel/profile.c read_profile(struct file *file, char __user *buf, size_t count, loff_t *ppos) · line 159
Quoted 5 lines
kernel/profile.c +1
-1@@ -156,7 +156,7 @@ read_profile(struct file *file, char __user *buf, size_t count, loff_t *ppos)unsigned long p = *ppos;ssize_t read;char *pnt; -unsigned long sample_step =1UL << prof_shift; +unsigned int sample_step = (unsigned int )(1UL << prof_shift);But this would compile anyway.
Reviewed-by Bradley Morgan <[email protected]>kernel/profile.c read_profile(struct file *file, char __user *buf, size_t count, loff_t *ppos)
Quoted 4 lines
kernel/profile.c +0
-0if (p >= (prof_len+1 )*sizeof (unsigned int ))return 0 ;--- Thanks!
"I'm not a very positive person" - Linus torvalds
Quoted 2 lines · Avi Weiss
I'm happy to try it anyway - just so I know how for future patches. I'll see how many I can run through before my laptop gives up ;-)
sometimes the crux is for these kinds of patches something in some cryptic arch gets messed up in vmlinux stage, odd right?
This *makes sense* for me, off the top of my head and thinking hard id say this *shouldn't* do anything bad to a cryptic architecture, but I've been shocked in the past.
Quoted 27 lines · Bradley Morgan
Quoted 25 lines · Avi Weiss
Quoted 11 lines
read_profile()stores the sampling step in an unsigned long but copies only four bytes to userspace. On 64-bit big-endian systems (not common obviously), this copies the upper 32 bits and discards teh rest, causing/proc/profileto report zero for normal shift values.Cast to unsigned int so we get the correct 4 bytes, while keeping the shift calculation in unsigned long.
A small C reproducer under qemu-s390x reproduced this and proved the fix works for prof_shift=2.
If you wanna be 100% sure that this is regression free, you could test building on all arches. Sometimes linking fails in cases.
Quoted 8 lines
Fixes 2d186afd04d6 ("profiling: fix shift-out-of-bounds bugs")Signed-off-by Avi Weiss <[email protected]>---
kernel/profile.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 25 lines
Quoted 5 lines
kernel/profile.c read_profile(struct file *file, char __user *buf,
Quoted 5 lines
kernel/profile.c +0
-0@@ -156,7 +156,7 @@ read_profile(struct file *file, char __user *buf,
size_tcount,loff_t*ppos)Quoted 18 lines
kernel/profile.c read_profile(struct file *file, char __user *buf, size_t count, loff_t *ppos) · line 159
Quoted 5 lines
kernel/profile.c +1
-1unsigned long p = *ppos;ssize_t read;char *pnt; -unsigned long sample_step =1UL << prof_shift; +unsigned int sample_step = (unsigned int )(1UL << prof_shift);But this would compile anyway.
Reviewed-by Bradley Morgan <[email protected]>kernel/profile.c read_profile(struct file *file, char __user *buf, size_t count, loff_t *ppos)
Quoted 4 lines
kernel/profile.c +0
-0if (p >= (prof_len+1 )*sizeof (unsigned int ))return 0 ;--- Thanks!
"I'm not a very positive person" - Linus torvalds
--- Thanks!
"I'm not a very positive person" - Linus torvalds
Quoted 10 lines · On Tue, 20 Oct 2026 17:50:24 +0100 Bradley Morgan <[email protected]> wrote:
Quoted 2 lines · Avi Weiss
I'm happy to try it anyway - just so I know how for future patches. I'll see how many I can run through before my laptop gives up ;-)
sometimes the crux is for these kinds of patches something in some cryptic arch gets messed up in vmlinux stage, odd right?
This *makes sense* for me, off the top of my head and thinking hard id say this *shouldn't* do anything bad to a cryptic architecture, but I've been shocked in the past.
OK, read_profile() makes me question my career choices.
It starts out with totally inappropriate type choices then bandaids over that by typecasting just about every damn thing in there. None of it is commented, natch.
I'll grab Avi's fix for this merge window. I persuaded the coin-operated coding machine to generate a couple of patches to fix a pre-existing thing and to clean up that code. I'll send them separately so Sashiko takes a look. Please review.
FYI Bradley I left it running overnight and got these to compile successfully:
s390x
sparc64
powerpc64-bex86_64
arm64
i386
powerpc64-le
mips
riscv64
loongarch
armhf
armel
alpha
arc
microblaze
xtensa
csky
um
nios2
These I couldn't get the toolchain settings right so they never started:
parisc64
m68k
sh
hexagon
Quoted 24 lines · Andrew Morton
Quoted 10 lines · On Tue, 20 Oct 2026 17:50:24 +0100 Bradley Morgan <[email protected]> wrote:
Quoted 2 lines · Avi Weiss
I'm happy to try it anyway - just so I know how for future patches. I'll see how many I can run through before my laptop gives up ;-)
sometimes the crux is for these kinds of patches something in some cryptic arch gets messed up in vmlinux stage, odd right?
This *makes sense* for me, off the top of my head and thinking hard id say this *shouldn't* do anything bad to a cryptic architecture, but I've been shocked in the past.
OK,
read_profile()makes me question my career choices.It starts out with totally inappropriate type choices then bandaids over that by typecasting just about every damn thing in there. None of it is commented, natch.
I'll grab Avi's fix for this merge window. I persuaded the coin-operated coding machine to generate a couple of patches to fix a pre-existing thing and to clean up that code. I'll send them separately so Sashiko takes a look. Please review.