Enabling Sashiko replies to linux-crypto?
Currently, Sashiko is configured (in
https://github.com/sashiko-dev/sashiko/blob/main/projects/linux/mailing_lists.toml)
to monitor linux-crypto for patches, but not to send emails to it.
Would there be any objections to me opening a pull request that changes it to the same setting that I set the fscrypt and fsverity lists to?
["[email protected]"] reply_to = ["author", "list", "recipients"]
That would enable emails for issues found, with reply-all.
(There's also a 'positive_review = "all"' setting that would enable emails for positive reviews, i.e. "Sashiko has reviewed this patch and found no issues. It looks great!" But those are kind of noisy.)
- Eric
I was looking to do this on the wireguard mailing list too. (I have some review comments on a PR I need to address for that.) No objections from me.
Herbert Xu
maintainerQuoted 7 lines · Eric Biggers
Currently, Sashiko is configured (in
https://github.com/sashiko-dev/sashiko/blob/main/projects/linux/mailing_lists.toml)
to monitor linux-crypto for patches, but not to send emails to it.Would there be any objections to me opening a pull request that changes it to the same setting that I set the fscrypt and fsverity lists to?
Quoted 8 lines
["[email protected]"] reply_to = ["author", "list", "recipients"]That would enable emails for issues found, with reply-all.
(There's also a '
positive_review= "all"' setting that would enable emails for positive reviews, i.e. "Sashiko has reviewed this patch and found no issues. It looks great!" But those are kind of noisy.)
Sure that sounds like a good idea.
Thanks,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 7 lines · Eric Biggers
Currently, Sashiko is configured (in
https://github.com/sashiko-dev/sashiko/blob/main/projects/linux/mailing_lists.toml)
to monitor linux-crypto for patches, but not to send emails to it.Would there be any objections to me opening a pull request that changes it to the same setting that I set the fscrypt and fsverity lists to?
Quoted 8 lines
["[email protected]"] reply_to = ["author", "list", "recipients"]That would enable emails for issues found, with reply-all.
(There's also a '
positive_review= "all"' setting that would enable emails for positive reviews, i.e. "Sashiko has reviewed this patch and found no issues. It looks great!" But those are kind of noisy.)
Is it possible to configure it in a way that it only sends mails if it really found something? ... always getting "Sashiko has reviewed this patch and it looks great" mails is rather annoying than helpful ...
Thomas
Quoted 11 lines · Thomas Huth
Quoted 10 lines · Eric Biggers
Currently, Sashiko is configured (in
https://github.com/sashiko-dev/sashiko/blob/main/projects/linux/mailing_lists.toml)
to monitor linux-crypto for patches, but not to send emails to it.Would there be any objections to me opening a pull request that changes it to the same setting that I set the fscrypt and fsverity lists to?
["[email protected]"] reply_to = ["author", "list", "recipients"]
Quoted 8 lines
Quoted 5 lines
That would enable emails for issues found, with reply-all.
(There's also a '
positive_review= "all"' setting that would enable emails for positive reviews, i.e. "Sashiko has reviewed this patch and found no issues. It looks great!" But those are kind of noisy.)Is it possible to configure it in a way that it only sends mails if it really found something? ... always getting "Sashiko has reviewed this patch and it looks great" mails is rather annoying than helpful ...
Yes, that's what I proposed above (and it's merged now).
- Eric
Quoted 14 lines · Eric Biggers
Quoted 13 lines · Thomas Huth
Quoted 12 lines · Eric Biggers
Currently, Sashiko is configured (in
https://github.com/sashiko-dev/sashiko/blob/main/projects/linux/mailing_lists.toml)
to monitor linux-crypto for patches, but not to send emails to it.Would there be any objections to me opening a pull request that changes it to the same setting that I set the fscrypt and fsverity lists to?
["[email protected]"] reply_to = ["author", "list", "recipients"]That would enable emails for issues found, with reply-all.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
(There's also a '
positive_review= "all"' setting that would enable emails for positive reviews, i.e. "Sashiko has reviewed this patch and found no issues. It looks great!" But those are kind of noisy.)Is it possible to configure it in a way that it only sends mails if it really found something? ... always getting "Sashiko has reviewed this patch and it looks great" mails is rather annoying than helpful ...
Yes, that's what I proposed above (and it's merged now).
Oh, -ENOTENOUGHCOFFEEYET ... Sorry, I should read more closely before answering ;-)
Thomas