gpiolib: Put stubs in order in linux/gpio/driver.h
PATCH 1/1 gpiolib: Put stubs in order in linux/gpio/driver.h
The stubs in linux/gpio/driver.h go in a slightly different order than declarations. Put stubs in the same order.
Signed-off-by Andy Shevchenko <[email protected]>
--- include/linux/gpio/driver.h | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-)
include/linux/gpio/driver.h +11 -13
@@ -837,6 +837,17 @@ struct gpio_device *gpio_device_find_by_fwnode(const struct fwnode_handle *fwnod#include <asm/bug.h> +static inline int gpiochip_lock_as_irq (struct gpio_chip *gc,unsigned int offset) +{ +WARN_ON (1 ); +return -EINVAL ; +} + +static inline void gpiochip_unlock_as_irq (struct gpio_chip *gc,unsigned int offset) +{ +WARN_ON (1 ); +} +static inline struct gpio_chip *gpiod_to_chip (const struct gpio_desc *desc) {/* GPIO can never have been requested */
@@ -873,19 +884,6 @@ static inline struct gpio_device *gpio_device_find_by_fwnode(const struct fwnodeWARN_ON (1 ); return NULL; } - -static inline int gpiochip_lock_as_irq (struct gpio_chip *gc, -unsigned int offset) -{ -WARN_ON (1 ); -return -EINVAL ; -} - -static inline void gpiochip_unlock_as_irq (struct gpio_chip *gc, -unsigned int offset) -{ -WARN_ON (1 ); -}#endif /* CONFIG_GPIOLIB */ static inline bool fwnode_is_gpiochip (struct fwnode_handle *fwnode)
Signature · 1 line
2.50.1
Bartosz Golaszewski
maintainerQuoted 3 lines · Andy Shevchenko
The stubs in
linux/gpio/driver.hgo in a slightly different order than declarations. Put stubs in the same order.
I see your OCD is worse than mine. :)
Though it doesn't apply on top of gpio/for-next.
Bart
Quoted 4 lines · Andy Shevchenko
The stubs in
linux/gpio/driver.hgo in a slightly different order than declarations. Put stubs in the same order.Signed-off-by Andy Shevchenko <[email protected]>
Why not.
Reviewed-by Linus Walleij <[email protected]>
Yours,
Linus Walleij