Skip to contentSkip to conversation

bonding: fix out-of-bounds read of arp_ip_target

PATCH Applied Jiayuan Chen 5 participants 5 messages Oct 23 – Oct 26

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bonding: fix out-of-bounds read of arp_ip_target

arp_ip_target is a module parameter array with BOND_MAX_ARP_TARGETS entries. In the loop parsing it in bond_check_params(), arp_ip_count is the number of accepted targets, while i is the index into arp_ip_target. Invalid and duplicate entries are skipped without bumping arp_ip_count, so bounding the loop with arp_ip_count lets i run past the end of arp_ip_target, e.g. 16 targets with one duplicate:

  BUG: KASAN: global-out-of-bounds in bond_check_params.constprop.0+0x1148/0x1440
  Read of size 8 at addr ffffffff96e9ee00 by task swapper/0/1
  Call Trace:
   <TASK>
   dump_stack_lvl+0x91/0xf0
   print_report+0xd1/0x630
   kasan_report+0xf3/0x130
   __asan_report_load8_noabort+0x14/0x30
   bond_check_params.constprop.0+0x1148/0x1440
   bonding_init+0x13/0xe0
   do_one_initcall+0xe7/0x5b0
   kernel_init_freeable+0xa91/0x1120
   kernel_init+0x24/0x220
   ret_from_fork+0x5b3/0x820
   ret_from_fork_asm+0x1a/0x30
   </TASK>

  The buggy address belongs to the variable:
   arp_ip_target+0x80/0xa0

Bound the loop with i instead. arp_ip_count never exceeds i, so it stays within BOND_MAX_ARP_TARGETS too.

Fixes 5a5c5fd48e3b ("bonding: arp_ip_count and arp_targets can be wrong")
---
 drivers/net/bonding/bond_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bonding/bond_main.c +1 -1
index 09aa45d71fab..7019e5d8fdc8 100644
@@ -6273,7 +6273,7 @@ static int __init bond_check_params(struct bond_params *params)
 	}
 
 	for (arp_ip_count = 0, i = 0;
-	     (arp_ip_count < BOND_MAX_ARP_TARGETS) && arp_ip_target[i]; i++) {
+	     (i < BOND_MAX_ARP_TARGETS) && arp_ip_target[i]; i++) {
 		__be32 ip;
 
 		/* not a complete check, but good enough to catch mistakes */
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Jiayuan Chen

arp_ip_target is a module parameter array with BOND_MAX_ARP_TARGETS entries. In the loop parsing it in bond_check_params(), arp_ip_count is the number of accepted targets, while i is the index into arp_ip_target. Invalid and duplicate entries are skipped without bumping arp_ip_count, so bounding the loop with arp_ip_count lets i run past the end of arp_ip_target, e.g. 16 targets with one duplicate:

   BUG: KASAN: global-out-of-bounds in bond_check_params.constprop.0+0x1148/0x1440
   Read of size 8 at addr ffffffff96e9ee00 by task swapper/0/1
   Call Trace:
    <TASK>
    dump_stack_lvl+0x91/0xf0
    print_report+0xd1/0x630
    kasan_report+0xf3/0x130
    __asan_report_load8_noabort+0x14/0x30
    bond_check_params.constprop.0+0x1148/0x1440
    bonding_init+0x13/0xe0
    do_one_initcall+0xe7/0x5b0
    kernel_init_freeable+0xa91/0x1120
    kernel_init+0x24/0x220
    ret_from_fork+0x5b3/0x820
    ret_from_fork_asm+0x1a/0x30
    </TASK>

   The buggy address belongs to the variable:
    arp_ip_target+0x80/0xa0
Quoted 6 lines

Bound the loop with i instead. arp_ip_count never exceeds i, so it stays within BOND_MAX_ARP_TARGETS too.

Fixes 5a5c5fd48e3b ("bonding: arp_ip_count and arp_targets can be wrong")

Thanks!

Reviewed-by on v1 1/1
#2 lore raw
In reply to Jiayuan Chen
Quoted 42 lines · Jiayuan Chen

arp_ip_target is a module parameter array with BOND_MAX_ARP_TARGETS entries. In the loop parsing it in bond_check_params(), arp_ip_count is the number of accepted targets, while i is the index into arp_ip_target. Invalid and duplicate entries are skipped without bumping arp_ip_count, so bounding the loop with arp_ip_count lets i run past the end of arp_ip_target, e.g. 16 targets with one duplicate:

   BUG: KASAN: global-out-of-bounds in bond_check_params.constprop.0+0x1148/0x1440
   Read of size 8 at addr ffffffff96e9ee00 by task swapper/0/1
   Call Trace:
    <TASK>
    dump_stack_lvl+0x91/0xf0
    print_report+0xd1/0x630
    kasan_report+0xf3/0x130
    __asan_report_load8_noabort+0x14/0x30
    bond_check_params.constprop.0+0x1148/0x1440
    bonding_init+0x13/0xe0
    do_one_initcall+0xe7/0x5b0
    kernel_init_freeable+0xa91/0x1120
    kernel_init+0x24/0x220
    ret_from_fork+0x5b3/0x820
    ret_from_fork_asm+0x1a/0x30
    </TASK>

   The buggy address belongs to the variable:
    arp_ip_target+0x80/0xa0

Bound the loop with i instead. arp_ip_count never exceeds i, so it stays within BOND_MAX_ARP_TARGETS too.

Fixes 5a5c5fd48e3b ("bonding: arp_ip_count and arp_targets can be wrong")
---
  drivers/net/bonding/bond_main.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bonding/bond_main.c +0 -0
index 09aa45d71fab..7019e5d8fdc8 100644

drivers/net/bonding/bond_main.c static int __init bond_check_params(struct bond_params *params) · line 6279

Quoted 8 lines
drivers/net/bonding/bond_main.c +1 -1
@@ -6273,7 +6273,7 @@ static int __init bond_check_params(struct bond_params *params)
  	}
 
  	for (arp_ip_count = 0, i = 0;
-	     (arp_ip_count < BOND_MAX_ARP_TARGETS) && arp_ip_target[i]; i++) {
+	     (i < BOND_MAX_ARP_TARGETS) && arp_ip_target[i]; i++) {
  		__be32 ip;
 
  		/* not a complete check, but good enough to catch mistakes */
maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Jiayuan Chen
Quoted 27 lines · Jiayuan Chen

arp_ip_target is a module parameter array with BOND_MAX_ARP_TARGETS entries. In the loop parsing it in bond_check_params(), arp_ip_count is the number of accepted targets, while i is the index into arp_ip_target. Invalid and duplicate entries are skipped without bumping arp_ip_count, so bounding the loop with arp_ip_count lets i run past the end of arp_ip_target, e.g. 16 targets with one duplicate:

 BUG: KASAN: global-out-of-bounds in bond_check_params.constprop.0+0x1148/0x1440
 Read of size 8 at addr ffffffff96e9ee00 by task swapper/0/1
 Call Trace:
  <TASK>
  dump_stack_lvl+0x91/0xf0
  print_report+0xd1/0x630
  kasan_report+0xf3/0x130
  __asan_report_load8_noabort+0x14/0x30
  bond_check_params.constprop.0+0x1148/0x1440
  bonding_init+0x13/0xe0
  do_one_initcall+0xe7/0x5b0
  kernel_init_freeable+0xa91/0x1120
  kernel_init+0x24/0x220
  ret_from_fork+0x5b3/0x820
  ret_from_fork_asm+0x1a/0x30
  </TASK>

 The buggy address belongs to the variable:
  arp_ip_target+0x80/0xa0
Quoted 6 lines

Bound the loop with i instead. arp_ip_count never exceeds i, so it stays within BOND_MAX_ARP_TARGETS too.

Fixes 5a5c5fd48e3b ("bonding: arp_ip_count and arp_targets can be wrong")
Quoted 20 lines

---
drivers/net/bonding/bond_main.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bonding/bond_main.c +1 -1
index 09aa45d71fab..7019e5d8fdc8 100644
@@ -6273,7 +6273,7 @@ static int __init bond_check_params(struct bond_params *params)
 	}
 
 	for (arp_ip_count = 0, i = 0;
-	     (arp_ip_count < BOND_MAX_ARP_TARGETS) && arp_ip_target[i]; i++) {
+	     (i < BOND_MAX_ARP_TARGETS) && arp_ip_target[i]; i++) {
 		__be32 ip;
 
 		/* not a complete check, but good enough to catch mistakes */
Signature · 1 line
2.43.0
#4 lore raw
In reply to Jiayuan Chen
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Fri, 23 Oct 2026 18:45:27 +0800 you wrote:

arp_ip_target is a module parameter array with BOND_MAX_ARP_TARGETS entries. In the loop parsing it in bond_check_params(), arp_ip_count is the number of accepted targets, while i is the index into arp_ip_target. Invalid and duplicate entries are skipped without bumping arp_ip_count, so bounding the loop with arp_ip_count lets i run past the end of arp_ip_target, e.g. 16 targets with one duplicate:

[...]

Here is the summary with links:
- [net] bonding: fix out-of-bounds read of arp_ip_target

    https://git.kernel.org/netdev/net/c/a81513bf5bdf

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html