Promote the bearer interfaces to stable
cover Promote the bearer interfaces to stable
As offered in the Role series, this marks org.bluez.Bearer.LE1 and org.bluez.Bearer.BREDR1 stable, now that test/functional/test_bearer.py covers them.
The bearer interfaces are the only way to connect a given bearer of a dual-mode device. Device1.Connect picks one, by default the last used, so an application that only uses LE, such as a GATT library, can end up with only BR/EDR connected, and Device1.Connected does not say which bearer is up. Today such an application has to ask its users to run bluetoothd with --experimental.
The series drops the [experimental] tags from the documentation, the experimental flags from src/bearer.c, and Experimental from the bearer tests. The Disconnected signal was only marked experimental in the documentation.
The bearer tests pass without Experimental in three consecutive runs, and the rest of test-functional still passes.
test_bearer_le_connect can fail in CI when test_bass_past_transport_acquire runs just before it on the same VMs. That is a kernel bug, unrelated to the bearer interfaces, fixed by:
https://lore.kernel.org/linux-bluetooth/[email protected]/
Kevin Dewald (3):
org.bluez.Bearer: Promote to stable
bearer: Promote to stable
test: functional: run bearer tests without experimental
doc/functional-bearer.rst | 7 +++---- doc/org.bluez.Bearer.BREDR.rst | 32 +++++++++++++++--------------- doc/org.bluez.Bearer.LE.rst | 36 +++++++++++++++++----------------- src/bearer.c | 23 ++++++++-------------- test/functional/test_bearer.py | 8 +++----- 5 files changed, 48 insertions(+), 58 deletions(-)
base-commit: 7bc9684dc9e45358661301da4a0ede433fdf0a30
Signature · 1 line
2.54.0 (Apple Git-157)
PATCH 1/3 org.bluez.Bearer: Promote to stable
Promote the methods, signal and properties of org.bluez.Bearer.LE1 and org.bluez.Bearer.BREDR1 to stable, so they can be used by upper layers without having to enable experimental. They are now covered by the bearer functional tests.
--- doc/org.bluez.Bearer.BREDR.rst | 32 +++++++++++++++--------------- doc/org.bluez.Bearer.LE.rst | 36 +++++++++++++++++----------------- 2 files changed, 34 insertions(+), 34 deletions(-)
doc/org.bluez.Bearer.BREDR.rst +16 -16
@@ -21,8 +21,8 @@ Interface Methods ------- -void Connect() [experimental] -````````````````````````````` +void Connect() +`````````````` Connects all BREDR profiles the remote device supports that can be connected to and have been flagged as auto-connectable. If only subset of profiles is already
@@ -38,8 +38,8 @@ Possible errors: :org.bluez.Error.InProgress: :org.bluez.Error.AlreadyConnected: -void Disconnect() [experimental] -```````````````````````````````` +void Disconnect() +````````````````` Disconnects all connected profiles and then terminates low-level ACL connection.
@@ -59,8 +59,8 @@ Possible errors: Signals ------- -void Disconnected(string reason, string message) [experimental] -``````````````````````````````````````````````````````````````` +void Disconnected(string reason, string message) +```````````````````````````````````````````````` This signal is launched when a device is disconnected, with the reason of the disconnection.
@@ -113,37 +113,37 @@ Possible reasons: Properties ---------- -object Adapter [readonly, experimental] -``````````````````````````````````````` +object Adapter [readonly] +````````````````````````` The object path of the adapter the set belongs to. -boolean Paired [readonly, experimental] -``````````````````````````````````````` +boolean Paired [readonly] +````````````````````````` Indicates if the remote device is paired to BREDR bearer. Paired means the pairing process where devices exchange the information to establish an encrypted connection has been completed. -boolean Bonded [readonly, experimental] -``````````````````````````````````````` +boolean Bonded [readonly] +````````````````````````` Indicates if the remote device is bonded to BREDR bearer. Bonded means the information exchanged on pairing process has been stored and will be persisted. -boolean Connected [readonly, experimental] -`````````````````````````````````````````` +boolean Connected [readonly] +```````````````````````````` Indicates if the remote device is currently connected to BREDR bearer. A PropertiesChanged signal indicate changes to this status. -boolean Connectable [readonly, experimental] -```````````````````````````````````````````` +boolean Connectable [readonly] +`````````````````````````````` Indicates if the remote device accepts connections on BREDR bearer. BREDR devices are always considered connectable.
doc/org.bluez.Bearer.LE.rst +18 -18
@@ -21,8 +21,8 @@ Interface Methods ------- -void Connect() [experimental] -````````````````````````````` +void Connect() +`````````````` Connects all LE profiles the remote device supports that can be connected to and have been flagged as auto-connectable. If only subset of profiles is already
@@ -38,8 +38,8 @@ Possible errors: :org.bluez.Error.InProgress: :org.bluez.Error.AlreadyConnected: -void Disconnect() [experimental] -```````````````````````````````` +void Disconnect() +````````````````` Disconnects all connected profiles and then terminates low-level ACL-LE connection.
@@ -60,8 +60,8 @@ Possible errors: Signals ------- -void Disconnected(string reason, string message) [experimental] -``````````````````````````````````````````````````````````````` +void Disconnected(string reason, string message) +```````````````````````````````````````````````` This signal is launched when a device is disconnected, with the reason of the disconnection.
@@ -114,36 +114,36 @@ Possible reasons: Properties ---------- -object Adapter [readonly, experimental] -``````````````````````````````````````` +object Adapter [readonly] +````````````````````````` The object path of the adapter the set belongs to. -boolean Paired [readonly, experimental] -``````````````````````````````````````` +boolean Paired [readonly] +````````````````````````` Indicates if the remote device is paired to LE bearer. Paired means the pairing process where devices exchange the information to establish an encrypted connection has been completed. -boolean Bonded [readonly, experimental] -``````````````````````````````````````` +boolean Bonded [readonly] +````````````````````````` Indicates if the remote device is bonded to LE bearer. Bonded means the information exchanged on pairing process has been stored and will be persisted. -boolean Connected [readonly, experimental] -`````````````````````````````````````````` +boolean Connected [readonly] +```````````````````````````` Indicates if the remote device is currently connected to LE bearer. A PropertiesChanged signal indicate changes to this status. -boolean Connectable [readonly, optional, experimental] -`````````````````````````````````````````````````````` +boolean Connectable [readonly, optional] +```````````````````````````````````````` Indicates if the remote device accepts connections on LE bearer, based on the most recent advertising report. It is false when the last advertising report
@@ -154,8 +154,8 @@ over LE bearer. A PropertiesChanged signal indicate changes to this status. -string Role [readonly, optional, experimental] -`````````````````````````````````````````````` +string Role [readonly, optional] +```````````````````````````````` Indicates the role of the remote device in the current connection on LE bearer. It is only present while the remote device is connected over LE bearer.
Signature · 1 line
2.54.0 (Apple Git-157)
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1192442/
---Test result---
Test Summary:
CheckPatch PASS 1.05 seconds GitLint PASS 0.76 seconds BuildEll PASS 13.04 seconds BluezMake PASS 170.01 seconds MakeCheck PASS 13.08 seconds MakeDistcheck PASS 95.71 seconds CheckValgrind PASS 146.98 seconds CheckSmatch PASS 169.11 seconds bluezmakeextell PASS 58.94 seconds TestFunctional PASS 799.13 seconds IncrementalBuild PASS 186.00 seconds ScanBuild PASS 581.08 seconds
https://github.com/bluez/bluez/pull/2705
---
Regards,
Linux Bluetooth
PATCH 2/3 bearer: Promote to stable
In reply to Kevin DewaldDrop the experimental flags of the Connect and Disconnect methods and of the properties of the bearer interfaces, so they are available without enabling experimental.
--- src/bearer.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-)
src/bearer.c +8 -15
@@ -199,9 +199,8 @@ static DBusMessage *bearer_disconnect(DBusConnection *conn, DBusMessage *msg, }static const GDBusMethodTable bearer_methods[] = { - {GDBUS_EXPERIMENTAL_ASYNC_METHOD ("Connect" ,NULL ,NULL , - bearer_connect) }, - {GDBUS_EXPERIMENTAL_ASYNC_METHOD ("Disconnect" ,NULL ,NULL , + {GDBUS_ASYNC_METHOD ("Connect" ,NULL ,NULL , bearer_connect) }, + {GDBUS_ASYNC_METHOD ("Disconnect" ,NULL ,NULL , bearer_disconnect) }, {} };
@@ -312,19 +311,13 @@ static const GDBusSignalTable bearer_signals[] = { };static const GDBusPropertyTable bearer_properties[] = { - {"Adapter" ,"o" , bearer_get_adapter,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Paired" ,"b" , bearer_get_paired,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Bonded" ,"b" , bearer_get_bonded,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Connected" ,"b" , bearer_get_connected,NULL ,NULL , -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, + {"Adapter" ,"o" , bearer_get_adapter }, + {"Paired" ,"b" , bearer_get_paired }, + {"Bonded" ,"b" , bearer_get_bonded }, + {"Connected" ,"b" , bearer_get_connected }, {"Connectable" ,"b" , bearer_get_connectable,NULL , - bearer_connectable_exists, -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, - {"Role" ,"s" , bearer_get_role,NULL , bearer_role_exists, -G_DBUS_PROPERTY_FLAG_EXPERIMENTAL }, + bearer_connectable_exists }, + {"Role" ,"s" , bearer_get_role,NULL , bearer_role_exists }, {} };
Signature · 1 line
2.54.0 (Apple Git-157)
PATCH 3/3 test: functional: run bearer tests without experimental
In reply to Kevin DewaldThe bearer interfaces are no longer experimental, so run bluetoothd without Experimental in the bearer tests.
--- doc/functional-bearer.rst | 7 +++---- test/functional/test_bearer.py | 8 +++----- 2 files changed, 6 insertions(+), 9 deletions(-)
doc/functional-bearer.rst +3 -4
@@ -13,10 +13,9 @@ used here, and **test-functional(1)** for how to run the suite. SETUP ===== -Two hosts, both running **bluetoothd(8)** with ``Experimental = true``, -as the bearer interfaces are experimental, and with the MIDI plugin -disabled (``-P midi``), as the MIDI profile would ask to pair as soon as -it finds the MIDI service the other host exports: +Two hosts, both running **bluetoothd(8)** with the MIDI plugin disabled +(``-P midi``), as the MIDI profile would ask to pair as soon as it finds +the MIDI service the other host exports: .. code-block::
test/functional/test_bearer.py +3 -5
@@ -34,9 +34,7 @@ DEVICE_INTERFACE = "org.bluez.Device1" LE_INTERFACE = "org.bluez.Bearer.LE1" BREDR_INTERFACE = "org.bluez.Bearer.BREDR1" -# The bearer interfaces are experimental -CONF = "[General]\nExperimental = true\n" -LE_CONF = CONF + "ControllerMode = le\n" +LE_CONF = "[General]\nControllerMode = le\n" # bluetoothd only creates device objects for advertisers that are # discoverable, which a broadcaster is not
@@ -170,8 +168,8 @@ le_config = host_config( ) bredr_config = host_config( - [Bluetoothd(conf=CONF, args=ARGS), Agent(), Bearers()], - [Bluetoothd(conf=CONF, args=ARGS), Agent(), Bearers()], + [Bluetoothd(args=ARGS), Agent(), Bearers()], + [Bluetoothd(args=ARGS), Agent(), Bearers()], )
Signature · 1 line
2.54.0 (Apple Git-157)
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 4 lines · On Fri, 23 Oct 2026 15:37:05 -0700 you wrote:
As offered in the Role series, this marks org.bluez.Bearer.LE1 and org.bluez.Bearer.BREDR1 stable, now that
test/functional/test_bearer.pycovers them.
Quoted 8 lines
The bearer interfaces are the only way to connect a given bearer of a dual-mode device. Device1.Connect picks one, by default the last used, so an application that only uses LE, such as a GATT library, can end up with only BR/EDR connected, and Device1.Connected does not say which bearer is up. Today such an application has to ask its users to run bluetoothd with --experimental.
[...]
Here is the summary with links:
- [BlueZ,1/3] org.bluez.Bearer: Promote to stable
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=892d1885af48 - [BlueZ,2/3] bearer: Promote to stable https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b25019027d3b - [BlueZ,3/3] test: functional: run bearer tests without experimental https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b0bf49270d44
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html