Skip to contentSkip to conversation

iio: dac: mcp4725: Update the cached DAC value only on success

PATCH In review Baek Kyu, Kim 3 participants 3 messages Oct 25 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: dac: mcp4725: Update the cached DAC value only on success

mcp4725_write_raw() updates dac_value even if mcp4725_set_value() rejects the requested value or reports an I2C transfer error. After writing 1000, a rejected write of 4096 returns -EINVAL without an I2C transfer, but out_voltage0_raw reports 4096. A later powerdown exit sends 00 00 instead of the 03 e8 frame for the last successful value. The EEPROM store path uses the same cache.

Return the setter error before updating dac_value. This keeps the last successful software value for readback, powerdown exit and EEPROM writes.

---
Tested on ARM64 QEMU/KVM with emulated I2C peers through the MCP4725 and MCP4726 sysfs paths. After setting 1000, a rejected write of 4096 returned -EINVAL without a transfer. The baseline readback changed to 4096 and powerdown exit sent 00 00; the patch kept 1000 and sent 03 e8. All 202 assertions passed with the patch; 40 failed on the baseline. No physical DAC or persistent EEPROM was tested.

 drivers/iio/dac/mcp4725.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/dac/mcp4725.c +2 -0
index 3fa7acc69aeb..94d51af83042 100644
@@ -356,6 +356,8 @@ static int mcp4725_write_raw(struct iio_dev *indio_dev,
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW:
 		ret = mcp4725_set_value(indio_dev, val);
+		if (ret)
+			return ret;
 		data->dac_value = val;
 		break;
 	default:
Signature · 1 line
2.55.0
#1 lore raw
Quoted 9 lines · Kim

mcp4725_write_raw() updates dac_value even if mcp4725_set_value() rejects the requested value or reports an I2C transfer error. After writing 1000, a rejected write of 4096 returns -EINVAL without an I2C transfer, but out_voltage0_raw reports 4096. A later powerdown exit sends 00 00 instead of the 03 e8 frame for the last successful value. The EEPROM store path uses the same cache.

Return the setter error before updating dac_value. This keeps the last successful software value for readback, powerdown exit and EEPROM writes.

Does it need a Fixes tag?

Quoted 1 line
Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
Quoted 8 lines · On Sun, 25 Oct 2026 23:08:50 +0200 Andy Shevchenko…
Quoted 7 lines · Kim

mcp4725_write_raw() updates dac_value even if mcp4725_set_value() rejects the requested value or reports an I2C transfer error. After writing 1000, a rejected write of 4096 returns -EINVAL without an I2C transfer, but out_voltage0_raw reports 4096. A later powerdown exit sends 00 00 instead of the 03 e8 frame for the last successful value. The EEPROM store path uses the same cache.

Quoted 4 lines
Quoted 2 lines

Return the setter error before updating dac_value. This keeps the last successful software value for readback, powerdown exit and EEPROM writes.

Does it need a Fixes tag?

Yes. Given I wanted to reduce outstanding patches, I added it an applied to the fixes-togreg branch of iio.git

This goes all the way back to 2012 introduction of the driver.

Fixes cf35ad61aca2 ("iio: add mcp4725 I2C DAC driver")
Quoted 3 lines
Quoted 2 lines