Skip to contentSkip to conversation

sunxi: dram: only probe DRAM inside the addressable range

PATCH In review Jernej Skrabec 2 participants 2 messages Oct 26 – Nov 1

Subsystems (3)
lore
Share & tools
lore

Jernej Skrabec

author maintainer
#0 lore raw

PATCH 1/1 sunxi: dram: only probe DRAM inside the addressable range

The non-power-of-2 size check probes the memory cell at 3/4 of the detected size. On SoCs whose DRAM window is smaller than the detected size, like H6 with 4 GiB chips and a 3 GiB window, that address lies outside the window and the access hangs the SPL. Such boards cannot be odd-sized anyway, since the usable size is capped to the window later, so only run the check when the probed address is addressable.

Fixes c47b63673736 ("sunxi: dram: detect non-power-of-2 sized DRAM chips")
---
 arch/arm/mach-sunxi/dram_dw_helpers.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-sunxi/dram_dw_helpers.c +2 -1
index d2af2d57fded..ae13dd154536 100644
@@ -155,7 +155,8 @@ unsigned long mctl_calc_size(const struct dram_config *config)
 	 * or 3GB. They are detected as the larger power-of-2 (2GB and 4GB),
 	 * so test the last quarter for being able to store values.
 	 */
-	if (!mctl_check_memory(CFG_SYS_SDRAM_BASE + size / 4 * 3)) {
+	if (size / 4 * 3 < CONFIG_SUNXI_DRAM_MAX_SIZE &&
+	    !mctl_check_memory(CFG_SYS_SDRAM_BASE + size / 4 * 3)) {
 		if (mctl_check_memory(CFG_SYS_SDRAM_BASE + size / 4 * 3 - 64)) {
 			size = (size / 4) * 3;
 			debug("capping memory at %ld MB\n", size >> 20);
Signature · 1 line
2.56.0
Reviewed-by on v1 1/1
#1 lore raw

On Mon, 26 Oct 2026 18:32:35 +0100
Jernej Skrabec <[email protected]> wrote:

Hi Jernej,

Quoted 6 lines

The non-power-of-2 size check probes the memory cell at 3/4 of the detected size. On SoCs whose DRAM window is smaller than the detected size, like H6 with 4 GiB chips and a 3 GiB window, that address lies outside the window and the access hangs the SPL. Such boards cannot be odd-sized anyway, since the usable size is capped to the window later, so only run the check when the probed address is addressable.

Many thanks for the heads up, and the fix!
I can confirm that it's indeed a problem, and that the change fixes it:
tested on a 3GB Eachlink H6 Mini box.
I added one line to the comment above, to give some clue about the reason for that added line (beyond just the commit message).

Quoted 1 line
Fixes c47b63673736 ("sunxi: dram: detect non-power-of-2 sized DRAM chips")

Queued for 2027.01.

Cheers,
Andre

Quoted 19 lines
---
 arch/arm/mach-sunxi/dram_dw_helpers.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-sunxi/dram_dw_helpers.c +2 -1
index d2af2d57fded..ae13dd154536 100644
@@ -155,7 +155,8 @@ unsigned long mctl_calc_size(const struct dram_config *config)
 	 * or 3GB. They are detected as the larger power-of-2 (2GB and 4GB),
 	 * so test the last quarter for being able to store values.
 	 */
-	if (!mctl_check_memory(CFG_SYS_SDRAM_BASE + size / 4 * 3)) {
+	if (size / 4 * 3 < CONFIG_SUNXI_DRAM_MAX_SIZE &&
+	    !mctl_check_memory(CFG_SYS_SDRAM_BASE + size / 4 * 3)) {
 		if (mctl_check_memory(CFG_SYS_SDRAM_BASE + size / 4 * 3 - 64)) {
 			size = (size / 4) * 3;
 			debug("capping memory at %ld MB\n", size >> 20);