ALSA: hda: Reject codec reset on ASoC (ext_ops) buses
Subsystems (2)
PATCH 1/1 ALSA: hda: Reject codec reset on ASoC (ext_ops) buses
Writing to the reconfig or clear sysfs nodes of a codec handled by ASoC (SOF via hdac_hda, AVS via codecs/hda) hangs the writer.
snd_hda_codec_reset() sets card->shutdown and calls device_release_driver(). With ext_ops the driver unbind unregisters the ASoC component, which unbinds and frees the whole ASoC card:
- snd_card_disconnect() returns early as card->shutdown is already set, so the card's child devices are not removed and snd_card_free() waits for the card release forever.
- Even without that, freeing the card removes the codec's hwdep device, which owns the sysfs node the reset was issued from, deadlocking in kernfs while waiting for the active write to finish.
The legacy HDA driver keeps the card across a driver rebind, ASoC does not, so the reset cannot be supported there. Return -EOPNOTSUPP and skip the misleading "codec is being used" messages in the callers.
--- sound/hda/common/codec.c | 6 ++++++ sound/hda/common/sysfs.c | 4 ++++ 2 files changed, 10 insertions(+)
sound/hda/common/codec.c +6 -0
@@ -1807,6 +1807,12 @@ int snd_hda_codec_reset(struct hda_codec *codec) {struct hda_bus *bus = codec->bus; +/* ASoC: driver unbind frees the card, incl. the hwdep issuing the reset */ +if (bus->core.ext_ops) { +codec_err (codec,"Codec reset is not supported with ASoC\n" ); +return -EOPNOTSUPP ; + } +if (snd_hda_lock_devices (bus) <0 )return -EBUSY ;
sound/hda/common/sysfs.c +4 -0
@@ -117,6 +117,8 @@ static int clear_codec(struct hda_codec *codec)int err; err =snd_hda_codec_reset (codec); +if (err == -EOPNOTSUPP ) +return err;if (err <0 ) {codec_err (codec,"The codec is being used, can't free.\n" );return err;
@@ -132,6 +134,8 @@ static int reconfig_codec(struct hda_codec *codec)CLASS (snd_hda_power, pm)(codec);codec_info (codec,"hda-codec: reconfiguring\n" ); err =snd_hda_codec_reset (codec); +if (err == -EOPNOTSUPP ) +return err;if (err <0 ) {codec_err (codec,"The codec is being used, can't reconfigure.\n" );
Signature · 1 line
2.56.0
Quoted 14 lines · Peter Ujfalusi
Writing to the reconfig or clear sysfs nodes of a codec handled by ASoC (SOF via
hdac_hda, AVS via codecs/hda) hangs the writer.
snd_hda_codec_reset()setscard->shutdownand callsdevice_release_driver(). Withext_opsthe driver unbind unregisters the ASoC component, which unbinds and frees the whole ASoC card:
-snd_card_disconnect()returns early ascard->shutdownis already set, so the card's child devices are not removed andsnd_card_free()waits for the card release forever.
- Even without that, freeing the card removes the codec's hwdep device, which owns the sysfs node the reset was issued from, deadlocking in kernfs while waiting for the active write to finish.
Quoted 8 lines
The legacy HDA driver keeps the card across a driver rebind, ASoC does not, so the reset cannot be supported there. Return
-EOPNOTSUPPand skip the misleading "codec is being used" messages in the callers.Fixes 6bae5ea94989 ("ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers")Signed-off-by Peter Ujfalusi <[email protected]>
Applied now. Thanks.
Takashi
Quoted 13 lines · Peter Ujfalusi
Writing to the reconfig or clear sysfs nodes of a codec handled by ASoC (SOF via
hdac_hda, AVS via codecs/hda) hangs the writer.
snd_hda_codec_reset()setscard->shutdownand callsdevice_release_driver(). Withext_opsthe driver unbind unregisters the ASoC component, which unbinds and frees the whole ASoC card:
-snd_card_disconnect()returns early ascard->shutdownis already set, so the card's child devices are not removed andsnd_card_free()waits for the card release forever.
- Even without that, freeing the card removes the codec's hwdep device, which owns the sysfs node the reset was issued from, deadlocking in kernfs while waiting for the active write to finish.
Quoted 8 lines
The legacy HDA driver keeps the card across a driver rebind, ASoC does not, so the reset cannot be supported there. Return
-EOPNOTSUPPand skip the misleading "codec is being used" messages in the callers.Fixes 6bae5ea94989 ("ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers")Signed-off-by Peter Ujfalusi <[email protected]>
We've had a short chat about this case and I'm grateful for the quick resolution. Thanks you Peter!