driver core: Limit the messages on a refused uevent
Subsystems (2)
Greg Kroah-Hartman
maintainerPATCH 1/1 driver core: Limit the messages on a refused uevent
From: Josef Bacik <[email protected]>
A write to a "uevent" file which is no valid action makes kobject_synth_uevent() print a warning and uevent_store() an error every time. This is generally considered a bad thing so rate limit these messages.
Fixes b0e37c0d8a6a ("net-sysfs: make sure objects belong to container's owner")
Cc stable <[email protected]>
Signed-off-by Josef Bacik <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/base/core.c | 4 +++- lib/kobject_uevent.c | 6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-)
drivers/base/core.c +3 -1
@@ -2881,7 +2881,9 @@ static ssize_t uevent_store(struct device *dev, const struct device_attribute *a rc =kobject_synth_uevent (&dev->kobj, buf, count);if (rc) { -dev_err (dev,"uevent: failed to send synthetic uevent: %d\n" , rc); +dev_err_ratelimited (dev, +"uevent: failed to send synthetic uevent: %d\n" , + rc);return rc; }
lib/kobject_uevent.c +3 -3
@@ -223,9 +223,9 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count) out:if (r) { devpath =kobject_get_path (kobj,GFP_KERNEL ); -pr_warn ("synth uevent: %s: %s\n" , - devpath ?:"unknown device" , - msg ?:"failed to send uevent" ); +pr_warn_ratelimited ("synth uevent: %s: %s\n" , + devpath ?:"unknown device" , + msg ?:"failed to send uevent" );kfree (devpath); }return r;
Signature · 1 line
2.56.0