FAILED: patch "[PATCH] io_uring/poll: avoid retry wakeup loss when dropping" failed to apply to 5.15-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.15-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y
git checkout FETCH_HEAD
git cherry-pick -x 937d38dcacd675dc0572d6c9b6743960df3128ed
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026102833-buffing-shone-0fb5@gregkh' --subject-prefix 'PATCH 5.15.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 937d38dcacd675dc0572d6c9b6743960df3128ed Mon Sep 17 00:00:00 2001
From: Juanlu Herrero <[email protected]>
Date: Tue, 13 Oct 2026 15:37:20 -0700
Subject: [PATCH] io_uring/poll: avoid retry wakeup loss when dropping
ownership
If a wakeup sets IO_POLL_RETRY_FLAG between the owning task consuming the existing instance of IO_POLL_RETRY_FLAG and the loop check of io_poll_check_events(), then we stall on processing the request until an unrelated wakeup comes along.
Using atomic_cmpxchg instead of atomic_sub_return to guarantee both the count v and poll_refs are 0 and no wake-ups are missed.
io_uring/poll.c +2 -1
@@ -330,7 +330,8 @@ static int io_poll_check_events(struct io_kiocb *req, io_tw_token_t tw)* Release all references, retry if someone tried to restart * task_work while we were executing it. */ - }while (atomic_sub_return (v, &req->poll_refs) &IO_POLL_REF_MASK ); + v &=IO_POLL_REF_MASK ; + }while (atomic_cmpxchg (&req->poll_refs, v,0 ) != v);io_napi_add (req);return IOU_POLL_NO_ACTION ;
Sasha Levin
maintainerPATCH 1/1 io_uring/poll: avoid retry wakeup loss when dropping ownership
From: Juanlu Herrero <[email protected]>
[ Upstream commit 937d38dcacd675dc0572d6c9b6743960df3128ed ]
If a wakeup sets IO_POLL_RETRY_FLAG between the owning task consuming the existing instance of IO_POLL_RETRY_FLAG and the loop check of io_poll_check_events(), then we stall on processing the request until an unrelated wakeup comes along.
Using atomic_cmpxchg instead of atomic_sub_return to guarantee both the count v and poll_refs are 0 and no wake-ups are missed.
--- io_uring/io_uring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
io_uring/io_uring.c +2 -2
@@ -5690,8 +5690,8 @@ static int io_poll_check_events(struct io_kiocb *req)* Release all references, retry if someone tried to restart * task_work while we were executing it. */ - }while (atomic_sub_return (v &IO_POLL_REF_MASK , &req->poll_refs) & -IO_POLL_REF_MASK ); + v &=IO_POLL_REF_MASK ; + }while (atomic_cmpxchg (&req->poll_refs, v,0 ) != v);return 1 ; }
Signature · 1 line
2.53.0