ASoC: google: Fix bugs in Chameleon v3 I2S driver
cover ASoC: google: Fix bugs in Chameleon v3 I2S driver
From: bui duc phuc <[email protected]>
Hi all,
This series fixes a frame size calculation bug, preserves IRQ error codes, and removes a redundant error message in the Chameleon v3 I2S driver.
Compile-tested only.
Best regards,
Phuc
bui duc phuc (3):
ASoC: google: Fix frame size calculation in pointer callback
ASoC: google: Propagate platform_get_irq() errors
ASoC: google: Remove redundant error message
sound/soc/google/chv3-i2s.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
Signature · 1 line
2.43.0
PATCH 1/3 ASoC: google: Fix frame size calculation in pointer callback
From: bui duc phuc <[email protected]>
runtime->frame_bits is the number of bits in a frame, so converting it to bytes requires dividing by 8, not multiplying.
--- sound/soc/google/chv3-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/google/chv3-i2s.c +1 -1
@@ -234,7 +234,7 @@ static snd_pcm_uframes_t chv3_dma_pointer(struct snd_soc_component *component,u32 frame_bytes, buffer_bytes;u32 idx_bytes; - frame_bytes = substream->runtime->frame_bits *8 ; + frame_bytes = substream->runtime->frame_bits /8 ; buffer_bytes =snd_pcm_lib_buffer_bytes (substream);if (substream->pstr->stream ==SNDRV_PCM_STREAM_CAPTURE ) {
Signature · 1 line
2.43.0
PATCH 2/3 ASoC: google: Propagate platform_get_irq() errors
In reply to [email protected]From: bui duc phuc <[email protected]>
platform_get_irq() may return errors other than -ENXIO, including -EPROBE_DEFER. Return the original error code instead of replacing it with -ENXIO.
--- sound/soc/google/chv3-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/google/chv3-i2s.c +1 -1
@@ -303,7 +303,7 @@ static int chv3_i2s_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) -return -ENXIO ; +return irq; res =devm_request_irq (i2s->dev, irq, chv3_i2s_isr,0 ,"chv3-i2s" , i2s);if (res)return res;
Signature · 1 line
2.43.0
PATCH 3/3 ASoC: google: Remove redundant error message
In reply to [email protected]From: bui duc phuc <[email protected]>
Remove the redundant error message when devm_snd_soc_register_component() fails. The errors handled here are already reported deeper in the call chain, so the additional dev_err() call is unnecessary.
--- sound/soc/google/chv3-i2s.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
sound/soc/google/chv3-i2s.c +1 -3
@@ -310,10 +310,8 @@ static int chv3_i2s_probe(struct platform_device *pdev) res =devm_snd_soc_register_component (&pdev->dev, &chv3_i2s_comp, &chv3_i2s_dai,1 ); -if (res) { -dev_err (&pdev->dev,"couldn't register component: %d\n" , res); +if (res)return res; - }return 0 ; }
Signature · 1 line
2.43.0
Mark Brown
maintainerQuoted 10 lines · On Thu, 29 Oct 2026 15:01:40 +0700, [email protected] wrote:
ASoC: google: Fix bugs in Chameleon v3 I2S driver
From: bui duc phuc <[email protected]>
Hi all,
This series fixes a frame size calculation bug, preserves IRQ error codes, and removes a redundant error message in the Chameleon v3 I2S driver.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.5
Thanks!
[1/3] ASoC: google: Fix frame size calculation in pointer callback
https://git.kernel.org/broonie/sound/c/30a43746cdd3 [2/3] ASoC: google: Propagate platform_get_irq() errors https://git.kernel.org/broonie/sound/c/9e374e2aebd2 [3/3] ASoC: google: Remove redundant error message https://git.kernel.org/broonie/sound/c/3e67930a43b8
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark