Skip to contentSkip to conversation

sunxi: a133: adjust TF-A load address

PATCH In review Andre Przywara 3 participants 3 messages Oct 29 – Oct 30

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi: a133: adjust TF-A load address

When development of the Allwinner A133 TF-A port started, BL31 was put in SRAM, like on the similar H6 SoC. Consequently we used the same SRAM address as the H6 in the Kconfig stanza of the A133 U-Boot port.

Later we realised that the SRAM space will become too tight, in fact it was already spilling over into SRAM C, which we cannot use any more at runtime, once the display engine is used. So the mainline TF-A port eventually put BL31 in DRAM, which of course requires a different load address.

Adjust the BL31 load address to use the same DRAM location as the (almost SRAM-less) H616, by just adjusting the match pattern, to not let the A133 fall through to the SUN50I_GEN_H6 symbol.
This allows U-Boot to use the now merged mainline TF-A port for the A133.

This is unfortunately a breaking change, but there is not much we can do about it, and since U-Boot packages TF-A in our booting scheme, we have that under control.

---
 arch/arm/mach-sunxi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-sunxi/Kconfig +1 -1
index b0c5d3cd903..b7ee14c6678 100644
@@ -267,7 +267,7 @@ config SUNXI_RVBAR_ALTERNATIVE
 config SUNXI_BL31_BASE
 	hex
 	default 0x00044000 if MACH_SUN50I || MACH_SUN50I_H5
-	default 0x40000000 if MACH_SUN50I_H616
+	default 0x40000000 if MACH_SUN50I_H616 || MACH_SUN50I_A133
 	default 0x00104000 if SUN50I_GEN_H6
 	default 0x00054000 if MACH_SUN55I_A523
 	default 0x0
Signature · 1 line
2.46.4
Reviewed-by on v1 1/1
#1 lore raw

Hi Andre,

Quoted 10 lines · Andre Przywara

When development of the Allwinner A133 TF-A port started, BL31 was put in SRAM, like on the similar H6 SoC. Consequently we used the same SRAM address as the H6 in the Kconfig stanza of the A133 U-Boot port.

Later we realised that the SRAM space will become too tight, in fact it was already spilling over into SRAM C, which we cannot use any more at runtime, once the display engine is used. So the mainline TF-A port eventually put BL31 in DRAM, which of course requires a different load address.

Quoted 8 lines

Adjust the BL31 load address to use the same DRAM location as the (almost SRAM-less) H616, by just adjusting the match pattern, to not let the A133 fall through to the SUN50I_GEN_H6 symbol.
This allows U-Boot to use the now merged mainline TF-A port for the A133.

This is unfortunately a breaking change, but there is not much we can do about it, and since U-Boot packages TF-A in our booting scheme, we have that under control.

Thanks for submitting this! I agree this is the right thing to do.

Also note that I've been using the 0x104000 SRAM address as base for the crust SCP firmware, which will be submitted once crust support is there.

Another aspect is that I'm not sure we actually lock down the address in the TZC, so it's likely that Linux could still overwrite the TF-A code. But that's a TF-A problem, not a U-Boot problem.

All the best,

Paul

Quoted 21 lines
---
 arch/arm/mach-sunxi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-sunxi/Kconfig +1 -1
index b0c5d3cd903..b7ee14c6678 100644
@@ -267,7 +267,7 @@ config SUNXI_RVBAR_ALTERNATIVE
 config SUNXI_BL31_BASE
 	hex
 	default 0x00044000 if MACH_SUN50I || MACH_SUN50I_H5
-	default 0x40000000 if MACH_SUN50I_H616
+	default 0x40000000 if MACH_SUN50I_H616 || MACH_SUN50I_A133
 	default 0x00104000 if SUN50I_GEN_H6
 	default 0x00054000 if MACH_SUN55I_A523
 	default 0x0
Signature · 1 line
2.46.4
Signature · 6 lines
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.
Reviewed-by on v1 1/1
#2 lore raw
In reply to Andre Przywara
Quoted 29 lines · Andre Przywara

When development of the Allwinner A133 TF-A port started, BL31 was put in SRAM, like on the similar H6 SoC. Consequently we used the same SRAM address as the H6 in the Kconfig stanza of the A133 U-Boot port.

Later we realised that the SRAM space will become too tight, in fact it was already spilling over into SRAM C, which we cannot use any more at runtime, once the display engine is used. So the mainline TF-A port eventually put BL31 in DRAM, which of course requires a different load address.

Adjust the BL31 load address to use the same DRAM location as the (almost SRAM-less) H616, by just adjusting the match pattern, to not let the A133 fall through to the SUN50I_GEN_H6 symbol.
This allows U-Boot to use the now merged mainline TF-A port for the A133.

This is unfortunately a breaking change, but there is not much we can do about it, and since U-Boot packages TF-A in our booting scheme, we have that under control.

---
 arch/arm/mach-sunxi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-sunxi/Kconfig +0 -0
index b0c5d3cd903..b7ee14c6678 100644

arch/arm/mach-sunxi/Kconfig config SUNXI_RVBAR_ALTERNATIVE · line 270

Quoted 5 lines
arch/arm/mach-sunxi/Kconfig +1 -1
@@ -267,7 +267,7 @@ config SUNXI_RVBAR_ALTERNATIVE
 config SUNXI_BL31_BASE
 	hex
 	default 0x00044000 if MACH_SUN50I || MACH_SUN50I_H5
-	default 0x40000000 if MACH_SUN50I_H616
+	default 0x40000000 if MACH_SUN50I_H616 || MACH_SUN50I_A133

Thanks for the changes.

Thanks,
Parthiban

Quoted 3 lines
arch/arm/mach-sunxi/Kconfig +0 -0
 	default 0x00104000 if SUN50I_GEN_H6
 	default 0x00054000 if MACH_SUN55I_A523
 	default 0x0