Skip to contentSkip to conversation

ALSA: hda/realtek: Fix mute and mic-mute LEDs for HP OmniBook 7

PATCH In review Shivam Madlani 2 participants 2 messages Nov 1 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda/realtek: Fix mute and mic-mute LEDs for HP OmniBook 7

The HP OmniBook 7 Laptop 14-fr0xxx (PCI SSID 103c:8e3b) uses an ALC245 codec with CS35L41 amplifiers. The existing quirk ALC287_FIXUP_CS35L41_I2C_2 does not configure the speaker mute or mic-mute LEDs, leaving them non-functional.

Switch to ALC245_FIXUP_CS35L41_I2C_2_MUTE_MICMUTE_LED, which controls the speaker mute LED via COEF index 0x0b, the mic-mute LED via GPIO 0x04, and chains to the CS35L41 amplifier setup. Also update the model name from the internal board codename ("HP Agusta") to the retail product name.

---
 sound/hda/codecs/realtek/alc269.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/hda/codecs/realtek/alc269.c +1 -1
index 23329d5887a5..b040cea9c268 100644
@@ -8067,7 +8067,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8e36, "HP 14 Enstrom OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8e37, "HP 16 Piston OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8e3a, "HP Agusta", ALC287_FIXUP_CS35L41_I2C_2),
-	SND_PCI_QUIRK(0x103c, 0x8e3b, "HP Agusta", ALC287_FIXUP_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x103c, 0x8e3b, "HP OmniBook 7", ALC245_FIXUP_CS35L41_I2C_2_MUTE_MICMUTE_LED),
 	SND_PCI_QUIRK(0x103c, 0x8e43, "HP Laptop 15-fd2xxx", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO),
 	HDA_CODEC_QUIRK(0x103c, 0x84ee, "HP Pavilion AiO 24", ALC225_FIXUP_HP_AIO_SPK),
 	SND_PCI_QUIRK(0x103c, 0x8e60, "HP OmniBook 7 Laptop 16-bh0xxx", ALC245_FIXUP_CS35L41_I2C_2_MUTE_LED),
Signature · 1 line
2.56.0
#1 lore raw
Quoted 6 lines · Shivam Madlani

The HP OmniBook 7 Laptop 14-fr0xxx (PCI SSID 103c:8e3b) uses an ALC245 codec with CS35L41 amplifiers. The existing quirk ALC287_FIXUP_CS35L41_I2C_2 does not configure the speaker mute or mic-mute LEDs, leaving them non-functional.

Quoted 7 lines

Switch to ALC245_FIXUP_CS35L41_I2C_2_MUTE_MICMUTE_LED, which controls the speaker mute LED via COEF index 0x0b, the mic-mute LED via GPIO 0x04, and chains to the CS35L41 amplifier setup. Also update the model name from the internal board codename ("HP Agusta") to the retail product name.

Applied now (with Fixes tag). Thanks.

Takashi