Skip to contentSkip to conversation

mm-damon-core-move-static-variable-last_nr_regions-to-damon_ctx.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Nov 3 Stable branch

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/damon/core: move static variable last_nr_regions to damon_ctx
has been removed from the -mm tree. Its filename was
mm-damon-core-move-static-variable-last_nr_regions-to-damon_ctx.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: SJ Park <[email protected]>
Subject: mm/damon/core: move static variable last_nr_regions to damon_ctx
Date: Sun, 25 Oct 2026 09:48:05 -0700

kdamond_split_regions() uses a static variable last_nr_regions, to infer if the region boundaries are too stable. If it looks too stable, it does a more aggressive region split because it might be a fake stability coming from non-aggressive split. Because the variable is static, the inference can be racy and wrong when multiple kdamonds are running in parallel.

The user impact is not critical. No crash, no leak. DAMON's best-effort monitoring accuracy can be degraded when multiple kdamonds are used in parallel and the workload has certain access patterns. Still it is a bug that is better to fix.

Move the variable into the damon_ctx struct to fix the problem.

Fixes 75c1c2b53c78 ("mm/damon/dbgfs: support multiple contexts")
Cc Fernand Sieber <[email protected]>
Cc SeongJae Park <[email protected]>
Cc <[email protected]> # 5.15.x

---

 include/linux/damon.h |    5 +++++
 mm/damon/core.c       |    5 ++---
 2 files changed, 7 insertions(+), 3 deletions(-)
include/linux/damon.h renamed from include/linux/damon.h~mm-damon-core-move-static-variable-last_nr_regions-to-damon_ctx +5 -0
@@ -958,6 +958,11 @@ struct damon_ctx {
 
 	/* @rnd_state:	Per-ctx PRNG state for damon_rand(). */
 	struct rnd_state rnd_state;
+	/*
+	 * number of regions after last merge.  Read kdamond_split_regions()
+	 * for more details.
+	 */
+	unsigned long last_nr_regions;
 };
 
 /* Get a random number in [@l, @r) using @ctx's lockless PRNG. */
mm/damon/core.c renamed from mm/damon/core.c~mm-damon-core-move-static-variable-last_nr_regions-to-damon_ctx +2 -3
@@ -3795,7 +3795,6 @@ static noinline_for_stack void kdamond_s
 	struct damon_target *t;
 	unsigned long nr_regions = 0;
 	unsigned long max_nr_regions = ctx->attrs.max_nr_regions;
-	static unsigned long last_nr_regions;
 	int nr_subregions = 2;
 
 	damon_for_each_target(t, ctx)
@@ -3811,7 +3810,7 @@ static noinline_for_stack void kdamond_s
 	}
 
 	/* Maybe the middle of the region has different access frequency */
-	if (last_nr_regions == nr_regions &&
+	if (ctx->last_nr_regions == nr_regions &&
 			nr_regions < max_nr_regions / 3)
 		nr_subregions = 3;
 
@@ -3820,7 +3819,7 @@ static noinline_for_stack void kdamond_s
 				       ctx->min_region_sz);
 
 done:
-	last_nr_regions = nr_regions;
+	ctx->last_nr_regions = nr_regions;
 }
 
 /*

_

Patches currently in -mm which might be from [email protected] are

selftests-damon-sysfs_memcg_path_leak-define-ksft_skip.patch mm-damon-core-copy-only-installed-probe-in-damon_split_region_at.patch