Skip to contentSkip to conversation

mm-damon-core-move-static-variable-rotation-to-damon_ctx.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Nov 3 Stable branch

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/damon/core: move static variable rotation to damon_ctx
has been removed from the -mm tree. Its filename was
mm-damon-core-move-static-variable-rotation-to-damon_ctx.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: SJ Park <[email protected]>
Subject: mm/damon/core: move static variable rotation to damon_ctx
Date: Sun, 25 Oct 2026 09:48:06 -0700

damon_split_some_reigons() uses a static variable, rotation, to remember how many times it was called. It is again used to determine fair selection of regions to split. Since it is a static variable, it can be indeterministic and therefore less fair.

The user impact is not critical. No crash, no leak. DAMON's best-effort and indeterministic monitoring accuracy could be slightly more indeterministic when multiple kdamonds are used in parallel.

Fix the problem by moving the static variable into the damon_ctx struct.

Fixes 1a582e6e0174 ("mm/damon/core: split a fraction of regions when nr_regions exceeds max/2")
Cc Jiayuan Chen <[email protected]>
Cc <[email protected]> # 7.3.x

---

 include/linux/damon.h |    5 +++++
 mm/damon/core.c       |    5 +++--
 2 files changed, 8 insertions(+), 2 deletions(-)
include/linux/damon.h renamed from include/linux/damon.h~mm-damon-core-move-static-variable-rotation-to-damon_ctx +5 -0
@@ -963,6 +963,11 @@ struct damon_ctx {
 	 * for more details.
 	 */
 	unsigned long last_nr_regions;
+	/*
+	 * number of damon_split_some_regions() invocations for this context.
+	 * Read damon_split_some_regions() for more details.
+	 */
+	unsigned long region_split_rotation;
 };
 
 /* Get a random number in [@l, @r) using @ctx's lockless PRNG. */
mm/damon/core.c renamed from mm/damon/core.c~mm-damon-core-move-static-variable-rotation-to-damon_ctx +3 -2
@@ -3753,12 +3753,13 @@ static void damon_split_regions_of(struc
 static void damon_split_some_regions(struct damon_ctx *ctx,
 				     unsigned long split_step)
 {
-	static unsigned long rotation;
 	struct damon_target *t;
 	struct damon_region *r, *next;
-	unsigned long offset = rotation++ % split_step;
+	unsigned long offset;
 	unsigned long idx = 0;
 
+	offset = ctx->region_split_rotation++ % split_step;
+
 	damon_for_each_target(t, ctx) {
 		damon_for_each_region_safe(r, next, t) {
 			unsigned long sz_region, sz_sub;

_

Patches currently in -mm which might be from [email protected] are

selftests-damon-sysfs_memcg_path_leak-define-ksft_skip.patch mm-damon-core-copy-only-installed-probe-in-damon_split_region_at.patch