perf jevents: Don't encode MSRs with no value
Ian Rogers
reviewerPATCH 1/1 perf jevents: Don't encode MSRs with no value
Fixes the events mem_trans_retired.load_latency (EMR) and mem_inst_retired.latency_above_threshold_0 (NHM, WSM) that were having their ldlat= value encoded as python's None.
--- tools/perf/pmu-events/jevents.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/pmu-events/jevents.py +1 -1
@@ -396,7 +396,7 @@ class JsonEvent: event += f',{value}{canonicalize_value(jd[key])}' if filter: event += f',{filter}' - if msr: + if msr and msrval: event += f',{msr}{msrval}' if self.desc and extra_desc: self.desc += extra_desc
Signature · 1 line
2.56.0.455.g6c5a503b38-goog
[email protected]
AI reviewSashiko has reviewed this patch and found no issues.
Quoted 8 lines
Fixes the events mem_trans_retired.load_latency (EMR) and mem_inst_retired.latency_above_threshold_0 (NHM, WSM) that were having their ldlat= value encoded as python's None.
Fixes ffc606ada3d7 ("perf jevents: Add python converter script")Reported-by kernel test robot <[email protected]>Signed-off-by Ian Rogers <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Quoted 25 lines · Ian Rogers
Fixes the events mem_trans_retired.load_latency (EMR) and mem_inst_retired.latency_above_threshold_0 (NHM, WSM) that were having their ldlat= value encoded as python's None.
Fixes ffc606ada3d7 ("perf jevents: Add python converter script")Reported-by kernel test robot <[email protected]>Signed-off-by Ian Rogers <[email protected]>--- tools/perf/pmu-events/jevents.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/pmu-events/jevents.py +1
-1@@ -396,7 +396,7 @@ class JsonEvent: event += f',{value}{canonicalize_value(jd[key])}' if filter: event += f',{filter}' - if msr: + if msr and msrval: event += f',{msr}{msrval}' if self.desc and extra_desc: self.desc += extra_desc
Namhyung Kim
maintainerQuoted 8 lines · Ian Rogers
Fixes the events mem_trans_retired.load_latency (EMR) and mem_inst_retired.latency_above_threshold_0 (NHM, WSM) that were having their ldlat= value encoded as python's None.
Fixes ffc606ada3d7 ("perf jevents: Add python converter script")Reported-by kernel test robot <[email protected]>Signed-off-by Ian Rogers <[email protected]>
Arnaldo, I think it's good to go to v7.4.
Thanks,
Namhyung
Quoted 20 lines
--- tools/perf/pmu-events/jevents.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/pmu-events/jevents.py +1
-1@@ -396,7 +396,7 @@ class JsonEvent: event += f',{value}{canonicalize_value(jd[key])}' if filter: event += f',{filter}' - if msr: + if msr and msrval: event += f',{msr}{msrval}' if self.desc and extra_desc: self.desc += extra_descSignature · 1 line
2.56.0.455.g6c5a503b38-goog