FAILED: patch "[PATCH] hwmon: (lm70) Fix rounding of negative temperatures" failed to apply to 5.15-stable tree
Subsystems (2)
Sasha Levin
maintainerThe patch below does not apply to the 5.15-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y
git checkout FETCH_HEAD
git cherry-pick -x eddb0aaacce4baa9d8176eb2f4bd9e99e867f8fc
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '[email protected]' --subject-prefix 'PATCH 5.15.y' 'HEAD^..'
Thanks,
Sasha
------------------ original commit in Linus's tree ------------------
From eddb0aaacce4baa9d8176eb2f4bd9e99e867f8fc Mon Sep 17 00:00:00 2001
From: Ridham Khurana <[email protected]>
Date: Thu, 24 Sep 2026 20:53:23 +0000
Subject: [PATCH] hwmon: (lm70) Fix rounding of negative temperatures
temp1_input_show() drops the low bits of the temperature register by dividing the raw value (raw / 32 on the LM70). These bits are not part of the temperature: the LM70, LM71, LM74 and TMP122/TMP124 always return some of them as 1, and the TMP125 fills them with copies of the temperature LSB. Division rounds toward zero, so a negative temperature with any of these bits set is reported one LSB too high.
For example, the TMP122 returns 0xffff for -0.0625 degrees C, which the driver reports as 0. The LM70 returns 0xf39f for -25 degrees C, which the driver reports as -24750.
Use an arithmetic right shift instead, which drops the low bits and rounds down.
--- drivers/hwmon/lm70.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/hwmon/lm70.c +4 -4
@@ -96,21 +96,21 @@ static ssize_t temp1_input_show(struct device *dev,*/ switch (p_lm70->chip) {case LM70_CHIP_LM70 : - val = ((int )raw /32 ) *250 ; + val = ((int )raw >>5 ) *250 ;break ;case LM70_CHIP_TMP121 :case LM70_CHIP_TMP122 :case LM70_CHIP_LM74 : - val = ((int )raw /8 ) *625 /10 ; + val = ((int )raw >>3 ) *625 /10 ;break ;case LM70_CHIP_LM71 : - val = ((int )raw /4 ) *3125 /100 ; + val = ((int )raw >>2 ) *3125 /100 ;break ;case LM70_CHIP_TMP125 : - val = (sign_extend32 (raw,14 ) /32 ) *250 ; + val = (sign_extend32 (raw,14 ) >>5 ) *250 ;break ; }
Signature · 1 line
2.53.0
Sasha Levin
maintainerPATCH 1/1 hwmon: (lm70) Fix rounding of negative temperatures
From: Ridham Khurana <[email protected]>
[ Upstream commit eddb0aaacce4baa9d8176eb2f4bd9e99e867f8fc ]
temp1_input_show() drops the low bits of the temperature register by dividing the raw value (raw / 32 on the LM70). These bits are not part of the temperature: the LM70, LM71, LM74 and TMP122/TMP124 always return some of them as 1, and the TMP125 fills them with copies of the temperature LSB. Division rounds toward zero, so a negative temperature with any of these bits set is reported one LSB too high.
For example, the TMP122 returns 0xffff for -0.0625 degrees C, which the driver reports as 0. The LM70 returns 0xf39f for -25 degrees C, which the driver reports as -24750.
Use an arithmetic right shift instead, which drops the low bits and rounds down.
--- drivers/hwmon/lm70.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hwmon/lm70.c +3 -3
@@ -90,17 +90,17 @@ static ssize_t temp1_input_show(struct device *dev,*/ switch (p_lm70->chip) {case LM70_CHIP_LM70 : - val = ((int )raw /32 ) *250 ; + val = ((int )raw >>5 ) *250 ;break ;case LM70_CHIP_TMP121 :case LM70_CHIP_TMP122 :case LM70_CHIP_LM74 : - val = ((int )raw /8 ) *625 /10 ; + val = ((int )raw >>3 ) *625 /10 ;break ;case LM70_CHIP_LM71 : - val = ((int )raw /4 ) *3125 /100 ; + val = ((int )raw >>2 ) *3125 /100 ;break ; }
Signature · 1 line
2.53.0