Skip to contentSkip to conversation

ALSA: hda/realtek: Update quirk for Acer Predator PHN16-72

PATCH In review Fa-Iz Faadhillah Ibrahim 2 participants 2 messages Nov 11 – Nov 12 Sound

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ALSA: hda/realtek: Update quirk for Acer Predator PHN16-72

The Acer Predator PHN16-72 (1025:1731) uses the ALC245 codec, but its mic-mute LED is not enabled by default. Replace the existing quirk with ALC245_FIXUP_ACER_MICMUTE_LED quirk to enable the mic-mute LED chain the existing ALC2XX_FIXUP_HEADSET_MIC quirk.

Fixes 34e08ad3a8da ("ALSA: hda/realtek: Add quirk for Acer Predator PHN16-72")

---
v2:
- Replace the existing quirk instead of adding a new one
- Update commit message

Tested on my own device; Headset mic still works and mic-mute led now works fine.

 sound/hda/codecs/realtek/alc269.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/hda/codecs/realtek/alc269.c +1 -1
index a756e0076021..92c158e9d91d 100644
@@ -7553,7 +7553,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1025, 0x170f, "Acer Predator PHN16-71", ALC2XX_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1025, 0x171e, "Acer Nitro ANV15-51", ALC245_FIXUP_ACER_MICMUTE_LED),
 	SND_PCI_QUIRK(0x1025, 0x172c, "Acer Nitro ANV16-41", ALC2XX_FIXUP_HEADSET_MIC),
-	SND_PCI_QUIRK(0x1025, 0x1731, "Acer Predator PHN16-72", ALC2XX_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x1025, 0x1731, "Acer Predator PHN16-72", ALC245_FIXUP_ACER_MICMUTE_LED),
 	SND_PCI_QUIRK(0x1025, 0x173a, "Acer Swift SFG14-73", ALC245_FIXUP_ACER_MICMUTE_LED),
 	SND_PCI_QUIRK(0x1025, 0x173b, "Acer Swift SFG16-72", ALC245_FIXUP_ACER_MICMUTE_LED),
 	SND_PCI_QUIRK(0x1025, 0x1758, "Acer Nitro ANV15-41", ALC245_FIXUP_ACER_MICMUTE_LED),
Signature · 1 line
2.56.1
#1 lore raw
Quoted 8 lines · Fa-Iz Faadhillah Ibrahim

The Acer Predator PHN16-72 (1025:1731) uses the ALC245 codec, but its mic-mute LED is not enabled by default. Replace the existing quirk with ALC245_FIXUP_ACER_MICMUTE_LED quirk to enable the mic-mute LED chain the existing ALC2XX_FIXUP_HEADSET_MIC quirk.

Fixes 34e08ad3a8da ("ALSA: hda/realtek: Add quirk for Acer Predator PHN16-72")

Applied now. Thanks.

Takashi