ASoC: Intel: Remove unused intel-sst.h trace header
PATCH v2 1/1 ASoC: Intel: Remove unused intel-sst.h trace header
Commit 970d299b0a0a ("ASoC: Intel: Remove unused code") removed sound/soc/intel/common/sst-dsp.c, the only file that defined CREATE_TRACE_POINTS and included trace/events/intel-sst.h.
Nothing includes this header anymore, so none of its tracepoints are built. Remove the unused header.
---
Changes in v2:
- Remove the whole header instead of only sst_ipc_inbox_rdata, since nothing includes it (reported by the Sashiko review of v1).
- Drop the Fixes tag and the claim about memory used per tracepoint.
- This also replaces the earlier sst_ipc_msg_tx patch for the same header.
include/trace/events/intel-sst.h | 156 ------------------------------- 1 file changed, 156 deletions(-) delete mode 100644 include/trace/events/intel-sst.h
include/trace/events/intel-sst.h deleted +0 -156
@@ -1,156 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#undef TRACE_SYSTEM -#define TRACE_SYSTEM intel-sst - -/* -* The TRACE_SYSTEM_VAR defaults to TRACE_SYSTEM, but must be a -* legitimate C variable. It is not exported to user space. -*/ -#undef TRACE_SYSTEM_VAR -#define TRACE_SYSTEM_VAR intel_sst - -#if !defined(_TRACE_INTEL_SST_H) || defined(TRACE_HEADER_MULTI_READ ) -#define _TRACE_INTEL_SST_H - -#include <linux/types.h> -#include <linux/ktime.h> -#include <linux/tracepoint.h> - -DECLARE_EVENT_CLASS (sst_ipc_msg, - - TP_PROTO(unsigned int val), - -TP_ARGS (val), - -TP_STRUCT__entry ( - __field( unsigned int, val ) - ), - -TP_fast_assign ( - __entry->val = val; - ), - -TP_printk ("0x%8.8x" , (unsigned int )__entry->val) -); - -DEFINE_EVENT (sst_ipc_msg, sst_ipc_msg_tx, - - TP_PROTO(unsigned int val), - -TP_ARGS (val) - -); - -DEFINE_EVENT (sst_ipc_msg, sst_ipc_msg_rx, - - TP_PROTO(unsigned int val), - -TP_ARGS (val) - -); - -DECLARE_EVENT_CLASS (sst_ipc_mailbox, - - TP_PROTO(unsigned int offset, unsigned int val), - -TP_ARGS (offset, val), - -TP_STRUCT__entry ( - __field( unsigned int, offset ) - __field( unsigned int, val ) - ), - -TP_fast_assign ( - __entry->offset = offset; - __entry->val = val; - ), - -TP_printk (" 0x%4.4x = 0x%8.8x" , - (unsigned int )__entry->offset, (unsigned int )__entry->val) -); - -DEFINE_EVENT (sst_ipc_mailbox, sst_ipc_inbox_rdata, - - TP_PROTO(unsigned int offset, unsigned int val), - -TP_ARGS (offset, val) - -); - -DEFINE_EVENT (sst_ipc_mailbox, sst_ipc_inbox_wdata, - - TP_PROTO(unsigned int offset, unsigned int val), - -TP_ARGS (offset, val) - -); - -DEFINE_EVENT (sst_ipc_mailbox, sst_ipc_outbox_rdata, - - TP_PROTO(unsigned int offset, unsigned int val), - -TP_ARGS (offset, val) - -); - -DEFINE_EVENT (sst_ipc_mailbox, sst_ipc_outbox_wdata, - - TP_PROTO(unsigned int offset, unsigned int val), - -TP_ARGS (offset, val) - -); - -DECLARE_EVENT_CLASS (sst_ipc_mailbox_info, - - TP_PROTO(unsigned int size), - -TP_ARGS (size), - -TP_STRUCT__entry ( - __field( unsigned int, size ) - ), - -TP_fast_assign ( - __entry->size = size; - ), - -TP_printk ("Mailbox bytes 0x%8.8x" , (unsigned int )__entry->size) -); - -DEFINE_EVENT (sst_ipc_mailbox_info, sst_ipc_inbox_read, - - TP_PROTO(unsigned int size), - -TP_ARGS (size) - -); - -DEFINE_EVENT (sst_ipc_mailbox_info, sst_ipc_inbox_write, - - TP_PROTO(unsigned int size), - -TP_ARGS (size) - -); - -DEFINE_EVENT (sst_ipc_mailbox_info, sst_ipc_outbox_read, - - TP_PROTO(unsigned int size), - -TP_ARGS (size) - -); - -DEFINE_EVENT (sst_ipc_mailbox_info, sst_ipc_outbox_write, - - TP_PROTO(unsigned int size), - -TP_ARGS (size) - -); - -#endif /* _TRACE_SST_H */ - -/* This part must be outside protection */ -#include <trace/define_trace.h>
Signature · 1 line
2.53.0
Quoted 7 lines · Temitope obabi
Commit
970d299b0a0a("ASoC: Intel: Remove unused code") removedsound/soc/intel/common/sst-dsp.c, the only file that definedCREATE_TRACE_POINTSand includedtrace/events/intel-sst.h.Nothing includes this header anymore, so none of its tracepoints are built. Remove the unused header.
Quoted 7 lines
Signed-off-by Temitope obabi <[email protected]>---
Changes in v2:
- Remove the whole header instead of onlysst_ipc_inbox_rdata, since nothing includes it (reported by the Sashiko review of v1).
- Drop the Fixes tag and the claim about memory used per tracepoint.
- This also replaces the earliersst_ipc_msg_txpatch for the same header.
Next time, please CC sound/soc/intel maintainers. The very commit starts with "ASoC: Intel:".
Nitpick: if trace-subsystem maintainers permit ASoC-scoping for include/trace, please update the title to: "ASoC: Intel: atom:" to highlight which driver it does relate to.
The nitpick alone is not a reason for re-send.
Steven Rostedt
maintainerQuoted 15 lines · On Thu, 12 Nov 2026 10:53:04 +0100 Cezary Rojewski <[email protected]>…
Quoted 7 lines · Temitope obabi
Commit
970d299b0a0a("ASoC: Intel: Remove unused code") removedsound/soc/intel/common/sst-dsp.c, the only file that definedCREATE_TRACE_POINTSand includedtrace/events/intel-sst.h.Nothing includes this header anymore, so none of its tracepoints are built. Remove the unused header.
Quoted 7 lines
Signed-off-by Temitope obabi <[email protected]>---
Changes in v2:
- Remove the whole header instead of onlysst_ipc_inbox_rdata, since nothing includes it (reported by the Sashiko review of v1).
- Drop the Fixes tag and the claim about memory used per tracepoint.
- This also replaces the earliersst_ipc_msg_txpatch for the same header.
Quoted 6 lines
Next time, please CC
sound/soc/intelmaintainers. The very commit starts with "ASoC: Intel:".Nitpick: if trace-subsystem maintainers permit ASoC-scoping for
include/trace, please update the title to: "ASoC: Intel: atom:" to highlight which driver it does relate to.
I can make these updates.
Quoted 4 lines
The nitpick alone is not a reason for re-send.
Acked-by Cezary Rojewski <[email protected]>
Thanks for the Ack.
Temitope,
Files in include/trace/events/ are special and unfortunately, the get-maintainers.pl script doesn't usually work for them. That's because the headers in that directory really belong to the subsystems that define tracepoints for.
The best way to find out who to Cc is to find a file where the tracepoint is used and run get-maintainers on that. Unfortunately, the file that had them was removed so that wouldn't work either. The next best thing is to look at the commit that removed the file, and Cc those that were involved in the removal. In general, you should always Cc those involved with anything in the commit of the fixes tag (which this commit should have had for 970d299b0a0a).
$ git show 970d299b0a0a
[..]
Reviewed-by: Cezary Rojewski <[email protected]>
Signed-off-by: Amadeusz Sławiński <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>All the emails in the above should be Cc'd on changes like this.
Thanks,
-- Steve
PATCH v3 1/1 ASoC: Intel: Remove unused intel-sst.h trace header
In reply to Temitope obabiCommit 970d299b0a0a ("ASoC: Intel: Remove unused code") removed sound/soc/intel/common/sst-dsp.c, the only file that defined CREATE_TRACE_POINTS and included trace/events/intel-sst.h.
Nothing includes this header anymore, so none of its tracepoints are built. Remove the unused header.
---
Notes:
Changes in v3:
- Rebased on broonie/sound.git for-7.5, which already has the earlier sst_ipc_inbox_rdata patch applied.
- Added Fixes tag.
- Added Acked-by from Cezary.
- Added the people from commit 970d299b0a0a to Cc.
v2: https://lore.kernel.org/all/[email protected]/
include/trace/events/intel-sst.h | 148 ------------------------------- 1 file changed, 148 deletions(-) delete mode 100644 include/trace/events/intel-sst.h
include/trace/events/intel-sst.h deleted +0 -148
@@ -1,148 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#undef TRACE_SYSTEM -#define TRACE_SYSTEM intel-sst - -/* -* The TRACE_SYSTEM_VAR defaults to TRACE_SYSTEM, but must be a -* legitimate C variable. It is not exported to user space. -*/ -#undef TRACE_SYSTEM_VAR -#define TRACE_SYSTEM_VAR intel_sst - -#if !defined(_TRACE_INTEL_SST_H) || defined(TRACE_HEADER_MULTI_READ ) -#define _TRACE_INTEL_SST_H - -#include <linux/types.h> -#include <linux/ktime.h> -#include <linux/tracepoint.h> - -DECLARE_EVENT_CLASS (sst_ipc_msg, - - TP_PROTO(unsigned int val), - -TP_ARGS (val), - -TP_STRUCT__entry ( - __field( unsigned int, val ) - ), - -TP_fast_assign ( - __entry->val = val; - ), - -TP_printk ("0x%8.8x" , (unsigned int )__entry->val) -); - -DEFINE_EVENT (sst_ipc_msg, sst_ipc_msg_tx, - - TP_PROTO(unsigned int val), - -TP_ARGS (val) - -); - -DEFINE_EVENT (sst_ipc_msg, sst_ipc_msg_rx, - - TP_PROTO(unsigned int val), - -TP_ARGS (val) - -); - -DECLARE_EVENT_CLASS (sst_ipc_mailbox, - - TP_PROTO(unsigned int offset, unsigned int val), - -TP_ARGS (offset, val), - -TP_STRUCT__entry ( - __field( unsigned int, offset ) - __field( unsigned int, val ) - ), - -TP_fast_assign ( - __entry->offset = offset; - __entry->val = val; - ), - -TP_printk (" 0x%4.4x = 0x%8.8x" , - (unsigned int )__entry->offset, (unsigned int )__entry->val) -); - -DEFINE_EVENT (sst_ipc_mailbox, sst_ipc_inbox_wdata, - - TP_PROTO(unsigned int offset, unsigned int val), - -TP_ARGS (offset, val) - -); - -DEFINE_EVENT (sst_ipc_mailbox, sst_ipc_outbox_rdata, - - TP_PROTO(unsigned int offset, unsigned int val), - -TP_ARGS (offset, val) - -); - -DEFINE_EVENT (sst_ipc_mailbox, sst_ipc_outbox_wdata, - - TP_PROTO(unsigned int offset, unsigned int val), - -TP_ARGS (offset, val) - -); - -DECLARE_EVENT_CLASS (sst_ipc_mailbox_info, - - TP_PROTO(unsigned int size), - -TP_ARGS (size), - -TP_STRUCT__entry ( - __field( unsigned int, size ) - ), - -TP_fast_assign ( - __entry->size = size; - ), - -TP_printk ("Mailbox bytes 0x%8.8x" , (unsigned int )__entry->size) -); - -DEFINE_EVENT (sst_ipc_mailbox_info, sst_ipc_inbox_read, - - TP_PROTO(unsigned int size), - -TP_ARGS (size) - -); - -DEFINE_EVENT (sst_ipc_mailbox_info, sst_ipc_inbox_write, - - TP_PROTO(unsigned int size), - -TP_ARGS (size) - -); - -DEFINE_EVENT (sst_ipc_mailbox_info, sst_ipc_outbox_read, - - TP_PROTO(unsigned int size), - -TP_ARGS (size) - -); - -DEFINE_EVENT (sst_ipc_mailbox_info, sst_ipc_outbox_write, - - TP_PROTO(unsigned int size), - -TP_ARGS (size) - -); - -#endif /* _TRACE_SST_H */ - -/* This part must be outside protection */ -#include <trace/define_trace.h>
Signature · 1 line
2.53.0
Quoted 1 line · Temitope obabi
ASoC: Intel: Remove unused
intel-sst.htrace header
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.5
Thanks!
[1/1] ASoC: Intel: Remove unused intel-sst.h trace header
https://git.kernel.org/broonie/sound/c/fdf2a24354c5
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark