Skip to contentSkip to conversation

dt-bindings: phy: qcom: Relax required supplies

PATCH Superseded Rob Herring (Arm) 4 participants 9 messages Oct 21 – Nov 12

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH v2 1/1 dt-bindings: phy: qcom: Relax required supplies

For the QUSB2 PHY binding, keep the three regulator supplies required except for legacy IPQ6018 nodes that do not describe the board rails.

This relaxes the requirements for the IPQ5210 as well as if it is compatible with IPQ6018, then it shouldn't have more required properties either.

---
v2:
- Fix trailing whitespace
- Add blurb to commit msg (for sashiko)

---
 .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml +14 -3
index 001fd0ccc985..1245b174b0ab 100644
@@ -165,12 +165,23 @@ required:
   - "#phy-cells"
   - clocks
   - clock-names
-  - vdd-supply
-  - vdda-pll-supply
-  - vdda-phy-dpdm-supply
   - resets
 
 allOf:
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - qcom,ipq6018-qusb2-phy
+                - qcom,ipq8074-qusb2-phy
+    then:
+      required:
+        - vdd-supply
+        - vdda-pll-supply
+        - vdda-phy-dpdm-supply
+
   - if:
       not:
         properties:
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 6 lines · Rob Herring (Arm)

For the QUSB2 PHY binding, keep the three regulator supplies required except for legacy IPQ6018 nodes that do not describe the board rails.

This relaxes the requirements for the IPQ5210 as well as if it is compatible with IPQ6018, then it shouldn't have more required properties either.

Hey Rob,

This fails for phy/next I see vdd-supply has been moved around..

Signature · 1 line
~Vinod
author maintainer
#2 lore raw

+Konrad

Quoted 11 lines · Vinod Koul
Quoted 6 lines · Rob Herring (Arm)

For the QUSB2 PHY binding, keep the three regulator supplies required except for legacy IPQ6018 nodes that do not describe the board rails.

This relaxes the requirements for the IPQ5210 as well as if it is compatible with IPQ6018, then it shouldn't have more required properties either.

Hey Rob,

This fails for phy/next I see vdd-supply has been moved around..

The change in question[1] should not be applied until the .dts changes in the series are applied. It introduces a bunch of warnings. Can the QCom folks stop doing that! Coordinate applying the series or take the binding and dts changes in 1 tree. Given the patch series is 2+ months old, I'd be surprised if the rest gets applied.

This patch OTOH fixes warnings.

Rob

[1] https://lore.kernel.org/all/[email protected]

maintainer Acked-by
#3 lore raw
Quoted 13 lines · Rob Herring

+Konrad

Quoted 10 lines · Vinod Koul
Quoted 6 lines · Rob Herring (Arm)

For the QUSB2 PHY binding, keep the three regulator supplies required except for legacy IPQ6018 nodes that do not describe the board rails.

This relaxes the requirements for the IPQ5210 as well as if it is compatible with IPQ6018, then it shouldn't have more required properties either.

Hey Rob,

Quoted 7 lines
Quoted 1 line

This fails for phy/next I see vdd-supply has been moved around..

The change in question[1] should not be applied until the .dts changes in the series are applied. It introduces a bunch of warnings. Can the QCom folks stop doing that! Coordinate applying the series or take the binding and dts changes in 1 tree. Given the patch series is 2+ months old, I'd be surprised if the rest gets applied.

If Konrad/Bjorn want to take this all together thur QC tree they can have my ack

Signature · 1 line
~Vinod
#4 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring

+Konrad

Quoted 8 lines · Vinod Koul
Quoted 6 lines · Rob Herring (Arm)

For the QUSB2 PHY binding, keep the three regulator supplies required except for legacy IPQ6018 nodes that do not describe the board rails.

This relaxes the requirements for the IPQ5210 as well as if it is compatible with IPQ6018, then it shouldn't have more required properties either.

Quoted 6 lines
Quoted 3 lines

Hey Rob,

This fails for phy/next I see vdd-supply has been moved around..

The change in question[1] should not be applied until the .dts changes in the series are applied. It introduces a bunch of warnings.

I don't understand. The change you present here relates to ipq5210 and ipq6018.

That change doesn't touch these two IPQs, so what are you suggesting? Are we talking about the same warnings?

Quoted 2 lines

Can the QCom folks stop doing that! Coordinate applying the series or take the binding and dts changes in 1 tree.

I assume you're referring to "QCom folks" in the sense "any maintainer touching a binding change related to a qcom platform"?

Do you have some CI/guidance/tooling for Vinod (and other subsystem maintainers) to perform system-wide DT-validation when considering merging a binding change?

I unfortunately only spotted the one-way dependency when glancing at the seris and thereby ignored the dts patches waiting for the binding to be merged.

Quoted 2 lines

Given the patch series is 2+ months old, I'd be surprised if the rest gets applied.

I've applied the two dts changes today, and they do resolve a number of warnings - presumably the ones that you're talking about, but I don't think the ones that this patch aim to fix?

Quoted 3 lines

This patch OTOH fixes warnings.

What warnings? Can you please provide actionable context when you're pointing out these issues.

Is it the three "'x-supply' is a required property" warnings from ipq6018-cp01-c1.dtb? It seems unlikely that there's one chip that doesn't depend on those supplies.

Quoted 4 lines

Rob

[1] https://lore.kernel.org/all/[email protected]

https://lore.kernel.org/all/20260903-topic-8996_61x5_qusb2phy-v2-1-4c3f980a4560@oss.qualcomm.com/

Regards,
Bjorn

author maintainer
#5 lore raw
Quoted 17 lines · Bjorn Andersson
Quoted 15 lines · Rob Herring

+Konrad

Quoted 11 lines · Vinod Koul
Quoted 6 lines · Rob Herring (Arm)

For the QUSB2 PHY binding, keep the three regulator supplies required except for legacy IPQ6018 nodes that do not describe the board rails.

This relaxes the requirements for the IPQ5210 as well as if it is compatible with IPQ6018, then it shouldn't have more required properties either.

Hey Rob,

This fails for phy/next I see vdd-supply has been moved around..

Quoted 8 lines
Quoted 2 lines

The change in question[1] should not be applied until the .dts changes in the series are applied. It introduces a bunch of warnings.

I don't understand. The change you present here relates to ipq5210 and ipq6018.

That change doesn't touch these two IPQs, so what are you suggesting? Are we talking about the same warnings?

This is what I get with phy-next because it has the binding change from [1], but not the .dts changes in the series:

arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: phy@7411000 (qcom,msm8996-qusb2-phy): "power-domains" is a required property
from schema $id:
http://devicetree.org/schemas/phy/qcom,qusb2-phy.yaml
arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: phy@7411000 (qcom,msm8996-qusb2-phy): "required-opps" is a required property
from schema $id:
http://devicetree.org/schemas/phy/qcom,qusb2-phy.yaml

(and then duplicated for every 8996 board).

Quoted 5 lines
Quoted 2 lines

Can the QCom folks stop doing that! Coordinate applying the series or take the binding and dts changes in 1 tree.

I assume you're referring to "QCom folks" in the sense "any maintainer touching a binding change related to a qcom platform"?

No, primarily you and the submitter I guess. Submitters should be aware of dependencies in their series and suggest how things are merged. Otherwise, it falls on you to care that warnings are getting introduced.

I would not care so much when there are transient warnings in next, but I don't want to be the one chasing them down. But AFAICT, it's always me. No one beats me to it and I'm not all that fast in noticing. I just compare all the warnings by platform for Linus vs. next with "gl-diff-dtb-warning -p arm64" from this repo[2], and look for things moving in the right direction. Of course this is all after applying which isn't ideal.

Quoted 3 lines

Do you have some CI/guidance/tooling for Vinod (and other subsystem maintainers) to perform system-wide DT-validation when considering merging a binding change?

This one is an ABI break because it adds new required properties. I do have some tooling that looks for ABI changes, but haven't committed it because I haven't figured out the best way to deploy it. I think for anything that is an ABI change, the binding and dts files need to go in together.

I think it is time to reconsider the default of bindings go in with the driver. That works okay for new bindings as long as the platform maintainer doesn't take .dts changes before bindings land (also an issue). However, for cases like this, we need the opposite order. We need to figure something out because this is only going to be more of an issue as we get to warning free (and we are close).

Quoted 10 lines

I unfortunately only spotted the one-way dependency when glancing at the seris and thereby ignored the dts patches waiting for the binding to be merged.

Quoted 2 lines

Given the patch series is 2+ months old, I'd be surprised if the rest gets applied.

I've applied the two dts changes today, and they do resolve a number of warnings - presumably the ones that you're talking about, but I don't think the ones that this patch aim to fix?

Other than the warnings it introduces, the [1] series fixes this one warning;

      3 phy@7411000 (qcom,msm8996-qusb2-phy): "vdd-supply" is a

required property

Quoted 9 lines
Quoted 2 lines

This patch OTOH fixes warnings.

What warnings? Can you please provide actionable context when you're pointing out these issues.

Is it the three "'x-supply' is a required property" warnings from ipq6018-cp01-c1.dtb? It seems unlikely that there's one chip that doesn't depend on those supplies.

Of your 20 unique warnings, it's these 10:

      1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdd-supply" is a required property
      1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdda-pll-supply" is a
required property
      1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdda-phy-dpdm-supply" is
a required property
      1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdd-supply" is a required property
      1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdda-pll-supply" is a
required property
      1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdda-phy-dpdm-supply" is
a required property
      1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdd-supply" is a required property
      1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdda-pll-supply" is a
required property
      1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdda-phy-dpdm-supply" is

a required property

Rob

Quoted 1 line
Quoted 1 line

[1] https://lore.kernel.org/all/[email protected]

[2] https://gitlab.com/robherring/ci-jobs

#6 lore raw
Quoted 1 line · Rob Herring

On Thu, Nov 12, 2026 at 12:30 PM Bjorn Andersson <[email protected]> wrote:

(replying only to parts of the message)

Quoted 11 lines
Quoted 6 lines
Quoted 3 lines

Can the QCom folks stop doing that! Coordinate applying the series or take the binding and dts changes in 1 tree.

I assume you're referring to "QCom folks" in the sense "any maintainer touching a binding change related to a qcom platform"?

No, primarily you and the submitter I guess. Submitters should be aware of dependencies in their series and suggest how things are merged. Otherwise, it falls on you to care that warnings are getting introduced.

We all have been swamped with patches and Qualcomm have been probably the busiest arm64 platform for months now.

for i in arch/arm64/boot/dts/* ; do echo "${i}:$(git log --no-merges --oneline v7.0..v7.4-rc1 -- $i | wc -l)" ; done

qcom: 1016
freescale: 485
renesas: 215

Qualcomm SoC got one more maintainer, so there is catching up, but probably not enough.

Quoted 8 lines

I would not care so much when there are transient warnings in next, but I don't want to be the one chasing them down. But AFAICT, it's always me. No one beats me to it and I'm not all that fast in noticing. I just compare all the warnings by platform for Linus vs. next with "gl-diff-dtb-warning -p arm64" from this repo[2], and look for things moving in the right direction. Of course this is all after applying which isn't ideal.

FWIW, I do test all Samsung ones and I look only at some of Qualcomm boards, because there were just too many warnings to have a clean dtbs_check for qcom. I do report them to Bjorn/Konrad [1], but that's indeed only subset of entire qcom ecosystem. I know that a few other SoC platforms keep track (TI at least).

[1] https://krzk.eu/#/builders/102

Quoted 11 lines
Quoted 4 lines

Do you have some CI/guidance/tooling for Vinod (and other subsystem maintainers) to perform system-wide DT-validation when considering merging a binding change?

This one is an ABI break because it adds new required properties. I do have some tooling that looks for ABI changes, but haven't committed it because I haven't figured out the best way to deploy it. I think for anything that is an ABI change, the binding and dts files need to go in together.

Quoted 6 lines

I think it is time to reconsider the default of bindings go in with the driver. That works okay for new bindings as long as the platform maintainer doesn't take .dts changes before bindings land (also an issue). However, for cases like this, we need the opposite order. We need to figure something out because this is only going to be more of an issue as we get to warning free (and we are close).

We have been talking about this for some time and recent consensus was that SoC maintainers can freely take such bindings when driver subsystem maintainers lag behind. The case here is a bit opposite - driver subsystem was before SoC.

So let's change the generic recommendation/policy? Whenever patchset touches bindings and DTS, and the bindings do not need any driver updates like they add only front-specific compatibles, the SoC should take entire set?

Best regards,
Krzysztof

author maintainer
#7 lore raw
Quoted 25 lines · Krzysztof Kozlowski
Quoted 1 line · Rob Herring

On Thu, Nov 12, 2026 at 12:30 PM Bjorn Andersson <[email protected]> wrote:

(replying only to parts of the message)

Quoted 11 lines
Quoted 6 lines
Quoted 3 lines

Can the QCom folks stop doing that! Coordinate applying the series or take the binding and dts changes in 1 tree.

I assume you're referring to "QCom folks" in the sense "any maintainer touching a binding change related to a qcom platform"?

No, primarily you and the submitter I guess. Submitters should be aware of dependencies in their series and suggest how things are merged. Otherwise, it falls on you to care that warnings are getting introduced.

We all have been swamped with patches and Qualcomm have been probably the busiest arm64 platform for months now.

for i in arch/arm64/boot/dts/* ; do echo "${i}:$(git log --no-merges --oneline v7.0..v7.4-rc1 -- $i | wc -l)" ; done

Quoted 6 lines

qcom: 1016
freescale: 485
renesas: 215

Qualcomm SoC got one more maintainer, so there is catching up, but probably not enough.

Good thing QCom hired half of Linaro...

Quoted 8 lines
Quoted 7 lines

I would not care so much when there are transient warnings in next, but I don't want to be the one chasing them down. But AFAICT, it's always me. No one beats me to it and I'm not all that fast in noticing. I just compare all the warnings by platform for Linus vs. next with "gl-diff-dtb-warning -p arm64" from this repo[2], and look for things moving in the right direction. Of course this is all after applying which isn't ideal.

Quoted 5 lines

FWIW, I do test all Samsung ones and I look only at some of Qualcomm boards, because there were just too many warnings to have a clean dtbs_check for qcom. I do report them to Bjorn/Konrad [1], but that's indeed only subset of entire qcom ecosystem. I know that a few other SoC platforms keep track (TI at least).

The too many warnings excuse is about to run out.

Here's Linus's tree ATM for qcom (I'd list next, but warnings have gone up):

12 syscon@9a10000 (syscon): compatible: ["syscon"] has less than 2 items

https://lore.kernel.org/all/[email protected]/

5 usb@6af8800 (qcom,msm8996-dwc3): Additional properties are not allowed ('extcon' was unexpected) 2 usb@76f8800 (qcom,msm8996-dwc3): Additional properties are not allowed ('extcon' was unexpected)

In the wrong spot or needs to be added to the binding?

2 touchscreen@2c (syna,rmi4-i2c): Unevaluated properties are not allowed ('incell-supply' was unexpected)

https://lore.kernel.org/all/[email protected]/

But seems to be a hack, so?

2 panel@0 (jdi,fhd-r63452): "power-supply" is a required property

???

      3 phy@7411000 (qcom,msm8996-qusb2-phy): "vdd-supply" is a required property
      1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdd-supply" is a required property
      1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdda-pll-supply" is a required property
      1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdda-phy-dpdm-supply" is a required property
      1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdd-supply" is a required property
      1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdda-pll-supply" is a required property
      1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdda-phy-dpdm-supply" is a required property
      1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdd-supply" is a required property
      1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdda-pll-supply" is a required property
      1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdda-phy-dpdm-supply" is a required property

https://lore.kernel.org/all/[email protected]/

      1 panel@0 (lg,sw49410-lh609qh1): Unevaluated properties are not allowed ('reg', 'vsn-supply', 'vsp-supply' were unexpected)
      1 panel@0 (lg,sw49410-lh609qh1): "power-supply" is a required property
      1 panel@0 (lg,sw49410-lh609qh1): compatible: ["lg,sw49410-lh609qh1","lg,sw49410"] has more than 1 item
      1 panel@0 (lg,sw49410-lh609qh1): compatible:0: "lg,sw49410-lh609qh1" is not one of "ampire,am-1280800n3tzqw-t00h", "ampire,am-1280800w8tzqw-t00h" or 178 other candidates

https://lore.kernel.org/all/[email protected]/

      1 panel@0 (flipkart,rimob-panel-nt35532-cs): compatible: ["flipkart,rimob-panel-nt35532-cs"] has less than 2 items

Fixed in next

Undocumented compatibles:3

     'jdi,fhd-nt35596s'

https://lore.kernel.org/all/[email protected]/

But probably belongs in this:

https://lore.kernel.org/all/[email protected]/

     'lg,sw49410-lh609qh1', 'lg,sw49410'

See above

     'qcom,ipq6018-wcss-pil'

Fixed in next

So 3 unique warnings left without fixes in flight.

Quoted 28 lines

[1] https://krzk.eu/#/builders/102

Quoted 7 lines
Quoted 4 lines

Do you have some CI/guidance/tooling for Vinod (and other subsystem maintainers) to perform system-wide DT-validation when considering merging a binding change?

This one is an ABI break because it adds new required properties. I do have some tooling that looks for ABI changes, but haven't committed it

because I haven't figured out the best way to deploy it. I think for

Quoted 9 lines

anything that is an ABI change, the binding and dts files need to go in together.

I think it is time to reconsider the default of bindings go in with the driver. That works okay for new bindings as long as the platform maintainer doesn't take .dts changes before bindings land (also an issue). However, for cases like this, we need the opposite order. We need to figure something out because this is only going to be more of an issue as we get to warning free (and we are close).

We have been talking about this for some time and recent consensus was that SoC maintainers can freely take such bindings when driver subsystem maintainers lag behind. The case here is a bit opposite - driver subsystem was before SoC.

Quoted 4 lines

So let's change the generic recommendation/policy? Whenever patchset touches bindings and DTS, and the bindings do not need any driver updates like they add only front-specific compatibles, the SoC should take entire set?

Yes. Platforms that are warning free already do that.

I also think we (the DT maintainers) need to get stricter on handling of adding or removing required properties. For adding required, delay the binding change a cycle (or after dts is in next). For dropping required, delay the dts change a cycle (or after binding is in next). That's probably too much for any maintainer to check other than DT maintainers. Or maybe add this to sashiko prompts...

Rob

#8 lore raw
In reply to Rob Herring
Quoted 39 lines · Rob Herring
Quoted 17 lines · Bjorn Andersson
Quoted 15 lines · Rob Herring

+Konrad

Quoted 11 lines · Vinod Koul
Quoted 6 lines · Rob Herring (Arm)

For the QUSB2 PHY binding, keep the three regulator supplies required except for legacy IPQ6018 nodes that do not describe the board rails.

This relaxes the requirements for the IPQ5210 as well as if it is compatible with IPQ6018, then it shouldn't have more required properties either.

Hey Rob,

This fails for phy/next I see vdd-supply has been moved around..

Quoted 8 lines
Quoted 2 lines

The change in question[1] should not be applied until the .dts changes in the series are applied. It introduces a bunch of warnings.

I don't understand. The change you present here relates to ipq5210 and ipq6018.

That change doesn't touch these two IPQs, so what are you suggesting? Are we talking about the same warnings?

This is what I get with phy-next because it has the binding change from [1], but not the .dts changes in the series:

arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: phy@7411000 (qcom,msm8996-qusb2-phy): "power-domains" is a required property
from schema $id:
http://devicetree.org/schemas/phy/qcom,qusb2-phy.yaml
arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: phy@7411000 (qcom,msm8996-qusb2-phy): "required-opps" is a required property
from schema $id:
http://devicetree.org/schemas/phy/qcom,qusb2-phy.yaml

Quoted 2 lines

(and then duplicated for every 8996 board).

Good, then we're aligned. These 18 warnings are resolved in my tree, so they should drop again in the next linux-next.

Quoted 11 lines
Quoted 5 lines
Quoted 2 lines

Can the QCom folks stop doing that! Coordinate applying the series or take the binding and dts changes in 1 tree.

I assume you're referring to "QCom folks" in the sense "any maintainer touching a binding change related to a qcom platform"?

No, primarily you and the submitter I guess. Submitters should be aware of dependencies in their series and suggest how things are merged. Otherwise, it falls on you to care that warnings are getting introduced.

I currently do catch these things while applying dts changes, and I've recently cooked a dashboard to track the overall state of mainline and linux-next, but I don't have any solution to catch things prior to merge
- or a good solution for catching regressions coming from binding changes prior to them being merged.

Quoted 6 lines

I would not care so much when there are transient warnings in next, but I don't want to be the one chasing them down. But AFAICT, it's always me. No one beats me to it and I'm not all that fast in noticing. I just compare all the warnings by platform for Linus vs. next with "gl-diff-dtb-warning -p arm64" from this repo[2], and look for things moving in the right direction.

I'll try to wire something up to catch these faster. At least until this regression things has been fairly stable for a while now...

Quoted 2 lines

Of course this is all after applying which isn't ideal.

Thanks to the --cache-dir and --json support it's a bit more convenient to catch things during the merge, but the CPU-power needed for a system-wide sanity check remains a concern.

I would prefer to catch more issues prior to touching the patches, but so far my efforts there has run into issues as contributors keep sending things with loose dependencies.

Quoted 10 lines
Quoted 3 lines

Do you have some CI/guidance/tooling for Vinod (and other subsystem maintainers) to perform system-wide DT-validation when considering merging a binding change?

This one is an ABI break because it adds new required properties. I do have some tooling that looks for ABI changes, but haven't committed it because I haven't figured out the best way to deploy it. I think for anything that is an ABI change, the binding and dts files need to go in together.

After a second look, that would have made more sense, since the driver changes wasn't related to the binding change after all...

Quoted 7 lines

I think it is time to reconsider the default of bindings go in with the driver. That works okay for new bindings as long as the platform maintainer doesn't take .dts changes before bindings land (also an issue). However, for cases like this, we need the opposite order. We need to figure something out because this is only going to be more of an issue as we get to warning free (and we are close).

There's also the ever growing number of small incremental changes to bindings, where subsystem maintainers leave the binding changes to me.

But then there's also the many changes where the driver patches depend on the binding changes. Not sure how to structure this and keep the velocity up.

Quoted 43 lines
Quoted 10 lines

I unfortunately only spotted the one-way dependency when glancing at the seris and thereby ignored the dts patches waiting for the binding to be merged.

Quoted 2 lines

Given the patch series is 2+ months old, I'd be surprised if the rest gets applied.

I've applied the two dts changes today, and they do resolve a number of warnings - presumably the ones that you're talking about, but I don't think the ones that this patch aim to fix?

Other than the warnings it introduces, the [1] series fixes this one warning;

      3 phy@7411000 (qcom,msm8996-qusb2-phy): "vdd-supply" is a

required property

Quoted 9 lines
Quoted 2 lines

This patch OTOH fixes warnings.

What warnings? Can you please provide actionable context when you're pointing out these issues.

Is it the three "'x-supply' is a required property" warnings from ipq6018-cp01-c1.dtb? It seems unlikely that there's one chip that doesn't depend on those supplies.

Of your 20 unique warnings, it's these 10:

      1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdd-supply" is a required property
      1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdda-pll-supply" is a
required property
      1 qusb@59000 (qcom,ipq6018-qusb2-phy): "vdda-phy-dpdm-supply" is
a required property
      1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdd-supply" is a required property
      1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdda-pll-supply" is a
required property
      1 phy@79000 (qcom,ipq8074-qusb2-phy): "vdda-phy-dpdm-supply" is
a required property
      1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdd-supply" is a required property
      1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdda-pll-supply" is a
required property
      1 phy@59000 (qcom,ipq8074-qusb2-phy): "vdda-phy-dpdm-supply" is
Quoted 2 lines

a required property

I'd prefer to actually populate those, I'll take another pass to see if I can find documentation/schematics to resolve them.

Regards,
Bjorn

Quoted 6 lines

Rob

Quoted 1 line
Quoted 1 line

[1] https://lore.kernel.org/all/[email protected]

[2] https://gitlab.com/robherring/ci-jobs