power: supply: qcom_battmgr: Kaanapali current sign and charge current limit
Subsystems (2)
v2 cover power: supply: qcom_battmgr: Kaanapali current sign and charge current limit
Patch 1 fixes the sign of the battery current_now on Kaanapali. Patch 2 exposes the firmware charge current limit on SM8550-class batteries as charge_control_limit and charge_control_limit_max.
Patch 1 has no code change. Its sign is still checked only on the Lenovo Y700 Gen 5 (TB323FU, Kaanapali); Konrad asked Jingyi on v1 to check QRD/MTP [1], and there has been no reply yet.
Changes in v2:
- 2/2: use guard(mutex) [Konrad]
- 2/2: return -ENODATA when the firmware reports a zero maximum [Konrad]
- Rebased on next-20261111
Link to v1: https://lore.kernel.org/all/[email protected]/
[1] https://lore.kernel.org/all/[email protected]/
Joonhoe Kim (2):
power: supply: qcom_battmgr: fix the battery current sign on Kaanapali
power: supply: qcom_battmgr: expose the charge current limit
drivers/power/supply/qcom_battmgr.c | 61 +++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+)
base-commit: aaa2f954c21b205a0bcd0961e5b2be4e82e58455
Signature · 1 line
2.53.0
PATCH v2 1/2 power: supply: qcom_battmgr: fix the battery current sign on Kaanapali
The Kaanapali battery firmware reports the battery current with discharge positive: on a Lenovo Y700 Gen 5 (TB323FU) current_now reads -9.1 A while charging and +0.57 A on battery. The power_supply ABI has charging positive, and upower reports such a charging battery as discharging.
Other firmware behind the same callback uses the ABI sign [1], so negate the value only for qcom,kaanapali-pmic-glink.
---
v2: no code change; reworded the device name.
The sign is checked only on the Y700 Gen 5. On v1 Konrad asked Jingyi to check QRD/MTP; no reply yet:
https://lore.kernel.org/all/[email protected]/
drivers/power/supply/qcom_battmgr.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/power/supply/qcom_battmgr.c +6 -0
@@ -316,6 +316,7 @@ struct qcom_battmgr {struct pmic_glink_client *client;enum qcom_battmgr_variant variant; +bool current_inverted;struct power_supply *ac_psy;struct power_supply *bat_psy;
@@ -1574,6 +1575,8 @@ static void qcom_battmgr_sm8350_callback(struct qcom_battmgr *battmgr,break ;case BATT_CURR_NOW : battmgr->status.current_now =le32_to_cpu (resp->intval.value); +if (battmgr->current_inverted) + battmgr->status.current_now = -battmgr->status.current_now;break ;case BATT_TEMP : val =le32_to_cpu (resp->intval.value);
@@ -1804,6 +1807,9 @@ static int qcom_battmgr_probe(struct auxiliary_device *adev,else battmgr->variant =QCOM_BATTMGR_SM8350 ; + battmgr->current_inverted =device_is_compatible (dev->parent, +"qcom,kaanapali-pmic-glink" ); + ret =qcom_battmgr_charge_control_thresholds_init (battmgr);if (ret <0 ) return dev_err_probe(dev, ret,
Signature · 1 line
2.53.0
PATCH v2 2/2 power: supply: qcom_battmgr: expose the charge current limit
In reply to Joonhoe KimThe battery manager firmware takes a charge current limit in uA (BATT_CHG_CTRL_LIM) and reports the highest value it accepts (BATT_CHG_CTRL_LIM_MAX). Expose them on SM8550 class batteries as charge_control_limit and charge_control_limit_max, clamping writes to the maximum.
Also handle the BATTMGR_BAT_PROPERTY_SET response, which was logged as an unknown message, and return its result.
On a Lenovo Y700 Gen 5 (TB323FU, Kaanapali) with a 45 W PD charger, limits of 500 mA and 100 mA give about 480 mA and 90 mA of charge current while the PD contract stays at 9 V. A limit of 0 stops charging, and this firmware does not resume when the limit is raised again until the end threshold is moved below the capacity and back.
---
v2:
- Use guard(mutex) [Konrad]
- Return -ENODATA when the firmware reports a zero maximum [Konrad]
The downstream qti_battery_charger driver also writes this property in uA. The thermal mitigation series [1] took a cooling level in charge_control_limit; Konrad pointed out that the ABI defines it in uA [2], which this patch follows. Only tested on Kaanapali.
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
drivers/power/supply/qcom_battmgr.c | 55 +++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)
drivers/power/supply/qcom_battmgr.c +55 -0
@@ -262,6 +262,8 @@ struct qcom_battmgr_info {unsigned int charge_count;unsigned int charge_ctrl_start;unsigned int charge_ctrl_end; +unsigned int charge_ctrl_limit; +unsigned int charge_ctrl_limit_max;char model_number[BATTMGR_STRING_LEN ];char serial_number[BATTMGR_STRING_LEN ];char oem_info[BATTMGR_STRING_LEN ];
@@ -454,6 +456,8 @@ static const u8 sm8350_bat_prop_map[] = { [POWER_SUPPLY_PROP_POWER_NOW] = BATT_POWER_NOW, [POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD] = BATT_CHG_CTRL_START_THR, [POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD] = BATT_CHG_CTRL_END_THR, + [POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT] = BATT_CHG_CTRL_LIM, + [POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX] = BATT_CHG_CTRL_LIM_MAX, };/*
@@ -709,6 +713,12 @@ static int qcom_battmgr_bat_get_property(struct power_supply *psy,case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD : val->intval = battmgr->info.charge_ctrl_end;break ; +case POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT : + val->intval = battmgr->info.charge_ctrl_limit; +break ; +case POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX : + val->intval = battmgr->info.charge_ctrl_limit_max; +break ;case POWER_SUPPLY_PROP_MANUFACTURE_YEAR : val->intval = battmgr->info.year;break ;
@@ -803,6 +813,29 @@ static int qcom_battmgr_set_charge_end_threshold(struct qcom_battmgr *battmgr, ireturn 0 ; } +static int qcom_battmgr_set_charge_control_limit (struct qcom_battmgr *battmgr,int limit) +{ +int ret; + +if (limit <0 ) +return -EINVAL ; + +guard (mutex)(&battmgr->lock); + + ret =qcom_battmgr_request_property (battmgr,BATTMGR_BAT_PROPERTY_GET , +BATT_CHG_CTRL_LIM_MAX ,0 ); +if (ret) +return ret; + +if (!battmgr->info.charge_ctrl_limit_max) +return -ENODATA ; + + limit =min_t (u32, limit, battmgr->info.charge_ctrl_limit_max); + +return qcom_battmgr_request_property (battmgr,BATTMGR_BAT_PROPERTY_SET , +BATT_CHG_CTRL_LIM , limit); +} +static int qcom_battmgr_charge_control_thresholds_init (struct qcom_battmgr *battmgr) {int ret;
@@ -838,6 +871,7 @@ static int qcom_battmgr_bat_is_writeable(struct power_supply *psy,switch (psp) {case POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD :case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD : +case POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT :return 1 ;default :return 0 ;
@@ -860,6 +894,8 @@ static int qcom_battmgr_bat_set_property(struct power_supply *psy,return qcom_battmgr_set_charge_start_threshold (battmgr, pval->intval);case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD :return qcom_battmgr_set_charge_end_threshold (battmgr, pval->intval); +case POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT : +return qcom_battmgr_set_charge_control_limit (battmgr, pval->intval);default :return -EINVAL ; }
@@ -995,6 +1031,8 @@ static const enum power_supply_property sm8550_bat_props[] = {POWER_SUPPLY_PROP_POWER_NOW ,POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD ,POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD , +POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT , + POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX, }; static const struct power_supply_desc sm8550_bat_psy_desc = {
@@ -1618,11 +1656,28 @@ static void qcom_battmgr_sm8350_callback(struct qcom_battmgr *battmgr,case BATT_CHG_CTRL_END_THR : battmgr->info.charge_ctrl_end =le32_to_cpu (resp->intval.value);break ; +case BATT_CHG_CTRL_LIM : + battmgr->info.charge_ctrl_limit =le32_to_cpu (resp->intval.value); +break ; +case BATT_CHG_CTRL_LIM_MAX : + battmgr->info.charge_ctrl_limit_max =le32_to_cpu (resp->intval.value); +break ;default :dev_warn (battmgr->dev,"unknown property %#x\n" , property);break ; }break ; +case BATTMGR_BAT_PROPERTY_SET : +if (payload_len !=sizeof (resp->intval)) { +dev_warn (battmgr->dev, +"invalid payload length for battery property set: %zd\n" , + payload_len); + battmgr->error = -ENODATA ; +return ; + } + + battmgr->error =le32_to_cpu (resp->intval.result) ? -EIO :0 ; +break ;case BATTMGR_USB_PROPERTY_GET : property =le32_to_cpu (resp->intval.property);if (payload_len !=sizeof (resp->intval)) {
Signature · 1 line
2.53.0