mm/damon: add lru-active probe filter type
Subsystems (4)
SJ Park
maintainercover mm/damon: add lru-active probe filter type
The LRU-activeness of folios is useful information for understanding and optimizing the system. DAMOS ops filter therefore supports filtering memory based on the information. Using it, the information can be extracted in the folio granularity. It is precise but expensive. DAMON probe filter is the complementary way for getting the information in region granularity with much cheaper cost. DAMON filter does not support LRU-activeness based filtering, though. Add the support.
Define new DAMON filter type, DAMON_FILTER_TYPE_ACTIVE, on core API (patch 1). Add support for it on both vaddr and paddr operation set (patch 2). Extend DAMON filter sysfs ABI to let users configure DAMON filters of the type using a new keyword, "active" (patch 3). Finally, update the DAMON design document to explain the new type (patch 4).
Test
====
Confirmed the functionality like below.
First, start masim [1] to generate a ~476 MiB hot memory region.
$ ./masim.py run --config_file ./configs/stairs-500mb.cfg --repeat 10
Second, start DAMON to monitor data access and active memory ratio of each region using DAMON user-space tool (damo) [2].
$ sudo ./damo start --target_pid $(pidof masim) \
--probe --probe_prep set_pgidle \
--probe_filter allow pgidle_unset \
--probe --probe_filter allow active \
--probe_weight 1 0Show the monitoring results.
$ sudo ./damo report attrs
heatmap: 00008[...]82222222222222222222222222222222222222222222222257777789999998888888874444445[...]8
# min/max temperatures: -1,580,000,000, 100,002,000, column size: 62.841 MiB
probes
- prep: set_pgidle, filter: allow pgidle_unset (weight: 1)
- allow active (weight: 0)
intervals: sample 5 ms aggr 100 ms (max probe hits 20)
# size address age probe_hits
0 253.047 MiB 85.984 TiB 15.800 s 0 0
1 4.000 KiB 127.984 TiB 15.400 s 0 20
2 120.000 KiB 127.984 TiB 15.300 s 0 0
3 1.450 GiB 127.407 TiB 11.300 s 0 0
4 498.738 MiB 127.409 TiB 11.200 s 0 0
5 500.273 MiB 127.409 TiB 11.100 s 0 0
6 502.055 MiB 127.409 TiB 10.900 s 0 0
7 461.926 MiB 127.411 TiB 6.500 s 0 0
8 351.754 MiB 127.410 TiB 1.600 s 0 0
9 497.930 MiB 127.411 TiB 0 ns 1 0
10 8.000 KiB 127.984 TiB 0 ns 6 0
11 476.340 MiB 127.410 TiB 1 s 20 0
memory bw estimate: 0 B per second
total size: 4.909 GiB
record DAMON intervals: sample 5 ms, aggr 100 msThe second (idx 1) 4 KiB memory region is not accessed for 15 seconds and the page for the region is on an active LRU list. The last 476.340 MiB memory region is accessed for each sample for the last one second as expected. And nearly all pages of the region are not on an active LRU list.
[1] https://github.com/sjp38/masim
[2] https://github.com/damonitor/damo
Changes from RFC
- RFC: https://lore.kernel.org/[email protected]
- Add test results on the cover letter.
- Rebase to the latest mm-new.
- Drop RFC tag.
The test section and the changelog can be removed from the final commit message.
SJ Park (4):
mm/damon/api: define DAMON_FILTER_TYPE_ACTIVE mm/damon/ops-common: implement DAMON_FILTER_TYPE_ACTIVE operation mm/damon/sysfs: support LRU-activeness based DAMON filter setup Docs/mm/damon/design: update for DAMON_FILTER_TYPE_ACTIVE
Documentation/mm/damon/design.rst | 1 + include/linux/damon.h | 2 ++ mm/damon/ops-common.c | 7 +++++++ mm/damon/sysfs.c | 4 ++++ 4 files changed, 14 insertions(+)
base-commit: e055da336413b651d1e23d438bb5430f9350d3f8
Signature · 1 line
2.47.3
SJ Park
maintainerPATCH 1/4 mm/damon/api: define DAMON_FILTER_TYPE_ACTIVE
Knowing which memory is on Active LRU lists is useful for understanding and optimally operating systems. Extend the DAMON core layer to be ready for support of that. For that, define a new damon_filter_type, DAMON_FILTER_TYPE_ACTIVE. It has no additional arguments and therefore no additional change in the core layer is needed. Testing if a given memory is on an LRU list for the type of filter should be implemented in the operation set layer.
--- include/linux/damon.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/damon.h +2 -0
@@ -780,6 +780,7 @@ struct damon_prep {* @DAMON_FILTER_TYPE_PGIDLE_UNSET: Pgidle is unset. * @DAMON_FILTER_TYPE_PGIDLE_SET: Pgidle is set. * @DAMON_FILTER_TYPE_HUGEPAGE_SIZE: Page is part of a hugepage. +* @DAMON_FILTER_TYPE_ACTIVE: LRU-active pages. */ enum damon_filter_type {DAMON_FILTER_TYPE_ANON ,
@@ -787,6 +788,7 @@ enum damon_filter_type {DAMON_FILTER_TYPE_PGIDLE_UNSET ,DAMON_FILTER_TYPE_PGIDLE_SET ,DAMON_FILTER_TYPE_HUGEPAGE_SIZE , + DAMON_FILTER_TYPE_ACTIVE, };/**
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH 1/4] mm/damon/api: define DAMON_FILTER_TYPE_ACTIVE
Sashiko has reviewed this patch and found no issues.
Quoted 9 lines
Knowing which memory is on Active LRU lists is useful for understanding and optimally operating systems. Extend the DAMON core layer to be ready for support of that. For that, define a new
damon_filter_type,DAMON_FILTER_TYPE_ACTIVE. It has no additional arguments and therefore no additional change in the core layer is needed. Testing if a given memory is on an LRU list for the type of filter should be implemented in the operation set layer.Signed-off-by SJ Park <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
SJ Park
maintainerPATCH 2/4 mm/damon/ops-common: implement DAMON_FILTER_TYPE_ACTIVE operation
In reply to SJ ParkImplement DAMON_FILTER_TYPE_ACTIVE operation. Use folio_test_active() to show if the folio of the given memory is on an active LRU list. The implementation is made on ops-common, so both vaddr and paddr gain the support of the filter type.
--- mm/damon/ops-common.c | 7 +++++++ 1 file changed, 7 insertions(+)
mm/damon/ops-common.c +7 -0
@@ -574,6 +574,13 @@ bool damon_ops_filter_match(struct damon_filter *filter, struct folio *folio) matched = filter->range_min <= folio_sz && folio_sz <= filter->range_max;break ; +case DAMON_FILTER_TYPE_ACTIVE : +if (!folio) { + matched = false; +break ; + } + matched =folio_test_active (folio); +break ;default :break ; }
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH 2/4] mm/damon/ops-common: implement DAMON_FILTER_TYPE_ACTIVE operation
Sashiko has reviewed this patch and found no issues.
Quoted 6 lines
Implement
DAMON_FILTER_TYPE_ACTIVEoperation. Usefolio_test_active()to show if the folio of the given memory is on an active LRU list. The implementation is made on ops-common, so both vaddr and paddr gain the support of the filter type.Signed-off-by SJ Park <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
SJ Park
maintainerPATCH 3/4 mm/damon/sysfs: support LRU-activeness based DAMON filter setup
In reply to SJ ParkSupport DAMON sysfs interface based setup of DAMON_FILTER_TYPE_ACTIVE type DAMON filters. For that, wire the type with a new user keyword, "active". Users can set up the new type of filter using the existing DAMON filter setup interface with the new keyword.
--- mm/damon/sysfs.c | 4 ++++ 1 file changed, 4 insertions(+)
mm/damon/sysfs.c +4 -0
@@ -1011,6 +1011,10 @@ damon_sysfs_filter_type_names[] = { .type = DAMON_FILTER_TYPE_HUGEPAGE_SIZE, .name = "hugepage_size", }, + { + .type = DAMON_FILTER_TYPE_ACTIVE, + .name = "active", + }, }; static ssize_t type_show(struct kobject *kobj,
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH 3/4] mm/damon/sysfs: support LRU-activeness based DAMON filter setup
Sashiko has reviewed this patch and found no issues.
Quoted 6 lines
Support DAMON sysfs interface based setup of
DAMON_FILTER_TYPE_ACTIVEtype DAMON filters. For that, wire the type with a new user keyword, "active". Users can set up the new type of filter using the existing DAMON filter setup interface with the new keyword.Signed-off-by SJ Park <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
SJ Park
maintainerPATCH 4/4 Docs/mm/damon/design: update for DAMON_FILTER_TYPE_ACTIVE
In reply to SJ ParkUpdate DAMON design document for the newly added LRU-activeness DAMON filter type.
--- Documentation/mm/damon/design.rst | 1 + 1 file changed, 1 insertion(+)
Documentation/mm/damon/design.rst +1 -0
@@ -302,6 +302,7 @@ filter types. Currently below filter types are supported. - ``pgidle_set``: Matches if the page for the memory is marked as access-idle. - ``hugepage_size``: Matches if the page for the memory is a part of a hugepage of a given size range. +- ``active``: Same to that for DAMOS filters. If such probes are registered, DAMON executes the probes for each region's sampling memory when it does the access :ref:`sampling
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH 4/4] Docs/mm/damon/design: update for DAMON_FILTER_TYPE_ACTIVE
Sashiko has reviewed this patch and found no issues.
Quoted 4 lines
Update DAMON design document for the newly added LRU-activeness DAMON filter type.
Signed-off-by SJ Park <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
Re: [PATCH 4/4] Docs/mm/damon/design: update for DAMON_FILTER_TYPE_ACTIVE
In reply to SJ ParkHi SJ,
Quoted 13 lines · SJ Park
Update DAMON design document for the newly added LRU-activeness DAMON filter type.
Signed-off-by SJ Park <[email protected]>--- Documentation/mm/damon/design.rst | 1 + 1 file changed, 1 insertion(+)Documentation/mm/damon/design.rst +0
-0
Documentation/mm/damon/design.rst filter types. Currently below filter types are supported. · line 305
Quoted 4 lines
Documentation/mm/damon/design.rst +1
-0@@ -302,6 +302,7 @@ filter types. Currently below filter types are supported. - ``pgidle_set``: Matches if the page for the memory is marked as access-idle. - ``hugepage_size``: Matches if the page for the memory is a part of a hugepage of a given size range. +- ``active``: Same to that for DAMOS filters.
This reads a bit awkward to me. How about:
"Same as that for DAMOS filters."
The ``anon`` and ``memcg`` entries above use the same wording, so it would be nice to fix those at the same time.
WDYT?
Thanks,
Enze
Quoted 3 lines
Documentation/mm/damon/design.rst +0
-0If such probes are registered, DAMON executes the probes for each region's sampling memory when it does the access :ref:`sampling
SJ Park
maintainerRe: [PATCH 4/4] Docs/mm/damon/design: update for DAMON_FILTER_TYPE_ACTIVE
Quoted 23 lines · On Fri, 13 Nov 2026 17:54:37 +0800 Enze Li <[email protected]> wrote:
Hi SJ,
Quoted 13 lines · SJ Park
Update DAMON design document for the newly added LRU-activeness DAMON filter type.
Signed-off-by SJ Park <[email protected]>--- Documentation/mm/damon/design.rst | 1 + 1 file changed, 1 insertion(+)Documentation/mm/damon/design.rst +0
-0Documentation/mm/damon/design.rst filter types. Currently below filter types are supported. · line 305
Quoted 4 lines
Documentation/mm/damon/design.rst +1
-0@@ -302,6 +302,7 @@ filter types. Currently below filter types are supported. - ``pgidle_set``: Matches if the page for the memory is marked as access-idle. - ``hugepage_size``: Matches if the page for the memory is a part of a hugepage of a given size range. +- ``active``: Same to that for DAMOS filters.This reads a bit awkward to me. How about:
Quoted 6 lines
"Same as that for DAMOS filters."
The ``anon`` and ``memcg`` entries above use the same wording, so it would be nice to fix those at the same time.
WDYT?
Makes sense to me, thank you for sharing the finding, Enze! I also find more "same to" usages in the doc. Would you like to send a patch for fixing those at once?
Thanks,
SJ
[...]
Re: [PATCH 4/4] Docs/mm/damon/design: update for DAMON_FILTER_TYPE_ACTIVE
Quoted 27 lines · SJ Park
Quoted 25 lines · On Fri, 13 Nov 2026 17:54:37 +0800 Enze Li <[email protected]> wrote:
Hi SJ,
Quoted 13 lines · SJ Park
Update DAMON design document for the newly added LRU-activeness DAMON filter type.
Signed-off-by SJ Park <[email protected]>--- Documentation/mm/damon/design.rst | 1 + 1 file changed, 1 insertion(+)Documentation/mm/damon/design.rst +0
-0Documentation/mm/damon/design.rst filter types. Currently below filter types are supported. · line 305
Quoted 4 lines
Documentation/mm/damon/design.rst +1
-0@@ -302,6 +302,7 @@ filter types. Currently below filter types are supported. - ``pgidle_set``: Matches if the page for the memory is marked as access-idle. - ``hugepage_size``: Matches if the page for the memory is a part of a hugepage of a given size range. +- ``active``: Same to that for DAMOS filters.This reads a bit awkward to me. How about:
"Same as that for DAMOS filters."
Quoted 8 lines
Quoted 4 lines
The ``anon`` and ``memcg`` entries above use the same wording, so it would be nice to fix those at the same time.
WDYT?
Makes sense to me, thank you for sharing the finding, Enze! I also find more "same to" usages in the doc. Would you like to send a patch for fixing those at once?
Sure, I'd be happy to. I'll send a follow-up patch fixing all six "same to" usages in design.rst, on top of mm-new.
Best regards,
Enze
<...>