perf coverage: A harness for perf, and the fixes it found
Arnaldo Carvalho de Melo
maintainercover perf coverage: A harness for perf, and the fixes it found
From: Arnaldo Carvalho de Melo <[email protected]>
Hi,
Please consider merging,
Nothing measured how much of perf the test suite reaches. Patch 1 adds tools/perf/scripts/coverage.sh: it builds perf with clang source based coverage, runs the complete perf test suite and reports line and function coverage, optionally against a baseline, with --table and --html like pahole's coverage_table.py. Also as 'make -C tools/perf coverage', 'coverage-prep' and 'coverage-table'.
The rest is what the first runs found, in the code, the build and the tests:
- clang DWARF 5 describes globals with DW_OP_addrx, which was not resolved (patch 2).
- The flexible array member had no test; one showed the struct row at
0.00% while the member said 100.00% (patches 3-4).
- A struct pointer that -O2 keeps in a register was not resolved from
its DWARF location (patch 5).
- --insn-stat was printed before the loop that accounts the samples,
so --code-with-type showed zeros (patch 6).
- The libbfd probe printed a missing bfd.h error five times per
build-test run (patch 7).
- FEATURE-DUMP didn't record llvm-perf and rust, disabling both in the
build-test builds (patch 8).
- GCC 16 caught an uninitialized T32 instruction buffer read in cs-etm
(patch 9). - The Intel PT virtual LBR check lost every aux sample with a single data page (patch 10).
- The dlfilter test kept samples whose IP the kernel now zeroes on a userspace-to-kernel skid (patch 11).
- The LBR inline unwinding check failed instead of skipping when the AMD PMU rejects branch sampling (patch 12).
In a root run on this box the suite covered 49.16% of perf's 201,180 lines; three tests failed in code this series does not change (the POLL_HUP tracepoint regression, the AMD BRS branch sampling rejection and the lock contention count).
The harness and the tests were developed with an AI coding assistant (OpenCode), which drafted the script and the tests and helped debug the failures; I reviewed every change and reproduced each failure before fixing it.
Best regards,
- Arnaldo
Arnaldo Carvalho de Melo (12):
perf scripts: Add a coverage harness for perf
perf annotate-data: Resolve DW_OP_addrx global variables perf tests: Exercise the flexible array member path
perf annotate-data: Count flexible array accesses for the whole struct perf tests: Exercise data type resolution from a register perf annotate: Print the stats after the annotations
perf tests: Silence the libbfd probe in build-test
perf build: Record the display-only features in FEATURE-DUMP perf cs-etm: Fall back to the recorded instruction size on a failed read perf tests: Fix the Intel PT virtual LBR check
perf test: Drop samples without an IP in the dlfilter test perf test: Skip the LBR inline unwinding check when unsupported
tools/perf/.gitignore | 1 + tools/perf/Makefile | 11 +- tools/perf/Makefile.config | 4 + tools/perf/Makefile.perf | 4 + tools/perf/builtin-annotate.c | 10 +- tools/perf/scripts/coverage.sh | 703 ++++++++++++++++++ tools/perf/tests/make | 2 +- tools/perf/tests/shell/addr2line_inlines.sh | 9 +- tools/perf/tests/shell/annotate_stats.sh | 58 ++ .../perf/tests/shell/data_type_flex_array.sh | 142 ++++ .../tests/shell/data_type_profiling_clang.sh | 108 +++ tools/perf/tests/shell/data_type_register.sh | 120 +++ tools/perf/tests/shell/script_dlfilter.sh | 2 +- tools/perf/tests/shell/test_intel_pt.sh | 9 +- tools/perf/util/annotate-data.c | 24 +- tools/perf/util/cs-etm.c | 7 +- tools/perf/util/dwarf-aux.c | 42 +- 17 files changed, 1234 insertions(+), 22 deletions(-) create mode 100755 tools/perf/scripts/coverage.sh create mode 100755 tools/perf/tests/shell/annotate_stats.sh create mode 100755 tools/perf/tests/shell/data_type_flex_array.sh create mode 100755 tools/perf/tests/shell/data_type_profiling_clang.sh create mode 100755 tools/perf/tests/shell/data_type_register.sh
base-commit: cc905a18a647a8e3ad42cd1596baa0e08fba26eb
Signature · 1 line
2.56.0
Arnaldo Carvalho de Melo
maintainerPATCH 1/12 perf scripts: Add a coverage harness for perf
From: Arnaldo Carvalho de Melo <[email protected]>
Build perf with clang source based coverage, run the complete perf test suite, merge the raw profiles and report line and function coverage for perf, optionally against a baseline. This is pahole's coverage/coverage.sh + coverage-diff.sh merged into one script, wired as 'make -C tools/perf coverage' and listed in 'make help'.
Without -f the report lists the files with the most uncovered lines, which is where new tests should try to get more coverage; -t narrows the tests, -f focuses on specific files, --html writes a browsable report and --table/-T, also available as 'make -C tools/perf coverage-table', prints the last run as an ASCII table with the per-file line and function coverage, like pahole's coverage_table.py.
The build can be split from the test run: 'make -C tools/perf coverage-prep' builds the instrumented perf and records the build directory, and a later run as root, which needs no make, checks that build, runs the tests and renders the report, or prints the table with --table. This is for running the tests that need root on the bare metal host while the instrumented perf is built in the development container.
It is a maintainer tool and it already paid for itself: the first run found the clang DWARF 5 data type test failing (the DW_OP_addrx gap, fixed by the next patch), and the uncovered line list is what drove the tests in the rest of the series.
$ scripts/coverage.sh ... Total: 67436 of 201128 lines covered (33.53%)
largest uncovered files (>= 100 lines)
file lines cover missed fn-cover
builtin-trace.c 3657 4.24% 3502 0.51%
util/intel-pt.c 3237 0.00% 3237 0.00%
util/intel-pt-decoder/intel-pt-decoder.c 3208 0.00% 3208 0.00%
builtin-sched.c 3737 19.72% 3000 11.35%
ui/browsers/hists.c 2730 0.00% 2730 0.00%
util/probe-event.c 2765 5.39% 2616 10.68%
builtin-script.c 3212 29.98% 2249 33.06%
... Report: /tmp/build/perf-coverage/cov/report.txt
The run above was unprivileged, so tests that need root are skipped or fail; the report still points at the gaps.
--- tools/perf/.gitignore | 1 + tools/perf/Makefile | 11 +- tools/perf/Makefile.perf | 4 + tools/perf/scripts/coverage.sh | 703 +++++++++++++++++++++++++++++++++ 4 files changed, 718 insertions(+), 1 deletion(-) create mode 100755 tools/perf/scripts/coverage.sh
tools/perf/.gitignore +1 -0
@@ -27,6 +27,7 @@ stats-*.csv cscope* config.mak config.mak.autogen +.coverage-build-dir *-bison.* *-flex.* *.pyc
tools/perf/Makefile +10 -1
@@ -140,6 +140,15 @@ check-headers: sync-headers: @./scripts/sync-headers.sh $(SYNC_HEADERS_ARGS) +coverage-prep: + @./scripts/coverage.sh --prep $(if $(O),--build-dir=$(O)) $(COVERAGE_ARGS) + +coverage: + @./scripts/coverage.sh $(COVERAGE_ARGS) + +coverage-table: + @./scripts/coverage.sh --table $(COVERAGE_ARGS) + # # All other targets get passed through: #
@@ -147,4 +156,4 @@ sync-headers: $(print_msg) $(make) -.PHONY: all clean tags TAGS FORCE Makefile build-test build-test-tarball check-headers sync-headers +.PHONY: all clean tags TAGS FORCE Makefile build-test build-test-tarball check-headers sync-headers coverage coverage-prep coverage-table
tools/perf/Makefile.perf +4 -0
@@ -873,6 +873,10 @@ help: @echo ' check-headers - check which header copies are out of sync with the kernel' @echo ' sync-headers - sync those header copies with the kernel, creating commits' @echo ' (SYNC_HEADERS_ARGS="..." passes options to the script)' + @echo ' coverage-prep - build perf with clang coverage, ready for a root test run' + @echo ' coverage - build perf with clang coverage, run the tests and report' + @echo ' coverage-table - print an ASCII table of the last coverage run' + @echo ' (COVERAGE_ARGS="..." passes options to the script)' DOC_TARGETS := doc man html info pdf
tools/perf/scripts/coverage.sh new file +703 -0
703 lines not on this page · raw message
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 01/12] perf scripts: Add a coverage harness for perf
Thank you for your contribution! Sashiko AI review found 6 potential issues to consider: - [Low] perf scripts: llvm_cov_objects() looks for perf.so in wrong directory - [Low] perf scripts: misplaced…
Thank you for your contribution! Sashiko AI review found 6 potential issues to consider:
- [Low] perf scripts: llvm_cov_objects() looks for perf.so in wrong directory
- [Low] perf scripts: misplaced delta header and bad alignment in print_summary()
- [Low] perf scripts: print_uncovered() fails to strip tools/perf/ path prefix
- [Low] perf build: inconsistent O= handling in Makefile coverage targets
- [Low] perf scripts: locale-sensitive float handling in print_table()
- [Low] perf scripts: print_worst_files() checks total lines instead of missed
--
commit e4ee2d1add56afe4f156fafd475dce263c39b01d
Author: Arnaldo Carvalho de Melo <[email protected]>
perf scripts: Add a coverage harness for perf
This commit adds tools/perf/scripts/coverage.sh and corresponding make targets to build perf with clang source-based coverage, run the perf test suite, and generate line and function coverage reports and ASCII tables.
Quoted 6 lines
tools/perf/Makefile +0
-0@@ -140,6 +140,15 @@ check-headers: sync-headers:
tools/perf/Makefile check-headers: · line 150
Quoted 10 lines
tools/perf/Makefile +8
-0@./scripts/sync-headers.sh $(SYNC_HEADERS_ARGS) +coverage-prep: + @./scripts/coverage.sh --prep $(if $(O),--build-dir=$(O)) $(COVERAGE_ARGS) + +coverage: + @./scripts/coverage.sh $(COVERAGE_ARGS) + +coverage-table: + @./scripts/coverage.sh --table $(COVERAGE_ARGS)
[Severity: Low]
Should coverage and coverage-table also pass --build-dir, and should all three targets use $(FULL_O) instead of $(O)?
Without --build-dir, running make -C tools/perf O=/path/to/build coverage (or coverage-table) ignores O= and falls back to the default build directory. In addition, passing raw $(O) to coverage.sh resolves relative paths against tools/perf rather than the caller's working directory, whereas $(FULL_O) canonicalizes $(O) against $(PWD).
[ ... ]
Quoted 5 lines
tools/perf/scripts/coverage.sh new file +0
-0
[ ... ]
tools/perf/scripts/coverage.sh line 336
Quoted 8 lines
tools/perf/scripts/coverage.sh new file +8
-0+llvm_cov_objects() +{ + echo "$BUILD_DIR/perf" + local so + for so in perf.so libperf.so libperf-jvmti.so; do + [ -f "$BUILD_DIR/$so" ] && echo "--object=$BUILD_DIR/$so" + done +}
[Severity: Low]
Does this miss the Python C extension object? Makefile.perf builds the extension with PYTHON_EXTENSION_SUFFIX (for example, perf.cpython-312-x86_64-linux-gnu.so) and copies it into $(OUTPUT)python/, so $BUILD_DIR/perf.so does not exist and coverage for util/python.c is omitted from the reports. Matching $BUILD_DIR/python/perf*.so would include it.
[ ... ]
tools/perf/scripts/coverage.sh line 425
Quoted 10 lines
tools/perf/scripts/coverage.sh new file +10
-0+print_worst_files() +{ + [ "$TOP" -gt 0 ] || return 0 + local rows missed lines cover fn path + rows=$(awk -v min="$MIN_LINES" ' + $1 ~ /(^|\/)tools\/perf\// && $8 >= min && $8 > 0 { + path = $1 + sub(/^.*tools\/perf\//, "", path) + printf "%s %s %s %s %s\n", $9, $8, $10, $7, path + }' "$REPORT" | sort -k1,1nr -k2,2nr | sed -n "1,${TOP}p")
[Severity: Low]
Should the second awk check be $9 > 0 (missed lines) instead of $8 > 0 (total lines), matching table_rows()? Checking $8 > 0 is redundant with $8 >= min and allows files with 0 missed lines to be listed under largest uncovered files.
[ ... ]
Quoted 17 lines
tools/perf/scripts/coverage.sh new file +17
-0+ if [ "$USE_BASELINE" = 1 ] && [ -f "$BASELINE" ]; then + printf " %-8s %8s %8s %9s\n" "File" "Previous" "Current" "Delta" + printf " %-8s %8s %8s %9s\n" "--------" "--------" "--------" "---------" + fi + + printf " \033[1m%-44s\033[0m %8s %8s %8s %8s\n" \ + "file" "lines" "cover" "missed" "fn-cover" + for file in "${FOCUS[@]}"; do + cov=$(file_cov "$REPORT" "$file") + if [ -z "$cov" ]; then + printf " %-36s %8s\n" "$file" "not covered" + continue + fi + printf " %-36s %8s %6s %6s %8s\n" "$file" \ + "$(echo "$cov" | awk '{print $1}')" \ + "$(echo "$cov" | awk '{print $3}')" \ + "$(echo "$cov" | awk '{print $2}')" \
tools/perf/scripts/coverage.sh line 481
Quoted 10 lines
tools/perf/scripts/coverage.sh new file +10
-0+ "$(echo "$cov" | awk '{print $4}')" + done + + if [ "$USE_BASELINE" = 1 ] && [ -f "$BASELINE" ]; then + printf "\n per file delta since %s\n" "$BASELINE" + for file in "${FOCUS[@]}"; do + report_delta "$BASELINE" "$REPORT" "$file" + done + fi +}
[Severity: Low]
Are the baseline delta header and row widths in print_summary() misaligned when -f is used?
The 4-column "File Previous Current Delta" header is printed right above the 5-column focus table instead of in the "per file delta since $BASELINE" block below where report_delta() is called. In the 5-column focus table itself, the header uses "%-44s %8s %8s %8s %8s", while the rows use "%-36s %8s %6s %6s %8s", shifting the numeric columns out of alignment.
Also, because update_baseline() copies $REPORT to $BASELINE at the end of a run (moving the prior baseline to $BASELINE.prev), a subsequent --report-only run compares $REPORT against $BASELINE (itself) and always reports a +0.00% delta.
[ ... ]
Quoted 28 lines
tools/perf/scripts/coverage.sh new file +28
-0+table_rows() +{ + if [ ${#FOCUS[@]} -gt 0 ]; then + local file + for file in "${FOCUS[@]}"; do + table_row "$REPORT" "$file" + done | sort -t$'\t' -k5,5gr + return + fi + + awk -v min="$MIN_LINES" ' + $1 ~ /(^|\/)tools\/perf\// && $8 >= min && $9 > 0 { + path = $1 + sub(/^.*tools\/perf\//, "", path) + printf "%s\t%s\t%d\t%d\t%.2f\t%s\t%d\t%s\n", + path, $8, $8 - $9, $9, $10, $5, $5 - $6, $7 + }' "$REPORT" | + sort -t$'\t' -k4,4nr | + if [ "$TOP" -gt 0 ]; then sed -n "1,${TOP}p"; else cat; fi | + sort -t$'\t' -k5,5gr +} + +print_table() +{ + local rows total path lines hit missed pct funcs funcs_hit func_cov + local row_fmt w d_file d29 d13 d10 d8 + + rows=$(table_rows)
[ ... ]
tools/perf/scripts/coverage.sh line 594
Quoted 7 lines
tools/perf/scripts/coverage.sh new file +7
-0+ row_fmt=$(printf '│ %%-%ds │ %%6s │ %%6s │ %%6s │ %%s %%5.1f%%%%' "$w") + row_fmt+=' │ %5s/%-5s │ %8s │\n' + + while IFS=$'\t' read -r path lines hit missed pct funcs funcs_hit func_cov; do + printf "$row_fmt" "$path" "$lines" "$hit" "$missed" \ + "$(bar "$pct" 20)" "$pct" "$funcs_hit" "$funcs" "$func_cov" + done <<< "$rows"
[Severity: Low]
Does --table fail under locales where LC_NUMERIC uses a comma decimal separator (for example, de_DE.UTF-8 or pt_BR.UTF-8)?
awk emits dot-separated floats in $pct (such as "33.53"), which sort -g and bash's built-in printf "%5.1f" then parse according to LC_NUMERIC. When LC_NUMERIC expects a comma, printf rejects $pct as an invalid number and exits with status 1, aborting the script under set -e. Exporting LC_ALL=C or LC_NUMERIC=C at the top of the script would avoid this.
[ ... ]
tools/perf/scripts/coverage.sh line 618
Quoted 13 lines
tools/perf/scripts/coverage.sh new file +13
-0+print_uncovered() +{ + [ "$UNCOVERED" -gt 0 ] || return 0 + [ ${#FOCUS[@]} -gt 0 ] || return 0 + local objects file out lines header=0 + mapfile -t objects < <(llvm_cov_objects) + + for file in "${FOCUS[@]}"; do + # No report row means the file was not built: print_summary() + # already said so, llvm-cov show would dump the whole profile. + [ -n "$(file_cov "$REPORT" "$file")" ] || continue + out=$("$LLVM_COV" show "${objects[@]}" --instr-profile="$PROFDATA" \ + "$PERF_DIR/$file" 2>/dev/null |
[Severity: Low]
Should print_uncovered() strip a leading .*tools/perf/ prefix from $file before prepending $PERF_DIR/?
file_cov() and table_row() both strip ^.*tools/perf/ so that paths like -f tools/perf/util/evsel.c work, but passing "$PERF_DIR/$file" directly to llvm-cov show produces "$PERF_DIR/tools/perf/util/evsel.c" and fails to find the source file.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Arnaldo Carvalho de Melo
maintainerPATCH 2/12 perf annotate-data: Resolve DW_OP_addrx global variables
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
clang emits DW_AT_location with DW_OP_addrx for global variables in DWARF 5, gcc emits DW_OP_addr. The address index was not resolved, so those variables were not found by address; the by-name fallback also missed the ones in .bss past the file backed end of the last segment.
Resolve the index with dwarf_getlocation_attr() + dwarf_formaddr() and use the resulting address in the by-address lookup and in the global variable cache. Add a test that compiles the workload with clang -gdwarf-5 and checks that the global is annotated.
--- .../tests/shell/data_type_profiling_clang.sh | 108 ++++++++++++++++++ tools/perf/util/dwarf-aux.c | 42 ++++++- 2 files changed, 145 insertions(+), 5 deletions(-) create mode 100755 tools/perf/tests/shell/data_type_profiling_clang.sh
tools/perf/tests/shell/data_type_profiling_clang.sh new file +108 -0
@@ -0,0 +1,108 @@ +#!/bin/bash +# perf data type profiling tests with clang DWARF 5 +# SPDX-License-Identifier: GPL-2.0 + +set -e + +# clang describes the location of globals with DW_OP_addrx where gcc +# uses DW_OP_addr, so the workload has to be built here to get that +# encoding. + +command -v clang > /dev/null || exit 2 + +perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) +perfout=$(mktemp /tmp/__perf_test.perf.out.XXXXX) +prog=$(mktemp /tmp/__perf_test.clang.XXXXX) +src="${prog}.c" + +cleanup() +{ + rm -f "$perfdata" "$perfout" "$prog" "$src" + trap - EXIT TERM INT +} + +trap_cleanup() +{ + echo "Unexpected signal in ${FUNCNAME[1]}" + cleanup + exit 1 +} +trap trap_cleanup EXIT TERM INT + +# No point in recording if the PMU cannot do memory events. +if perf mem record -o /dev/null -- true 2>&1 | \ + grep -q "failed: no PMU supports the memory events"; then + cleanup + exit 2 +fi +if ! perf mem record -o /dev/null -- true 2>/dev/null; then + echo "Skip: cannot record memory events on this PMU" + cleanup + exit 2 +fi + +cat > "$src" <<'EOF' +#include <signal.h> +#include <unistd.h> + +struct conn { + int saddr; + int daddr; + long bytes; +}; + +static volatile struct conn conn; +static volatile sig_atomic_t done; + +static void stop(int sig) +{ + done = 1; +} + +int main(void) +{ + unsigned long sum = 0; + int i = 0; + + signal(SIGALRM, stop); + alarm(1); + + while (!done) { + conn.saddr = i; + conn.daddr = i + 1; + sum += conn.bytes; + i++; + } + return sum != 0; +} +EOF + +# -fPIE keeps the accesses PC-relative on x86_64, the operand form the +# data type resolver handles. +if ! clang -O0 -gdwarf-5 -fPIE -pie -o "$prog" "$src"; then + echo "Skip: cannot build the workload with clang" + cleanup + exit 2 +fi + +if ! perf mem record -o "$perfdata" -- "$prog" > /dev/null 2>&1; then + echo "FAIL: perf mem record" + cleanup + exit 1 +fi + +if ! perf annotate --code-with-type -i "$perfdata" --stdio \ + --percent-limit 1 > "$perfout" 2>/dev/null; then + echo "FAIL: perf annotate" + cleanup + exit 1 +fi + +if ! grep -q "# data-type: struct conn" "$perfout"; then + echo "FAIL: struct conn not resolved, DW_OP_addrx not handled?" + cleanup + exit 1 +fi + +echo "DW_OP_addrx global resolved" +cleanup
tools/perf/util/dwarf-aux.c +37 -5
81 lines not on this page · raw message
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 02/12] perf annotate-data: Resolve DW_OP_addrx global variables
Sashiko has reviewed this patch and found no issues.
Quoted 12 lines
From: Arnaldo Carvalho de Melo <[email protected]>
clang emits
DW_AT_locationwithDW_OP_addrxfor global variables in DWARF 5, gcc emitsDW_OP_addr. The address index was not resolved, so those variables were not found by address; the by-name fallback also missed the ones in .bss past the file backed end of the last segment.Resolve the index with
dwarf_getlocation_attr()+dwarf_formaddr()and use the resulting address in the by-address lookup and in the global variable cache. Add a test that compiles the workload with clang -gdwarf-5 and checks that the global is annotated.
Quoted 4 lines
Fixes d60469d7c0e5c4e8 ("perf dwarf-aux: Add die_find_variable_by_addr()")Fixes d7b60803a790b716 ("perf dwarf-aux: Add die_collect_global_vars()")Cc Namhyung Kim <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
Arnaldo Carvalho de Melo
maintainerPATCH 3/12 perf tests: Exercise the flexible array member path
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
No test covered find_flex_array() and get_flex_array_member(). Add one that keeps a struct with a trailing data[] behind a global pointer and checks that accesses past the struct size are resolved and named after the flexible array member.
--- .../perf/tests/shell/data_type_flex_array.sh | 104 ++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100755 tools/perf/tests/shell/data_type_flex_array.sh
tools/perf/tests/shell/data_type_flex_array.sh new file +104 -0
@@ -0,0 +1,104 @@ +#!/bin/bash +# perf data type profiling tests for flexible array members +# SPDX-License-Identifier: GPL-2.0 + +set -e + +perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) +perfout=$(mktemp /tmp/__perf_test.perf.out.XXXXX) +prog=$(mktemp /tmp/__perf_test.flex.XXXXX) +src="${prog}.c" + +cleanup() +{ + rm -f "$perfdata" "$perfout" "$prog" "$src" + trap - EXIT TERM INT +} + +trap_cleanup() +{ + echo "Unexpected signal in ${FUNCNAME[1]}" + cleanup + exit 1 +} +trap trap_cleanup EXIT TERM INT + +# No point in recording if the PMU cannot do memory events. +if perf mem record -o /dev/null -- true 2>&1 | \ + grep -q "failed: no PMU supports the memory events"; then + cleanup + exit 2 +fi +if ! perf mem record -o /dev/null -- true 2>/dev/null; then + echo "Skip: cannot record memory events on this PMU" + cleanup + exit 2 +fi + +cat > "$src" <<'EOF' +#include <signal.h> +#include <stdlib.h> +#include <unistd.h> + +struct flex { + int len; + char data[]; +}; + +static struct flex *gp; +static volatile sig_atomic_t done; + +static void stop(int sig) +{ + done = 1; +} + +int main(void) +{ + unsigned long sum = 0; + + gp = calloc(1, sizeof(*gp) + 4096); + if (gp == NULL) + return 1; + gp->len = 4096; + + signal(SIGALRM, stop); + alarm(1); + + while (!done) { + sum += gp->data[3]; + gp->data[5] = 1; + } + return sum != 0; +} +EOF + +# -fPIE keeps the global pointer load PC-relative on x86_64, so the +# resolver can tell the register holds a struct flex pointer. +if ! cc -O0 -g -fPIE -pie -o "$prog" "$src" 2>/dev/null; then + echo "Skip: cannot build the workload" + cleanup + exit 2 +fi + +if ! perf mem record -o "$perfdata" -- "$prog" > /dev/null 2>&1; then + echo "FAIL: perf mem record" + cleanup + exit 1 +fi + +if ! perf annotate --code-with-type -i "$perfdata" --stdio \ + --percent-limit 1 > "$perfout" 2>/dev/null; then + echo "FAIL: perf annotate" + cleanup + exit 1 +fi + +if ! grep -Fq "# data-type: struct flex +0x4 (data)" "$perfout"; then + echo "FAIL: flexible array member not resolved" + cleanup + exit 1 +fi + +echo "flexible array member resolved" +cleanup
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 03/12] perf tests: Exercise the flexible array member path
Sashiko has reviewed this patch and found no issues.
Quoted 8 lines
From: Arnaldo Carvalho de Melo <[email protected]>
No test covered
find_flex_array()andget_flex_array_member(). Add one that keeps a struct with a trailing data[] behind a global pointer and checks that accesses past the struct size are resolved and named after the flexible array member.Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
Arnaldo Carvalho de Melo
maintainerPATCH 4/12 perf annotate-data: Count flexible array accesses for the whole struct
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
The per-member percentage sums the histogram entries in the member's own [offset, offset + size) range. A flexible array member is resolved past the end of its struct, so the struct row only covered its declared size and showed 0.00% while the member row showed 100.00% and the header said N samples.
Take a member's extent as the end of its last child as well, so the struct counts what was resolved past it. Union members all start at offset 0, so a plain union keeps its size; a member that is itself a struct with a flexible array extends the union too.
Extend tests/shell/data_type_flex_array.sh to check that the accesses count for the struct in the percent, samples and period columns.
--- .../perf/tests/shell/data_type_flex_array.sh | 40 ++++++++++++++++++- tools/perf/util/annotate-data.c | 24 ++++++++++- 2 files changed, 61 insertions(+), 3 deletions(-)
tools/perf/tests/shell/data_type_flex_array.sh +39 -1
@@ -100,5 +100,43 @@ if ! grep -Fq "# data-type: struct flex +0x4 (data)" "$perfout"; then exit 1 fi -echo "flexible array member resolved" +# The accesses to the flexible array are resolved past the end of the +# struct: they must count for the struct, not only for the member. +if ! perf annotate --data-type -i "$perfdata" --stdio > "$perfout" 2>/dev/null; then + echo "FAIL: perf annotate --data-type" + cleanup + exit 1 +fi + +if ! awk ' + $1 + 0 == 100.00 && /struct flex/ { struct_ok = 1 } + $1 + 0 == 100.00 && /char\[\]/ && /data;/ { data_ok = 1 } + $1 + 0 == 0.00 && /int/ && /len;/ { len_ok = 1 } + END { exit !(struct_ok && data_ok && len_ok) } +' <(sed -n "/^Annotate type: 'struct flex' in/,/^Annotate type: /p" "$perfout"); then + echo "FAIL: --data-type does not count the flexible array accesses" + cleanup + exit 1 +fi + +# Same with the samples and period columns, the other two display modes. +for mode in --show-nr-samples --show-total-period; do + if ! perf annotate --data-type -i "$perfdata" --stdio "$mode" > "$perfout" 2>/dev/null; then + echo "FAIL: perf annotate --data-type $mode" + cleanup + exit 1 + fi + + if ! awk ' + $1 + 0 > 0 && /struct flex/ { total = $1 + 0 } + /char\[\]/ && /data;/ { data = $1 + 0 } + END { exit !(total > 0 && total == data) } + ' <(sed -n "/^Annotate type: 'struct flex' in/,/^Annotate type: /p" "$perfout"); then + echo "FAIL: --data-type $mode does not count the flexible array accesses" + cleanup + exit 1 + fi +done + +echo "flexible array member resolved and counted" cleanup
tools/perf/util/annotate-data.c +22 -2
@@ -2233,6 +2233,25 @@ static void print_annotated_data_value(struct type_hist *h, u64 period, int nr_scolor_fprintf (stdout, color," %7.2f" , percent); } +/* +* A flexible array member is resolved past the end of its parent, so the +* parent's samples are not bounded by its size. +*/ +static int member_extent (struct annotated_member *member) +{ +struct annotated_member *child; +int end = member->offset + member->size; + +list_for_each_entry (child, &member->children, node) { +int child_end =member_extent (child); + +if (child_end > end) + end = child_end; + } + +return end; +} +static void print_annotated_data_type (struct annotated_data_type *mem_type,struct annotated_member *member,struct evsel *evsel,int indent)
@@ -2240,6 +2259,7 @@ static void print_annotated_data_type(struct annotated_data_type *mem_type,struct annotated_member *child;struct type_hist *h;int i, nr_events =0 , samples =0 ; +int end =member_extent (member);u64 period =0 ;int width = symbol_conf.show_total_period ?11 :7 ;struct evsel *pos;
@@ -2253,10 +2273,10 @@ static void print_annotated_data_type(struct annotated_data_type *mem_type, samples =0 ; period =0 ; -for (i =0 ; i < member->size; i++) { +for (i = member->offset; i < end; i++) {struct type_hist_entry *entry; -if (!hashmap__find (&h->samples, member->offset + i, &entry)) +if (!hashmap__find (&h->samples, i, &entry))continue ; samples += entry->nr_samples;
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 04/12] perf annotate-data: Count flexible array accesses for the whole struct
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] perf annotate-data: missing member_extent() use in TUI get_member_overhead() --
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Low] perf annotate-data: missing member_extent() use in TUI get_member_overhead()
--
commit db1590c6b9cdacf042578dbb6359cc6b78b628eb
Author: Arnaldo Carvalho de Melo <[email protected]>
perf annotate-data: Count flexible array accesses for the whole struct
This commit introduces member_extent() to extend a struct or union member's sample range to the end of its last child so flexible array accesses count toward the enclosing type in print_annotated_data_type().
Quoted 41 lines
tools/perf/util/annotate-data.c +20
-0@@ -2233,6 +2233,25 @@ static void print_annotated_data_value(struct type_hist *h, u64 period, int nr_scolor_fprintf (stdout, color," %7.2f" , percent); } +/* +* A flexible array member is resolved past the end of its parent, so the +* parent's samples are not bounded by its size. +*/ +static int member_extent (struct annotated_member *member) +{ +struct annotated_member *child; +int end = member->offset + member->size; + +list_for_each_entry (child, &member->children, node) { +int child_end =member_extent (child); + +if (child_end > end) + end = child_end; + } + +return end; +} +static void print_annotated_data_type (struct annotated_data_type *mem_type,struct annotated_member *member,struct evsel *evsel,int indent)@@ -2240,6 +2259,7 @@ static void print_annotated_data_type(struct annotated_data_type *mem_type,struct annotated_member *child;struct type_hist *h;int i, nr_events =0 , samples =0 ; +int end =member_extent (member);u64 period =0 ;int width = symbol_conf.show_total_period ?11 :7 ;struct evsel *pos;@@ -2253,10 +2273,10 @@ static void print_annotated_data_type(struct annotated_data_type *mem_type, samples =0 ;
tools/perf/util/annotate-data.c static void print_annotated_data_type(struct annotated_data_type *mem_type, · line 2282
Quoted 10 lines
tools/perf/util/annotate-data.c +2
-2period =0 ; -for (i =0 ; i < member->size; i++) { +for (i = member->offset; i < end; i++) {struct type_hist_entry *entry; -if (!hashmap__find (&h->samples, member->offset + i, &entry)) +if (!hashmap__find (&h->samples, i, &entry))continue ; samples += entry->nr_samples;
[Severity: Low]
Should get_member_overhead() in the TUI data-type browser also use member_extent()?
tools/perf/ui/browsers/annotate-data.c:get_member_overhead() {
struct annotated_member *member = entry->data;
int i, k;
for (i = 0; i < member->size; i++) {
struct type_hist *h;
struct evsel *evsel;
int offset = member->offset + i;
...
}Because get_member_overhead() still iterates only up to member->size, inspecting a struct with flexible array accesses in the TUI browser continues to omit those samples from the enclosing struct's overhead, sample count, and period.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
Arnaldo Carvalho de Melo
maintainerPATCH 5/12 perf tests: Exercise data type resolution from a register
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
At -O2 a struct pointer lives in a register and DWARF describes it with a register location, while the unoptimized workloads the data type tests profile keep their variables on the stack.
Build a workload with a noinline function that gets the pointer from a volatile global, which keeps it in a register, and check that its three member accesses are resolved from that location.
--- tools/perf/tests/shell/data_type_register.sh | 120 +++++++++++++++++++ 1 file changed, 120 insertions(+) create mode 100755 tools/perf/tests/shell/data_type_register.sh
tools/perf/tests/shell/data_type_register.sh new file +120 -0
@@ -0,0 +1,120 @@ +#!/bin/bash +# perf data type profiling tests for register variables +# SPDX-License-Identifier: GPL-2.0 + +set -e + +perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) +perfout=$(mktemp /tmp/__perf_test.perf.out.XXXXX) +prog=$(mktemp /tmp/__perf_test.regs.XXXXX) +src="${prog}.c" + +cleanup() +{ + rm -f "$perfdata" "$perfout" "$prog" "$src" + trap - EXIT TERM INT +} + +trap_cleanup() +{ + echo "Unexpected signal in ${FUNCNAME[1]}" + cleanup + exit 1 +} +trap trap_cleanup EXIT TERM INT + +if ! perf check feature -q dwarf; then + echo "Skip: no DWARF (libdw) support" + cleanup + exit 2 +fi + +# No point in recording if the PMU cannot do memory events. +if perf mem record -o /dev/null -- true 2>&1 | \ + grep -q "failed: no PMU supports the memory events"; then + cleanup + exit 2 +fi +if ! perf mem record -o /dev/null -- true 2>/dev/null; then + echo "Skip: cannot record memory events on this PMU" + cleanup + exit 2 +fi + +cat > "$src" <<'EOF' +#include <signal.h> +#include <stdlib.h> +#include <unistd.h> + +struct node { + long a; + long b; + long c; +}; + +static struct node n; +static struct node *volatile vp; +static volatile sig_atomic_t done; + +static void stop(int sig) +{ + done = 1; +} + +__attribute__((noinline)) static long touch(struct node *p) +{ + long sum = 0; + + sum += p->a; + p->b = sum; + sum += p->c; + return sum; +} + +int main(void) +{ + unsigned long sum = 0; + + vp = &n; + signal(SIGALRM, stop); + alarm(1); + + while (!done) + sum += touch(vp); + + return sum != 0; +} +EOF + +# -O2: the pointer stays in a register, so the accesses are resolved +# from its type state instead of from a stack slot. +if ! cc -O2 -g -fPIE -pie -o "$prog" "$src" 2>/dev/null; then + echo "Skip: cannot build the workload" + cleanup + exit 2 +fi + +if ! perf mem record -o "$perfdata" -- "$prog" > /dev/null 2>&1; then + echo "FAIL: perf mem record" + cleanup + exit 1 +fi + +if ! perf annotate --code-with-type -i "$perfdata" --stdio \ + --percent-limit 1 > "$perfout" 2>/dev/null; then + echo "FAIL: perf annotate" + cleanup + exit 1 +fi + +for member in "+0 (a)" "+0x8 (b)" "+0x10 (c)"; do + if ! grep -Fq "# data-type: struct node ${member}" "$perfout"; then + echo "FAIL: member ${member} not resolved from the register" + cleanup + exit 1 + fi +done + +echo "register held access resolved" + +cleanup
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 05/12] perf tests: Exercise data type resolution from a register
Sashiko has reviewed this patch and found no issues.
Quoted 11 lines
From: Arnaldo Carvalho de Melo <[email protected]>
At -O2 a struct pointer lives in a register and DWARF describes it with a register location, while the unoptimized workloads the data type tests profile keep their variables on the stack.
Build a workload with a noinline function that gets the pointer from a volatile global, which keeps it in a register, and check that its three member accesses are resolved from that location.
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5
Arnaldo Carvalho de Melo
maintainerPATCH 6/12 perf annotate: Print the stats after the annotations
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
The instruction stats are printed before the loop that accounts them, so 'perf annotate --code-with-type --insn-stat' always shows zeros. The data type counters are updated in --code-with-type mode too, but only --data-type mode accounts their total, so they are incomplete there.
Print both after the annotation loops, the data type part only with --data-type.
--- tools/perf/builtin-annotate.c | 10 ++-- tools/perf/tests/shell/annotate_stats.sh | 58 ++++++++++++++++++++++++ 2 files changed, 63 insertions(+), 5 deletions(-) create mode 100755 tools/perf/tests/shell/annotate_stats.sh
tools/perf/builtin-annotate.c +5 -5
@@ -414,11 +414,6 @@ static void hists__find_annotations(struct hists *hists,struct rb_node *nd =rb_first_cached (&hists->entries), *next;int key =K_RIGHT ; -if (ann->type_stat) -print_annotate_data_stat (&ann_data_stat); -if (ann->insn_stat) -print_annotate_item_stat (&ann_insn_stat,"Instruction" ); -while (nd) { struct hist_entry *he = rb_entry(nd, struct hist_entry, rb_node);struct annotation *notes;
@@ -660,6 +655,11 @@ static int __cmd_annotate(struct perf_annotate *ann)hists__find_annotations (hists, pos, ann); } +if (ann->data_type && ann->type_stat) +print_annotate_data_stat (&ann_data_stat); +if (ann->insn_stat) +print_annotate_item_stat (&ann_insn_stat,"Instruction" ); +if (use_browser ==2 ) {void (*show_annotations)(void );
tools/perf/tests/shell/annotate_stats.sh new file +58 -0
58 lines not on this page · raw message
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 06/12] perf annotate: Print the stats after the annotations
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] perf test: missing DWARF feature check in annotate_stats.sh without libdw --
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Low] perf test: missing DWARF feature check in annotate_stats.sh without libdw
--
commit a3aa8082d0e5c5ce9cb6c085dad08c8447fc23aa
Author: Arnaldo Carvalho de Melo <[email protected]>
perf annotate: Print the stats after the annotations
This commit moves the printing of data type and instruction stats in perf annotate to after the annotation loops and adds a shell test for instruction stats.
Quoted 5 lines
tools/perf/tests/shell/annotate_stats.sh new file +0
-0
[ ... ]
Quoted 4 lines
tools/perf/tests/shell/annotate_stats.sh new file +4
-0+if ! perf annotate --code-with-type --insn-stat -i "$perfdata" --stdio \ + --percent-limit 1 > "$perfout" 2>/dev/null; then + echo "FAIL: perf annotate" + cleanup
tools/perf/tests/shell/annotate_stats.sh line 55
Quoted 10 lines
tools/perf/tests/shell/annotate_stats.sh new file +10
-0+ exit 1 +fi + +# The instruction stats are accounted while the instructions are +# displayed; printing them before the display loop shows zeros. +if ! grep -Eq '^total [1-9][0-9]*,' "$perfout"; then + echo "FAIL: instruction stats not accounted" + cleanup + exit 1 +fi
[Severity: Low]
Will this test fail with exit status 1 instead of skipping when perf is built without libdw dwarf support (HAVE_LIBDW_SUPPORT)?
Unlike --data-type, --code-with-type does not exit early when HAVE_LIBDW_SUPPORT is disabled. Instead, debuginfo__new() returns NULL, so annotation_line__print() skips __hist_entry__get_data_type() and prints "total 0". Checking "perf check feature -q dwarf" before running the test, as in data_type_register.sh, would skip cleanly with exit status 2.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
Arnaldo Carvalho de Melo
maintainerPATCH 7/12 perf tests: Silence the libbfd probe in build-test
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
build-test evaluates the libbfd probe at parse time and the compiler's stderr isn't captured by $(shell ...), so without binutils-devel it prints "bfd.h: No such file or directory" once per tests/make invocation, five times per run.
Redirect the compiler's stderr; the empty result still skips the nondistro tests as intended.
--- tools/perf/tests/make | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/make +1 -1
@@ -128,7 +128,7 @@ make_minimal += NO_SDT=1 NO_JVMTI=1 NO_LIBZSTD=1 make_minimal += NO_CAPSTONE=1 # binutils 2_42 and newer have bfd_thread_init() -new_libbfd := $(shell echo '#include <bfd.h>' | $(CC) -E -x c - | grep bfd_thread_init) +new_libbfd := $(shell echo '#include <bfd.h>' | $(CC) -E -x c - 2>/dev/null | grep bfd_thread_init) # Whether libLLVM can be built, which needs the llvm-devel/llvm-dev headers and # libraries of version 13 or newer, not just llvm-config. This mirrors the
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 07/12] perf tests: Silence the libbfd probe in build-test
Sashiko has reviewed this patch and found no issues.
Quoted 7 lines
From: Arnaldo Carvalho de Melo <[email protected]>
build-test evaluates the libbfd probe at parse time and the compiler's stderr isn't captured by $(shell ...), so without binutils-devel it prints "
bfd.h: No such file or directory" once per tests/make invocation, five times per run.
Quoted 6 lines
Redirect the compiler's stderr; the empty result still skips the nondistro tests as intended.
Fixes 523471c5163659c6 ("perf build: Skip nondistro build test if libbfd is old")Cc James Clark <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=7
Arnaldo Carvalho de Melo
maintainerPATCH 8/12 perf build: Record the display-only features in FEATURE-DUMP
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
llvm-perf and rust are in FEATURE_DISPLAY but not in FEATURE_TESTS: they can't be part of the test-all fast path, which sets every FEATURE_TESTS entry to 1 when test-all.c builds. Since FEATURE-DUMP is written from FEATURE_TESTS only, a FEATURES_DUMP= build, as used by build-test, never sees them and silently builds without libLLVM and the rust workloads.
Append the display features that aren't in FEATURE_TESTS to the dump after the regular feature checks have run.
--- tools/perf/Makefile.config | 4 ++++ 1 file changed, 4 insertions(+)
tools/perf/Makefile.config +4 -0
@@ -1310,3 +1310,7 @@ endif # tests. $(shell rm -f $(FEATURE_DUMP_FILENAME)) $(foreach feat,$(FEATURE_TESTS),$(shell echo "$(call feature_assign,$(feat))" >> $(FEATURE_DUMP_FILENAME))) +# Features only in FEATURE_DISPLAY aren't part of the test-all fast path, so +# they have to be checked explicitly and recorded here too, otherwise a +# FEATURES_DUMP= build silently disables them (llvm-perf, rust). +$(foreach feat,$(filter-out $(FEATURE_TESTS),$(FEATURE_DISPLAY)),$(shell echo "$(call feature_assign,$(feat))" >> $(FEATURE_DUMP_FILENAME)))
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 08/12] perf build: Record the display-only features in FEATURE-DUMP
Sashiko has reviewed this patch and found no issues.
Quoted 8 lines
From: Arnaldo Carvalho de Melo <[email protected]>
llvm-perf and rust are in
FEATURE_DISPLAYbut not inFEATURE_TESTS: they can't be part of the test-all fast path, which sets everyFEATURE_TESTSentry to 1 whentest-all.cbuilds. Since FEATURE-DUMP is written fromFEATURE_TESTSonly, a FEATURES_DUMP= build, as used by build-test, never sees them and silently builds without libLLVM and the rust workloads.
Quoted 7 lines
Append the display features that aren't in
FEATURE_TESTSto the dump after the regular feature checks have run.Fixes 206dcfca1f5cfac3 ("perf build: Autodetect minimum required llvm-dev version")Fixes 3f5dfa472ea6771c ("tools build: Fix rust feature detection")Cc James Clark <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8
Arnaldo Carvalho de Melo
maintainerPATCH 9/12 perf cs-etm: Fall back to the recorded instruction size on a failed read
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
cs_etm__t32_instr_size() reads the instruction bytes from the traced program's memory to tell a 16-bit from a 32-bit T32 instruction, but it ignores cs_etm__frontend_mem_access() failing, which happens when the DSO or its debug data is missing, and then reads the uninitialized buffer. GCC 16 warns about it and build-test fails with -Werror.
Use the instruction size recorded by the decoder, as the A32/A64 path already does, when the read doesn't return the full two bytes.
--- tools/perf/util/cs-etm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
tools/perf/util/cs-etm.c +5 -2
@@ -1370,9 +1370,12 @@ static inline int cs_etm__t32_instr_size(struct cs_etm_queue *etmq, struct cs_etm_packet *packet, u64 addr) {u8 instrBytes[2 ]; +u32 len; -cs_etm__frontend_mem_access (etmq, tidq, packet, addr, -ARRAY_SIZE (instrBytes), instrBytes); + len =cs_etm__frontend_mem_access (etmq, tidq, packet, addr, +ARRAY_SIZE (instrBytes), instrBytes); +if (len !=ARRAY_SIZE (instrBytes)) +return packet->last_instr_size;/* * T32 instruction size is indicated by bits[15:11] of the first * 16-bit word of the instruction: 0b11101, 0b11110 and 0b11111
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 09/12] perf cs-etm: Fall back to the recorded instruction size on a failed read
Sashiko has reviewed this patch and found no issues.
Quoted 11 lines
From: Arnaldo Carvalho de Melo <[email protected]>
cs_etm__t32_instr_size()reads the instruction bytes from the traced program's memory to tell a 16-bit from a 32-bit T32 instruction, but it ignorescs_etm__frontend_mem_access()failing, which happens when the DSO or its debug data is missing, and then reads the uninitialized buffer. GCC 16 warns about it and build-test fails with -Werror.Use the instruction size recorded by the decoder, as the A32/A64 path already does, when the read doesn't return the full two bytes.
Quoted 9 lines
Fixes a7ee4d625ede4f62 ("perf cs-etm: Support for ARM A32/T32 instruction sets in CoreSight trace")Cc James Clark <[email protected]>Cc Leo Yan <[email protected]>Cc Mike Leach <[email protected]>Cc Robert Walker <[email protected]>Cc Suzuki K Poulose <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9
Leo Yan
reviewerRe: [PATCH v1 09/12] perf cs-etm: Fall back to the recorded instruction size on a failed read
In reply to Arnaldo Carvalho de MeloHi Arnaldo,
Quoted 10 lines · Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <[email protected]>
cs_etm__t32_instr_size()reads the instruction bytes from the traced program's memory to tell a 16-bit from a 32-bit T32 instruction, but it ignorescs_etm__frontend_mem_access()failing, which happens when the DSO or its debug data is missing, and then reads the uninitialized buffer. GCC 16 warns about it and build-test fails with -Werror.Use the instruction size recorded by the decoder, as the A32/A64 path already does, when the read doesn't return the full two bytes.
This patch is duplicate with:
I prefer that one, it handle cs_etm__frontend_mem_access() failure throughly.
Arnaldo Carvalho de Melo
maintainerRe: [PATCH v1 09/12] perf cs-etm: Fall back to the recorded instruction size on a failed read
Quoted 14 lines · Leo Yan
Hi Arnaldo,
Quoted 10 lines · Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <[email protected]>
cs_etm__t32_instr_size()reads the instruction bytes from the traced program's memory to tell a 16-bit from a 32-bit T32 instruction, but it ignorescs_etm__frontend_mem_access()failing, which happens when the DSO or its debug data is missing, and then reads the uninitialized buffer. GCC 16 warns about it and build-test fails with -Werror.Use the instruction size recorded by the decoder, as the A32/A64 path already does, when the read doesn't return the full two bytes.
Quoted 6 lines
This patch is duplicate with:
I prefer that one, it handle
cs_etm__frontend_mem_access()failure throughly.
Ok, I'll replace it with yours,
- Arnaldo
Arnaldo Carvalho de Melo
maintainerPATCH 10/12 perf tests: Fix the Intel PT virtual LBR check
In reply to Arnaldo Carvalho de MeloThe record this check uses writes aux samples, and with the single data page the other tests ask for they are lost:
Warning: Processed 29 samples and lost 100.00%
so no branches are decoded and the check fails with "Failed with virtual lbr". Record with 4 data pages and 128 auxtrace pages: the same trace decodes 64 branches and still fits the mlock budget.
Require the python perf module to provide session, not just to be
importable: a perf whose python bindings are not found can pick up an unrelated module and fail with
Error processing events: module 'perf' has no attribute 'session'
instead of skipping the subtest.
Detected building perf on fedora:44 on the runner with Intel PT hardware, where the subtest failed with "Failed with virtual lbr" in the container, and with the python error when run as root on the same machine.
--- tools/perf/tests/shell/test_intel_pt.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
tools/perf/tests/shell/test_intel_pt.sh +5 -4
@@ -384,13 +384,14 @@ test_virtual_lbr() # shellcheck source=lib/setup_python.sh . "${shelldir}"/lib/setup_python.sh - if ! "$PYTHON" -c 'import perf' > /dev/null 2>&1; then - echo "SKIP: Python perf module not found" + if ! "$PYTHON" -c 'import perf; perf.session' > /dev/null 2>&1; then + echo "SKIP: Python perf module with session support not found" return 2 fi - # Check if virtual lbr is working - perf_record_no_bpf -o "${tmpfile}" --aux-sample \ + # Check if virtual lbr is working. This records aux samples, which a + # single data page overruns, so give it more room than the other tests. + perf_record_no_bpf -m 4,128 -o "${tmpfile}" --aux-sample \ -e '{intel_pt//,cycles}:u' perf test -w brstack || return 1 perf inject --itrace=L -i "${tmpfile}" -o "${perfdatafile}" || return 1 output=$("$PYTHON" "${shelldir}/lib/perf_brstack_max.py" -i "${perfdatafile}") || return 1
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 10/12] perf tests: Fix the Intel PT virtual LBR check
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] perf tests: missing Fixes: trailer for commit 915d6b14dc0c --
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Low] perf tests: missing Fixes: trailer for commit 915d6b14dc0c --
commit 8d6a959ddd3628adc90143588c99d2bf9b1a9f23
Author: Arnaldo Carvalho de Melo <[email protected]>
Quoted 17 lines
perf tests: Fix the Intel PT virtual LBR check
The record this check uses writes aux samples, and with the single data page the other tests ask for they are lost:
Warning: Processed 29 samples and lost 100.00%
so no branches are decoded and the check fails with "Failed with virtual lbr". Record with 4 data pages and 128 auxtrace pages: the same trace decodes 64 branches and still fits the mlock budget.
Require the python perf module to provide session, not just to be
importable: a perf whose python bindings are not found can pick up an unrelated module and fail withError processing events: module 'perf' has no attribute 'session'
Quoted 8 lines
instead of skipping the subtest.
Detected building perf on fedora:44 on the runner with Intel PT hardware, where the subtest failed with "Failed with virtual lbr" in the container, and with the python error when run as root on the same machine.
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
[Severity: Low]
Both the python perf module check and the perf_record_no_bpf call in test_virtual_lbr() were introduced by 915d6b14dc0c ("perf test: Migrate Intel PT virtual LBR test to Python API"). Should this include:
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10
Arnaldo Carvalho de Melo
maintainerPATCH 11/12 perf test: Drop samples without an IP in the dlfilter test
In reply to Arnaldo Carvalho de MeloSince v7.3 the kernel zeroes PERF_SAMPLE_IP when a userspace-only event skids into kernel mode, so that kernel register state is not exposed to an unprivileged event (166f10836a653dfa "perf/core: Fix kernel register info leak via hardware skid").
The test dlfilter keeps those samples, and the check that nothing but test_loop survives then trips on their lines: the comm column reads "perf". Drop them, which is what the test wants, everything except test_loop must be filtered out.
--- tools/perf/tests/shell/script_dlfilter.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/script_dlfilter.sh +1 -1
@@ -46,7 +46,7 @@ int filter_event(void *data, const struct perf_dlfilter_sample *sample, void *ct const struct perf_dlfilter_al *al; if (!sample->ip) - return 0; + return 1; al = perf_dlfilter_fns.resolve_ip(ctx); if (!al || !al->sym || strcmp(al->sym, "test_loop"))
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 11/12] perf test: Drop samples without an IP in the dlfilter test
Sashiko has reviewed this patch and found no issues.
Quoted 10 lines
Since v7.3 the kernel zeroes
PERF_SAMPLE_IPwhen a userspace-only event skids into kernel mode, so that kernel register state is not exposed to an unprivileged event (166f10836a653dfa"perf/core: Fix kernel register info leak via hardware skid").The test dlfilter keeps those samples, and the check that nothing but
test_loopsurvives then trips on their lines: the comm column reads "perf". Drop them, which is what the test wants, everything excepttest_loopmust be filtered out.
Quoted 4 lines
Fixes 199d5e872a9ce737 ("perf tests script dlfilter: Add a dlfilter test")Cc Ian Rogers <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Sashiko has reviewed this patch and found no issues.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11
Arnaldo Carvalho de Melo
maintainerPATCH 12/12 perf test: Skip the LBR inline unwinding check when unsupported
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
The check only looks for the PMU's caps/branches file before recording with --call-graph lbr. AMD BRS advertises branches but only samples its own retired branches event, so the record with cycles is rejected and the test fails instead of skipping.
Probe the record and skip when it fails, as the branch stack test does.
--- tools/perf/tests/shell/addr2line_inlines.sh | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
tools/perf/tests/shell/addr2line_inlines.sh +8 -1
@@ -71,7 +71,14 @@ test_lbr() { fi # Record data. Currently only dwarf callchains support inlined functions. - perf record --call-graph lbr -e cycles:u -o "${perf_data}" -- perf test -w inlineloop 1 + # Some PMUs advertise branches but reject branch sampling for cycles, e.g. + # AMD BRS, which only samples its own retired branches event. + if ! perf record --call-graph lbr -e cycles:u -o "${perf_data}" -- \ + perf test -w inlineloop 1 2>/dev/null + then + echo "Skip: LBR not supported by the PMU" + return + fi # Check output with inline (default) and srcline perf script -i "${perf_data}" --fields +srcline > "${perf_script_txt}"
Signature · 1 line
2.56.0
[email protected]
AI reviewRe: [PATCH v1 12/12] perf test: Skip the LBR inline unwinding check when unsupported
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] perf test: incorrect Fixes trailer in commit message for test_lbr() --
Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Low] perf test: incorrect Fixes trailer in commit message for test_lbr()
--
commit a78b0cf1c3a28b268aa40ae18726740e97e69c32
Author: Arnaldo Carvalho de Melo <[email protected]>
Quoted 7 lines
perf test: Skip the LBR inline unwinding check when unsupported
The check only looks for the PMU's caps/branches file before recording with --call-graph lbr. AMD BRS advertises branches but only samples its own retired branches event, so the record with cycles is rejected and the test fails instead of skipping.
Quoted 5 lines
Probe the record and skip when it fails, as the branch stack test does.
Fixes 54a23bff770961e0 ("perf test: Test addr2line unwinding works with inline functions")Cc Ian Rogers <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
[Severity: Low]54a23bff7709 ("perf test: Test addr2line unwinding works with inline functions") only added the dwarf test; test_lbr() and its unguarded "--call-graph lbr -e cycles:u" record were introduced later. Should the Fixes tag be:
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12