Skip to contentSkip to conversation

media: rockchip: Add the IEP2 deinterlacer of RK3568/RK3588

PATCH Superseded Arun Iyengar 4 participants 9 messages Nov 15 – Nov 17

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover media: rockchip: Add the IEP2 deinterlacer of RK3568/RK3588

Add a V4L2 mem2mem driver for the IEP2 deinterlacer of the RK3568 and RK3588, with its binding and the RK3588 DT node. It is based on the Rockchip vendor driver; the V4L2 side follows Alex Bee's IEP driver.

Tested on an Orange Pi 5 (RK3588S) with a 7.3-based kernel; build-tested on media next. v4l2-compliance 59/59, all four modes at 576i/1080i without IOMMU faults. Not tested: RK3568. DMABUF imports of exactly the image size are refused, because of the 4 KiB OUTPUT padding (see 2/3).

Developed with Claude (Anthropic), which wrote the code and the commit messages; I reviewed every change.

---
Changes in v2:
- 2/3: return the held OUTPUT and second CAPTURE buffers when a job cannot start (Sashiko)
- 2/3: clear only the interrupt bits that were read (Sashiko)
- 2/3: in remove(), unregister the video device before suspending the m2m core (Sashiko)
- Shorter cover, driver commit message, doc and comments
- Link to v1: https://patch.msgid.link/[email protected]

---
Arun Iyengar (3):
media: dt-bindings: Add Rockchip IEP2 deinterlacer
media: rockchip: Add IEP2 deinterlacer driver
arm64: dts: rockchip: Add IEP2 deinterlacer to RK3588

 Documentation/admin-guide/media/rockchip-iep2.rst  |   32 +
 Documentation/admin-guide/media/v4l-drivers.rst    |    1 +
 .../bindings/media/rockchip,rk3568-iep2.yaml       |   95 ++
 MAINTAINERS                                        |    9 +
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi      |   22 +
 drivers/media/platform/rockchip/Kconfig            |    1 +
 drivers/media/platform/rockchip/Makefile           |    1 +
 drivers/media/platform/rockchip/iep2/Kconfig       |   16 +
 drivers/media/platform/rockchip/iep2/Makefile      |    3 +
 drivers/media/platform/rockchip/iep2/iep2-regs.h   |  191 +++
 drivers/media/platform/rockchip/iep2/iep2.c        | 1280 ++++++++++++++++++++
 drivers/media/platform/rockchip/iep2/iep2.h        |  106 ++
 12 files changed, 1757 insertions(+)

---
base-commit: ad6549a46748d00818483b535e5cd2a704685c98
change-id: 20261110-iep2-b9a9c6e77c44

Best regards,

Signature · 1 line
Arun Iyengar <[email protected]>
#1 lore raw

PATCH v2 1/3 media: dt-bindings: Add Rockchip IEP2 deinterlacer

Add a binding for the IEP2 deinterlacer of the RK3568 and RK3588 SoCs. It is a different block from the IEP of RK3228/RK3288/RK3328/RK3399, hence "iep2". The RK3588 block falls back to the RK3568 compatible:
the vendor kernel drives both with one compatible ("rockchip,iep-v2") and one driver.

Clock and reset names follow the RGA binding. The resets are optional:
the block has its own soft reset.

---
 .../bindings/media/rockchip,rk3568-iep2.yaml       | 95 ++++++++++++++++++++++
 MAINTAINERS                                        |  7 ++
 2 files changed, 102 insertions(+)
Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml new file +95 -0
new file mode 100644
index 000000000000..0c7666de19f8
@@ -0,0 +1,95 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/rockchip,rk3568-iep2.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip IEP2 image enhancement processor
+
+maintainers:
+  - Arun Iyengar <[email protected]>
+
+description:
+  Memory to memory video deinterlacer of the Rockchip RK3568 and RK3588
+  SoCs. It has its own IOMMU, with which it shares its interrupt line.
+
+properties:
+  compatible:
+    oneOf:
+      - const: rockchip,rk3568-iep2
+      - items:
+          - const: rockchip,rk3588-iep2
+          - const: rockchip,rk3568-iep2
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: AXI bus clock
+      - description: AHB bus clock
+      - description: Core clock
+
+  clock-names:
+    items:
+      - const: aclk
+      - const: hclk
+      - const: sclk
+
+  resets:
+    items:
+      - description: AXI reset
+      - description: AHB reset
+      - description: Core reset
+
+  reset-names:
+    items:
+      - const: axi
+      - const: ahb
+      - const: core
+
+  power-domains:
+    maxItems: 1
+
+  iommus:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - power-domains
+  - iommus
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/rockchip,rk3588-cru.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/power/rk3588-power.h>
+    #include <dt-bindings/reset/rockchip,rk3588-cru.h>
+
+    bus {
+      #address-cells = <2>;
+      #size-cells = <2>;
+
+      deinterlace@fdbb0000 {
+        compatible = "rockchip,rk3588-iep2", "rockchip,rk3568-iep2";
+        reg = <0x0 0xfdbb0000 0x0 0x500>;
+        interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&cru ACLK_IEP2P0>, <&cru HCLK_IEP2P0>,
+                 <&cru CLK_IEP2P0_CORE>;
+        clock-names = "aclk", "hclk", "sclk";
+        resets = <&cru SRST_A_IEP2P0>, <&cru SRST_H_IEP2P0>,
+                 <&cru SRST_IEP2P0_CORE>;
+        reset-names = "axi", "ahb", "core";
+        power-domains = <&power RK3588_PD_VDPU>;
+        iommus = <&iep_mmu>;
+      };
+    };
MAINTAINERS +7 -0
index f4456f4589a1..b32b7eeb0a9e 100644
@@ -24285,6 +24285,13 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
 F:	sound/soc/rockchip/rockchip_i2s_tdm.*
 
+ROCKCHIP IEP2 DEINTERLACER DRIVER
+M:	Arun Iyengar <[email protected]>
+L:	[email protected]
+L:	[email protected]
+S:	Maintained
+F:	Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml
+
 ROCKCHIP ISP V1 DRIVER
 M:	Dafna Hirschfeld <[email protected]>
 M:	Laurent Pinchart <[email protected]>
Signature · 1 line
2.55.0
Reviewed-by on v2 1/3
#2 lore raw

Re: [PATCH v2 1/3] media: dt-bindings: Add Rockchip IEP2 deinterlacer

Quoted 5 lines · Arun Iyengar

Add a binding for the IEP2 deinterlacer of the RK3568 and RK3588 SoCs. It is a different block from the IEP of RK3228/RK3288/RK3328/RK3399, hence "iep2". The RK3588 block falls back to the RK3568 compatible:
the vendor kernel drives both with one compatible ("rockchip,iep-v2") and one driver.

Honestly, last sentence is redundant. Vendor kernels do all sorts of odd things. Qualcomm vendor kernel has 100 properties per device nodes, each defining single piece of hardware or driver. Shall we ever mention it? No, it's downstream choice, not relevant to here. If Rockchip vendor kernel managed 100 devices with single compatible would that ever mean anything to us? No.

Quoted 14 lines

Clock and reset names follow the RGA binding. The resets are optional:
the block has its own soft reset.

---
 .../bindings/media/rockchip,rk3568-iep2.yaml       | 95 ++++++++++++++++++++++
 MAINTAINERS                                        |  7 ++
 2 files changed, 102 insertions(+)
Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml new file +0 -1
new file mode 100644
index 000000000000..0c7666de19f8
--- /dev/null

...

Quoted 19 lines
Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml new file +14 -0
+      deinterlace@fdbb0000 {
+        compatible = "rockchip,rk3588-iep2", "rockchip,rk3568-iep2";
+        reg = <0x0 0xfdbb0000 0x0 0x500>;
+        interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&cru ACLK_IEP2P0>, <&cru HCLK_IEP2P0>,
+                 <&cru CLK_IEP2P0_CORE>;
+        clock-names = "aclk", "hclk", "sclk";
+        resets = <&cru SRST_A_IEP2P0>, <&cru SRST_H_IEP2P0>,
+                 <&cru SRST_IEP2P0_CORE>;
+        reset-names = "axi", "ahb", "core";
+        power-domains = <&power RK3588_PD_VDPU>;
+        iommus = <&iep_mmu>;
+      };
+    };
MAINTAINERS +0 -0
index f4456f4589a1..b32b7eeb0a9e 100644

MAINTAINERS S: Maintained · line 24290

Quoted 6 lines
MAINTAINERS +3 -0
@@ -24285,6 +24285,13 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
 F:	sound/soc/rockchip/rockchip_i2s_tdm.*
 
+ROCKCHIP IEP2 DEINTERLACER DRIVER
+M:	Arun Iyengar <[email protected]>
+L:	[email protected]

You can drop the media, subsystem defines it. No need to grow more than necessary.

MAINTAINERS S: Maintained · line 24293

Quoted 3 lines
MAINTAINERS +3 -0
+L:	[email protected]
+S:	Maintained
+F:	Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml

Best regards,
Krzysztof

#3 lore raw

PATCH v2 2/3 media: rockchip: Add IEP2 deinterlacer driver

In reply to Arun Iyengar

Add a V4L2 mem2mem driver for the IEP2 deinterlacer of the RK3568 and RK3588. Registers and defaults come from the Rockchip vendor kernel (mpp_iep2.c, GPL-2.0+ OR MIT) and MPP; the V4L2 part follows sun8i-di and Alex Bee's IEP driver.

The hardware reads past the end of the source, so OUTPUT buffers have 4 KiB of tail padding.

---
 Documentation/admin-guide/media/rockchip-iep2.rst |   32 +
 Documentation/admin-guide/media/v4l-drivers.rst   |    1 +
 MAINTAINERS                                       |    2 +
 drivers/media/platform/rockchip/Kconfig           |    1 +
 drivers/media/platform/rockchip/Makefile          |    1 +
 drivers/media/platform/rockchip/iep2/Kconfig      |   16 +
 drivers/media/platform/rockchip/iep2/Makefile     |    3 +
 drivers/media/platform/rockchip/iep2/iep2-regs.h  |  191 +++
 drivers/media/platform/rockchip/iep2/iep2.c       | 1280 +++++++++++++++++++++
 drivers/media/platform/rockchip/iep2/iep2.h       |  106 ++
 10 files changed, 1633 insertions(+)
Documentation/admin-guide/media/rockchip-iep2.rst new file +32 -0
new file mode 100644
index 000000000000..ee0ffe23dec2
@@ -0,0 +1,32 @@
+.. SPDX-License-Identifier: GPL-2.0
+
+Rockchip IEP2 deinterlacer driver
+=================================
+
+The rockchip-iep2 driver supports the IEP2 deinterlacer of the RK3568 and
+RK3588 as a V4L2 mem2mem device. OUTPUT takes interlaced frames, CAPTURE
+returns progressive frames in the same format. For
+``V4L2_FIELD_INTERLACED`` the field order follows the height: bottom field
+first below 576 lines, top field first otherwise.
+
+``V4L2_CID_DEINTERLACING_MODE (menu)``
+    The rate cannot change while a queue is streaming (``EBUSY``).
+
+.. flat-table::
+    :header-rows:  0
+    :stub-columns: 0
+    :widths:       1 4
+
+    * - ``"Bob, Frame Rate" (0)``
+      - One CAPTURE buffer per OUTPUT buffer. Default.
+    * - ``"Bob, Field Rate" (1)``
+      - Two CAPTURE buffers per OUTPUT buffer.
+    * - ``"Motion Adaptive, Frame Rate" (2)``
+      - Uses the previous OUTPUT buffer as reference, so at least two
+        OUTPUT buffers are needed. One CAPTURE buffer per OUTPUT buffer.
+    * - ``"Motion Adaptive, Field Rate" (3)``
+      - As above, two CAPTURE buffers per OUTPUT buffer.
+
+The hardware reads past the end of the source image, so the OUTPUT
+``sizeimage`` is 4 KiB larger than the image and OUTPUT buffers must be at
+least that size.
Documentation/admin-guide/media/v4l-drivers.rst +1 -0
index 4621eae9fa1e..3d59d5d73fd0 100644
@@ -29,6 +29,7 @@ Video4Linux (V4L) driver-specific documentation
 	rcar-fdp1
 	rkcif
 	rkisp1
+	rockchip-iep2
 	raspberrypi-rp1-cfe
 	saa7134
 	si470x
MAINTAINERS +2 -0
index b32b7eeb0a9e..564d39b2cca9 100644
@@ -24290,7 +24290,9 @@ M:	Arun Iyengar <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Maintained
+F:	Documentation/admin-guide/media/rockchip-iep2.rst
 F:	Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml
+F:	drivers/media/platform/rockchip/iep2/
 
 ROCKCHIP ISP V1 DRIVER
 M:	Dafna Hirschfeld <[email protected]>
drivers/media/platform/rockchip/Kconfig +1 -0
index ba401d32f01b..4f65bd0126de 100644
@@ -2,6 +2,7 @@
 
 comment "Rockchip media platform drivers"
 
+source "drivers/media/platform/rockchip/iep2/Kconfig"
 source "drivers/media/platform/rockchip/rga/Kconfig"
 source "drivers/media/platform/rockchip/rkcif/Kconfig"
 source "drivers/media/platform/rockchip/rkisp1/Kconfig"
drivers/media/platform/rockchip/Makefile +1 -0
index 0e0b2cbbd4bd..c385048ba347 100644
@@ -1,4 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
+obj-y += iep2/
 obj-y += rga/
 obj-y += rkcif/
 obj-y += rkisp1/
drivers/media/platform/rockchip/iep2/Kconfig new file +16 -0
new file mode 100644
index 000000000000..de1e445b3fd8
@@ -0,0 +1,16 @@
+# SPDX-License-Identifier: GPL-2.0-only
+config VIDEO_ROCKCHIP_IEP2
+	tristate "Rockchip IEP2 deinterlacer"
+	depends on V4L_MEM2MEM_DRIVERS
+	depends on VIDEO_DEV
+	depends on ARCH_ROCKCHIP || COMPILE_TEST
+	select VIDEOBUF2_DMA_CONTIG
+	select V4L2_MEM2MEM_DEV
+	help
+	  Support for the IEP2 (image enhancement processor) found in the
+	  Rockchip RK3568 and RK3588 SoCs. It is exposed as a V4L2 memory to
+	  memory device that deinterlaces NV12/NV21/NV16/NV61 frames, using
+	  either intra-field (bob) or motion-adaptive interpolation.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called rockchip-iep2.
drivers/media/platform/rockchip/iep2/Makefile new file +3 -0
new file mode 100644
index 000000000000..f13bb799de54
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0-only
+obj-$(CONFIG_VIDEO_ROCKCHIP_IEP2) += rockchip-iep2.o
+rockchip-iep2-y := iep2.o
drivers/media/platform/rockchip/iep2/iep2-regs.h new file +191 -0

191 lines not on this page · raw message

drivers/media/platform/rockchip/iep2/iep2.c new file +1280 -0

1,280 lines not on this page · raw message

drivers/media/platform/rockchip/iep2/iep2.h new file +106 -0

106 lines not on this page · raw message

Signature · 1 line
2.55.0
#4 lore raw

Re: [PATCH v2 2/3] media: rockchip: Add IEP2 deinterlacer driver

Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] media: rockchip: iep2: race in iep_device_run() releasing irq_lock early --

Thank you for your contribution! Sashiko AI review found 1 potential issue to consider:
- [Medium] media: rockchip: iep2: race in iep_device_run() releasing irq_lock early
--

commit c53068d9410d9d69d9ff5d8e23bf87ad9adb3c8e
Author: Arun Iyengar <[email protected]>

media: rockchip: Add IEP2 deinterlacer driver

This commit adds a V4L2 mem2mem driver for the Rockchip IEP2 deinterlacer found on the RK3568 and RK3588 SoCs.

Quoted 5 lines
drivers/media/platform/rockchip/iep2/iep2.c new file +0 -0
new file mode 100644
index 0000000000000..709c16f3c7fd5

[ ... ]

Quoted 2 lines
drivers/media/platform/rockchip/iep2/iep2.c new file +2 -0
+static void iep_device_run(void *priv)
+{

[ ... ]

drivers/media/platform/rockchip/iep2/iep2.c line 398

Quoted 11 lines
drivers/media/platform/rockchip/iep2/iep2.c new file +11 -0
+	spin_lock_irqsave(&iep->irq_lock, flags);
+	iep->busy = true;
+	iep->irq_status = 0;
+	iep->foreign_irqs = 0;
+	spin_unlock_irqrestore(&iep->irq_lock, flags);
+
+	schedule_delayed_work(&iep->watchdog_work,
+			      msecs_to_jiffies(IEP_WATCHDOG_MS));
+
+	writel(IEP2_FRM_EN, iep->regs + IEP2_FRM_START);
+}

[Severity: Medium]
Can releasing iep->irq_lock before scheduling iep->watchdog_work and writing IEP2_FRM_EN race with iep_watchdog() or shared interrupts?

CPU0 CPU1
iep_device_run()
spin_lock_irqsave(&iep->irq_lock)
iep->busy = true
spin_unlock_irqrestore(&iep->irq_lock)
schedule_delayed_work(&iep->watchdog_work, ...)
<preempted>

                                      iep_watchdog()
                                        iep->busy = false
                                        iep_reset(iep)
                                        iep_job_done(ctx, ...)
                                          v4l2_m2m_buf_done(...)
                                          pm_runtime_put_autosuspend(...)

writel(IEP2_FRM_EN, ...) <-- starts DMA on returned buffers / unclocked regs

Similarly, if IEP_MAX_FOREIGN_IRQS shared interrupts arrive on the shared IRQ line right after spin_unlock_irqrestore(), iep_irq() sees iep->busy and wakes iep_irq_thread(), which finishes the job before iep_device_run() queues iep->watchdog_work and writes IEP2_FRM_START.

Keeping schedule_delayed_work() and writel(IEP2_FRM_EN, ...) inside the iep->irq_lock critical section would make publishing iep->busy atomic with starting the hardware and watchdog timer.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
#5 lore raw

PATCH v2 3/3 arm64: dts: rockchip: Add IEP2 deinterlacer to RK3588

In reply to Arun Iyengar

Add the IEP2 deinterlacer and its IOMMU to the RK3588 base dtsi. Both share GIC SPI 117 and sit in the VDPU power domain.

Addresses, clocks, resets and the interrupt are taken from the Rockchip BSP rk3588s.dtsi (develop-6.1).

---
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi +22 -0
index aa69fd3793fd..5297519bd251 100644
@@ -1397,6 +1397,28 @@ vepu121_3_mmu: iommu@fdbac800 {
 		#iommu-cells = <0>;
 	};
 
+	iep: deinterlace@fdbb0000 {
+		compatible = "rockchip,rk3588-iep2", "rockchip,rk3568-iep2";
+		reg = <0x0 0xfdbb0000 0x0 0x500>;
+		interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH 0>;
+		clocks = <&cru ACLK_IEP2P0>, <&cru HCLK_IEP2P0>, <&cru CLK_IEP2P0_CORE>;
+		clock-names = "aclk", "hclk", "sclk";
+		resets = <&cru SRST_A_IEP2P0>, <&cru SRST_H_IEP2P0>, <&cru SRST_IEP2P0_CORE>;
+		reset-names = "axi", "ahb", "core";
+		power-domains = <&power RK3588_PD_VDPU>;
+		iommus = <&iep_mmu>;
+	};
+
+	iep_mmu: iommu@fdbb0800 {
+		compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
+		reg = <0x0 0xfdbb0800 0x0 0x100>;
+		interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH 0>;
+		clocks = <&cru ACLK_IEP2P0>, <&cru HCLK_IEP2P0>;
+		clock-names = "aclk", "iface";
+		power-domains = <&power RK3588_PD_VDPU>;
+		#iommu-cells = <0>;
+	};
+
 	vdec0: video-codec@fdc38000 {
 		compatible = "rockchip,rk3588-vdec";
 		reg = <0x0 0xfdc38000 0x0 0x100>,
Signature · 1 line
2.55.0
#6 lore raw

Re: [PATCH v2 3/3] arm64: dts: rockchip: Add IEP2 deinterlacer to RK3588

Quoted 16 lines · Arun Iyengar

Add the IEP2 deinterlacer and its IOMMU to the RK3588 base dtsi. Both share GIC SPI 117 and sit in the VDPU power domain.

Addresses, clocks, resets and the interrupt are taken from the Rockchip BSP rk3588s.dtsi (develop-6.1).

---
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi +0 -0
index aa69fd3793fd..5297519bd251 100644

arch/arm64/boot/dts/rockchip/rk3588-base.dtsi vepu121_3_mmu: iommu@fdbac800 { · line 1400

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi +1 -0
@@ -1397,6 +1397,28 @@ vepu121_3_mmu: iommu@fdbac800 {
 		#iommu-cells = <0>;
 	};
 
+	iep: deinterlace@fdbb0000 {

Why all these are outside soc node? That's more of a question to existing code...

Best regards,
Krzysztof

maintainer
#7 lore raw

Re: [PATCH v2 3/3] arm64: dts: rockchip: Add IEP2 deinterlacer to RK3588

Am Montag, 16. November 2026, 13:35:28 Mitteleuropäische Normalzeit schrieb Krzysztof Kozlowski:

Quoted 20 lines · Arun Iyengar
Quoted 19 lines

Add the IEP2 deinterlacer and its IOMMU to the RK3588 base dtsi. Both share GIC SPI 117 and sit in the VDPU power domain.

Addresses, clocks, resets and the interrupt are taken from the Rockchip BSP rk3588s.dtsi (develop-6.1).

---
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi +0 -0
index aa69fd3793fd..5297519bd251 100644
@@ -1397,6 +1397,28 @@ vepu121_3_mmu: iommu@fdbac800 {
 		#iommu-cells = <0>;
 	};
 
Quoted 4 lines

arch/arm64/boot/dts/rockchip/rk3588-base.dtsi vepu121_3_mmu: iommu@fdbac800 { · line 1400

Quoted 1 line
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi +1 -0
+	iep: deinterlace@fdbb0000 {

Why all these are outside soc node? That's more of a question to existing code...

Many years back, during the RK3288 addition I got the comment from the arm-soc maintainer to drop the soc node [0]:

"[...] this isn't how we tend to do it any more (unless all devices are physically on a bus, but then it should probably be named something else than 'soc')."

So since then we didn't have soc nodes. Except in time for the RK3576, the tune has changed, so socs from then on have a soc node again ;-) .

Heiko

[0] https://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/272779.html

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#8 lore raw

Re: [PATCH v2 3/3] arm64: dts: rockchip: Add IEP2 deinterlacer to RK3588

Quoted 29 lines · Heiko Stübner

Am Montag, 16. November 2026, 13:35:28 Mitteleuropäische Normalzeit schrieb Krzysztof Kozlowski:

Quoted 20 lines · Arun Iyengar
Quoted 19 lines

Add the IEP2 deinterlacer and its IOMMU to the RK3588 base dtsi. Both share GIC SPI 117 and sit in the VDPU power domain.

Addresses, clocks, resets and the interrupt are taken from the Rockchip BSP rk3588s.dtsi (develop-6.1).

---
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi +0 -0
index aa69fd3793fd..5297519bd251 100644
@@ -1397,6 +1397,28 @@ vepu121_3_mmu: iommu@fdbac800 {
 		#iommu-cells = <0>;
 	};
 
Quoted 4 lines

arch/arm64/boot/dts/rockchip/rk3588-base.dtsi vepu121_3_mmu: iommu@fdbac800 { · line 1400

Quoted 1 line
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi +1 -0
+	iep: deinterlace@fdbb0000 {

Why all these are outside soc node? That's more of a question to existing code...

Many years back, during the RK3288 addition I got the comment from the arm-soc maintainer to drop the soc node [0]:

Quoted 7 lines

"[...] this isn't how we tend to do it any more (unless all devices are physically on a bus, but then it should probably be named something else than 'soc')."

So since then we didn't have soc nodes. Except in time for the RK3576, the tune has changed, so socs from then on have a soc node again ;-) .

I think the comment was misplaced and misunderstood. Indeed non-MMIO nodes were not supposed to be in soc. But the MMIO node are under MMIO-bus, which usually we call soc.

It's documented also writing-bindings, since 2019, though :)

Well, not a blocker for this patch and I leave it to you what to do with existing and new DTSI.

Best regards,
Krzysztof