Skip to contentSkip to conversation

software node: fix node group deregistration kernel-doc

PATCH New Johan Hovold 1 participant 1 message Nov 16

Subsystems (3)
lore
Share & tools
lore

Johan Hovold

author maintainer
#0 lore raw

PATCH 1/1 software node: fix node group deregistration kernel-doc

Child software nodes hold a reference to their parent via kobj->parent so there was never any need to deregister them in any particular order.

Drop the misleading kernel-doc comments which suggest that deregistering a parent node before a child could cause trouble.

Note that parent nodes still need to be registered before their children or registration will fail.

Fixes fc002f0f23e2 ("media: software_node: unregister software_nodes in reverse order")
Fixes 0b8bf06f6719 ("device property: Sync descriptions of swnode array and group APIs")
Cc Daniel Scally <[email protected]>
Cc Andy Shevchenko <[email protected]>
---
 drivers/base/swnode.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/base/swnode.c +1 -8
index 8e12f518e13f..78e224539b02 100644
@@ -954,14 +954,7 @@ EXPORT_SYMBOL_GPL(software_node_register_node_group);
  * software_node_unregister_node_group - Unregister a group of software nodes
  * @node_group: NULL terminated array of software node pointers to be unregistered
  *
- * Unregister multiple software nodes at once. If parent pointers are set up
- * in any of the software nodes then the array **must** be ordered such that
- * parents come before their children.
- *
- * NOTE: If you are uncertain whether the array is ordered such that
- * parents will be unregistered before their children, it is wiser to
- * remove the nodes individually, in the correct order (child before
- * parent).
+ * Unregister multiple software nodes at once.
  */
 void software_node_unregister_node_group(const struct software_node * const *node_group)
 {
Signature · 1 line
2.56.1