Skip to contentSkip to conversation

mm/damon: add paddr kunit and replace weird "same to" uses in design doc

PATCH New SJ Park 2 participants 5 messages Nov 16

Subsystems (4)
lore
Share & tools
lore

SJ Park

author maintainer
#0 lore raw

cover mm/damon: add paddr kunit and replace weird "same to" uses in design doc

Add kunit tests for physical address space DAMON operation set, via patch 1 from Avelin Noir. Use idiomatic "same as" instead of weird "same to" in design doc, via patch 2 from Enze Li.

This is a batched reposting of DAMON patches for mm.git merge request. Refer to changelog in each patch for their real changelog.

Aveline Noir (1):
mm/damon/paddr: add KUnit tests for addr_unit conversion

Enze Li (1):
Docs/mm/damon/design: replace "same to" with "same as"

 Documentation/mm/damon/design.rst | 14 ++++----
 mm/damon/Kconfig                  | 12 +++++++
 mm/damon/paddr.c                  |  2 ++
 mm/damon/tests/.kunitconfig       |  4 +++
 mm/damon/tests/paddr-kunit.h      | 55 +++++++++++++++++++++++++++++++
 5 files changed, 80 insertions(+), 7 deletions(-)
 create mode 100644 mm/damon/tests/paddr-kunit.h

base-commit: 4789d52076c67ff1ce4c66fe7ee17718a48b3bec

Signature · 1 line
2.47.3
author maintainer
#1 lore raw

PATCH 1/2 mm/damon/paddr: add KUnit tests for addr_unit conversion

From: Aveline Noir <[email protected]>

damon_pa_phys_addr() and damon_pa_core_addr() convert between DAMON core addresses and physical addresses using addr_unit. addr_unit lets 32-bit kernels with a 64-bit phys_addr_t monitor physical memory above 4 GiB, but no test covers the conversions.

Add a KUnit suite for both helpers, including a case for addresses above 4 GiB that is skipped when phys_addr_t is 32-bit.

---
Changes from v1
- v1: https://lore.kernel.org/20261109-test-damon-paddr-addr-unit-kunit-v1-1-bd10bb87be98@gmail.com
- Shorten config prompt.
- Collect R-b: from SJ.
- Rebase to the latest mm-new.

 mm/damon/Kconfig             | 12 ++++++++
 mm/damon/paddr.c             |  2 ++
 mm/damon/tests/.kunitconfig  |  4 +++
 mm/damon/tests/paddr-kunit.h | 55 ++++++++++++++++++++++++++++++++++++
 4 files changed, 73 insertions(+)
 create mode 100644 mm/damon/tests/paddr-kunit.h
mm/damon/Kconfig +12 -0
index 34631a44cdecb..a33f21c563475 100644
@@ -65,6 +65,18 @@ config DAMON_VADDR_KUNIT_TEST
 
 	  If unsure, say N.
 
+config DAMON_PADDR_KUNIT_TEST
+	bool "Tets for DAMON physical address operations" if !KUNIT_ALL_TESTS
+	depends on DAMON_PADDR && KUNIT=y
+	default KUNIT_ALL_TESTS
+	help
+	  This builds the DAMON physical address operations Kunit test suite.
+
+	  For more information on KUnit and unit tests in general, please refer
+	  to the KUnit documentation.
+
+	  If unsure, say N.
+
 config DAMON_SYSFS
 	bool "DAMON sysfs interface"
 	depends on DAMON && SYSFS
mm/damon/paddr.c +2 -0
index 5b773012a8764..e89cb14ee17be 100644
@@ -479,3 +479,5 @@ static int __init damon_pa_initcall(void)
 }
 
 subsys_initcall(damon_pa_initcall);
+
+#include "tests/paddr-kunit.h"
mm/damon/tests/.kunitconfig +4 -0
index 144d27e6ecc5c..9279f0c82be7e 100644
@@ -9,6 +9,10 @@ CONFIG_PAGE_IDLE_FLAG=y
 CONFIG_DAMON_VADDR=y
 CONFIG_DAMON_VADDR_KUNIT_TEST=y
 
+# for DAMON paddr ops
+CONFIG_DAMON_PADDR=y
+CONFIG_DAMON_PADDR_KUNIT_TEST=y
+
 # for DAMON sysfs interface
 CONFIG_SYSFS=y
 CONFIG_DAMON_SYSFS=y
mm/damon/tests/paddr-kunit.h new file +55 -0

55 lines not on this page · raw message

Signature · 1 line
2.47.3
#2 lore raw

Re: [PATCH 1/2] mm/damon/paddr: add KUnit tests for addr_unit conversion

Sashiko has reviewed this patch and found no issues.
Quoted 7 lines

From: Aveline Noir <[email protected]>

damon_pa_phys_addr() and damon_pa_core_addr() convert between DAMON core addresses and physical addresses using addr_unit. addr_unit lets 32-bit kernels with a 64-bit phys_addr_t monitor physical memory above 4 GiB, but no test covers the conversions.

Quoted 6 lines

Add a KUnit suite for both helpers, including a case for addresses above 4 GiB that is skipped when phys_addr_t is 32-bit.

Sashiko has reviewed this patch and found no issues.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
author maintainer
#3 lore raw

PATCH 2/2 Docs/mm/damon/design: replace "same to" with "same as"

In reply to SJ Park

From: Enze Li <[email protected]>

"same to" is not idiomatic; it should be "the same as" or "same as". This doc has six such usages. Fix all of them at once for consistency.

---
Changes from v1
- v1: https://lore.kernel.org/[email protected]
- Collect A-b: from Randy and R-b: from SJ.
- Rebase to the latest mm-new.

 Documentation/mm/damon/design.rst | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
Documentation/mm/damon/design.rst +7 -7
index b676be6971589..6284b90054430 100644
@@ -292,17 +292,17 @@ DAMON :ref:`context <damon_design_execution_model_and_data_structures>`.  The
 registration is made by specifying a probe per attribute.  Each of the probes
 specifies a rule to determine if a given memory region has the related
 attribute.  The rule is constructed with multiple filters.  The filters work
-same to :ref:`DAMOS filters <damon_design_damos_filters>` except the supported
-filter types.  Currently below filter types are supported.
+the same as :ref:`DAMOS filters <damon_design_damos_filters>` except the
+supported filter types.  Currently below filter types are supported.
 
-- ``anon``: Same to that for DAMOS filters.
-- ``memcg``: Same to that for DAMOS filters.
+- ``anon``: Same as that for DAMOS filters.
+- ``memcg``: Same as that for DAMOS filters.
 - ``pgidle_unset``: Matches if the page for the memory is marked as not
   access-idle.
 - ``pgidle_set``: Matches if the page for the memory is marked as access-idle.
 - ``hugepage_size``: Matches if the page for the memory is a part of a hugepage
   of a given size range.
-- ``active``: Same to that for DAMOS filters.
+- ``active``: Same as that for DAMOS filters.
 
 If such probes are registered, DAMON executes the probes for each region's
 sampling memory when it does the access :ref:`sampling
@@ -706,7 +706,7 @@ There are two such tuning algorithms that users can select as they need.
 The goal can be specified with six parameters, namely ``target_metric``,
 ``complement``, ``target_value``, ``current_value``, ``nid`` and ``path``.  The
 auto-tuning mechanism tries to make ``current_value`` of ``complement``-ed
-``target_metric`` be same to ``target_value``.
+``target_metric`` be the same as ``target_value``.
 
 - ``user_input``: User-provided value.  Users could use any metric that they
   have interest in for the value.  User space main workload's latency or
@@ -736,7 +736,7 @@ auto-tuning mechanism tries to make ``current_value`` of ``complement``-ed
 
 ``complement`` is a boolean parameter that determines whether to use
 complemented value of the target metric.  For example, if ``complement`` is set
-and target metric is ``active_mem_bp``, it is effectively same to
+and target metric is ``active_mem_bp``, it is effectively the same as
 ``inactive_mem_bp``.  ``complement`` is no-op when the target metric type is
 ``user_input``.  For the metric type, the user should be able to emit
 complemented metric values on their own.
Signature · 1 line
2.47.3
#4 lore raw

Re: [PATCH 2/2] Docs/mm/damon/design: replace "same to" with "same as"

Sashiko has reviewed this patch and found no issues.
Quoted 9 lines

From: Enze Li <[email protected]>

"same to" is not idiomatic; it should be "the same as" or "same as". This doc has six such usages. Fix all of them at once for consistency.

Sashiko has reviewed this patch and found no issues.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2