Skip to contentSkip to conversation

io_uring/kbuf: initialize arg->out_len from arg->max_len in io_buffers_select()

PATCH Applied Siddharth Chintamaneni 2 participants 2 messages Nov 16 – Nov 17 io_uring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 io_uring/kbuf: initialize arg->out_len from arg->max_len in io_buffers_select()

io_buffers_select() passes &arg->out_len to io_provided_buffers_select() on the legacy provided-buffer path. Because callers initialize arg->max_len (from sqe->len) while leaving arg->out_len as 0, io_provided_buffers_select() sees *len == 0 and always selects the full buffer size buf->len, ignoring the user-specified sqe->len limit.

Initialize arg->out_len = arg->max_len before calling io_provided_buffers_select().

Fixes 35c8711c8fc4 ("io_uring/kbuf: add helpers for getting/peeking multiple buffers")
---
 io_uring/kbuf.c | 1 +
 1 file changed, 1 insertion(+)
io_uring/kbuf.c +1 -0
index abf44f5dba26..873d66a06b36 100644
@@ -370,6 +370,7 @@ int io_buffers_select(struct io_kiocb *req, struct buf_sel_arg *arg,
 				req->flags |= REQ_F_BUF_MORE;
 		}
 	} else {
+		arg->out_len = arg->max_len;
 		ret = io_provided_buffers_select(req, &arg->out_len, sel->buf_list, arg->iovs);
 	}
 out_unlock:
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 10 lines · Siddharth Chintamaneni

io_buffers_select() passes &arg->out_len to io_provided_buffers_select() on the legacy provided-buffer path. Because callers initialize arg->max_len (from sqe->len) while leaving arg->out_len as 0, io_provided_buffers_select() sees *len == 0 and always selects the full buffer size buf->len, ignoring the user-specified sqe->len limit.

Initialize arg->out_len = arg->max_len before calling io_provided_buffers_select().

[...]

Applied, thanks!

[1/1] io_uring/kbuf: initialize arg->out_len from arg->max_len in io_buffers_select()
(no commit info)

Best regards,

Signature · 1 line
Jens Axboe