Skip to contentSkip to conversation

ALSA: hda/realtek: Don't apply the Legion Slim 7 quirk to Lenovo V14 G2 ITL

PATCH In review Arnav Kapoor 2 participants 2 messages Nov 16 – Nov 17 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda/realtek: Don't apply the Legion Slim 7 quirk to Lenovo V14 G2 ITL

The Lenovo V14 G2 ITL (82KA) has PCI SSID 17aa:380e and an ALC257 with codec SSID 17aa:38b7. No entry matches the PCI SSID, so the codec SSID fallback picks the Legion Slim 7 16APH8 entry for PCI SSID 17aa:38b7:

ALC257: picked fixup for codec SSID 17aa:38b7

That applies ALC287_FIXUP_CS35L41_I2C_2 and sets up component binding for two CS35L41 amplifiers, which this machine doesn't have; its single speaker pair is driven by the ALC257 itself (pin 0x14).

Add a codec SSID entry after the Legion one, so the Legion keeps matching on its PCI SSID first and the V14 G2 ITL gets ALC269_FIXUP_LENOVO_XPAD_ACPI, the fixup the Lenovo vendor fallback gives it when nothing else matches.

Fixes 99af5b11c57d ("ALSA: hda/realtek: enable SND_PCI_QUIRK for Lenovo Legion Slim 7 Gen 8 (2023) serie")

---
Tested on a V14 G2 ITL (BIOS GGCN55WW, 7.0 kernel) by booting with snd_sof_intel_hda_generic.hda_model=lenovo-xpad-led, which selects the same fixup this entry does: dmesg then shows "picked fixup lenovo-xpad-led (model specified)", and speakers, headphones, headset mic and internal mic all work as before. Build-tested (W=1) on next-20261113.

 sound/hda/codecs/realtek/alc269.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/hda/codecs/realtek/alc269.c +4 -0
index 96fa8c2782bb..73a89e3cbce4 100644
@@ -8605,6 +8605,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x17aa, 0x38b7, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
+	/* Lenovo V14 G2 ITL has PCI SSID 17aa:380e and codec SSID 17aa:38b7, which
+	 * falls back to the Legion Slim 7 16APH8 entry above; this must come after it
+	 */
+	HDA_CODEC_QUIRK(0x17aa, 0x38b7, "Lenovo V14 G2 ITL", ALC269_FIXUP_LENOVO_XPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x38b8, "Yoga S780-14.5 proX AMD YC Dual", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x38b9, "Yoga S780-14.5 proX AMD LX Dual", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x38ba, "Yoga S780-14.5 Air AMD quad YC", ALC287_FIXUP_TAS2781_I2C),

base-commit: 84abb955b1015477aa11a96e2f3ac1b938b77f48

Signature · 1 line
2.53.0
#1 lore raw
Quoted 11 lines · Arnav Kapoor

The Lenovo V14 G2 ITL (82KA) has PCI SSID 17aa:380e and an ALC257 with codec SSID 17aa:38b7. No entry matches the PCI SSID, so the codec SSID fallback picks the Legion Slim 7 16APH8 entry for PCI SSID 17aa:38b7:

ALC257: picked fixup for codec SSID 17aa:38b7

That applies ALC287_FIXUP_CS35L41_I2C_2 and sets up component binding for two CS35L41 amplifiers, which this machine doesn't have; its single speaker pair is driven by the ALC257 itself (pin 0x14).

Quoted 7 lines

Add a codec SSID entry after the Legion one, so the Legion keeps matching on its PCI SSID first and the V14 G2 ITL gets ALC269_FIXUP_LENOVO_XPAD_ACPI, the fixup the Lenovo vendor fallback gives it when nothing else matches.

Fixes 99af5b11c57d ("ALSA: hda/realtek: enable SND_PCI_QUIRK for Lenovo Legion Slim 7 Gen 8 (2023) serie")

Applied now. Thanks.

Takashi