Skip to contentSkip to conversation

arm64: dts: qcom: Add MSM8996 SAW3 compatible

PATCH New Rob Herring (Arm) 2 participants 5 messages Nov 17

Subsystems (4)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

v2 cover arm64: dts: qcom: Add MSM8996 SAW3 compatible

'syscon' nodes are required to have specific compatibles, but the MSM8996 SAW3 nodes are lacking one. This series adds one.

The binding should be applied with the dts changes to avoid new warnings.

Rob

---
Changes in v2:
- Change compatible to "qcom,msm8996-saw3-cbf"
- Link to v1: https://patch.msgid.link/[email protected]

---
Rob Herring (Arm) (2):
dt-bindings: mfd: syscon: Add MSM8996 SAW3 registers
arm64: dts: qcom: Add MSM8996 SAW3 syscon compatible

 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 arch/arm64/boot/dts/qcom/msm8996.dtsi             | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

---
base-commit: 749a4de370409464cf8501ec5b2451df45c84eb4
change-id: 20261112-dtbs-qcom-5f2350f0cbec

Best regards,

Signature · 1 line
Rob Herring (Arm) <[email protected]>
author maintainer
#1 lore raw

PATCH v2 1/2 dt-bindings: mfd: syscon: Add MSM8996 SAW3 registers

Add a compatible for the MSM8996 SAW3 register bank referenced through qcom,saw-reg properties. The name is based on the label in .dts files.

---
v2:
- change compatible name to qcom,msm8996-saw3-cbf

---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mfd/syscon.yaml +1 -0
index dae706ca7642..b9d6ba3393cb 100644
@@ -110,6 +110,7 @@ properties:
               - qcom,apq8064-mmss-sfpb
               - qcom,apq8064-sps-sic
               - qcom,msm8960-sps-sic
+              - qcom,msm8996-saw3-cbf
               - rockchip,px30-qos
               - rockchip,rk3036-qos
               - rockchip,rk3066-qos
Signature · 1 line
2.53.0
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add MSM8996 SAW3 registers

Sashiko has reviewed this patch and found no issues.
Quoted 6 lines

Add a compatible for the MSM8996 SAW3 register bank referenced through qcom,saw-reg properties. The name is based on the label in .dts files.

Sashiko has reviewed this patch and found no issues.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
author maintainer
#3 lore raw

PATCH v2 2/2 arm64: dts: qcom: Add MSM8996 SAW3 syscon compatible

In reply to Rob Herring (Arm)

'syscon' nodes are required to have specific compatibles. Add "qcom,msm8996-saw3-cbf" compatible to the MSM8996 SAW3 syscon block.

---
v2:
- Change compatible to "qcom,msm8996-saw3-cbf"

---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/msm8996.dtsi +1 -1
index 8873ad68e557..a75347a2d4f8 100644
@@ -3803,7 +3803,7 @@ frame@98c0000 {
 		};
 
 		saw3: syscon@9a10000 {
-			compatible = "syscon";
+			compatible = "qcom,msm8996-saw3-cbf", "syscon";
 			reg = <0x09a10000 0x1000>;
 		};
 
Signature · 1 line
2.53.0
#4 lore raw

Re: [PATCH v2 2/2] arm64: dts: qcom: Add MSM8996 SAW3 syscon compatible

Sashiko has reviewed this patch and found no issues.
Quoted 5 lines

'syscon' nodes are required to have specific compatibles. Add "qcom,msm8996-saw3-cbf" compatible to the MSM8996 SAW3 syscon block.

Sashiko has reviewed this patch and found no issues.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2