media: ipu6: Enable snooping on ipu7 isys buffers
Subsystems (2)
PATCH v2 1/1 media: ipu6: Enable snooping on ipu7 isys buffers
The capture buffers are not cache coherent by default, and CPU may read stale cache lines. Make buffers cache coherent by enabling snooping.
Reported-by Sergey Lebedev <[email protected]>
Fixes 9ab793dbc176 ("media: ipu6: Add ipu7 fw isys ops")
Signed-off-by Antti Laakso <[email protected]>
---
Changes in v2:
- Added Fixes tag.
drivers/media/pci/intel/ipu6/ipu7-fw-isys.c | 1 + 1 file changed, 1 insertion(+)
drivers/media/pci/intel/ipu6/ipu7-fw-isys.c +1 -0
@@ -214,6 +214,7 @@ static int ipu7_isys_fw_pin_cfg(struct ipu6_isys_video *av, output_pin->link.pbk_slot_id =IPU7_MSG_LINK_PBK_SLOT_ID_DONT_CARE ; output_pin->link.dest =0 ;/* IPU_INSYS_OUTPUT_LINK_DEST_MEM */ output_pin->link.use_sw_managed =1 ; + output_pin->link.is_snoop =1 ; output_pin->crop.line_top =0 ; output_pin->crop.line_bottom =0 ; output_pin->dpcm.enable =0 ;
Signature · 1 line
2.56.1
Hi Antti,
The code is the same as v1, which I tested on a Surface Pro 11:
https://lore.kernel.org/linux-media/[email protected]/
Sergey