Skip to contentSkip to conversation

arm64: dts: rockchip: Fix HDMI RX 5V detection pin on CM3588 NAS

PATCH New Tim Surber 1 participant 1 message Nov 18

Subsystems (3)
lore
Share & tools
lore

Tim Surber

author
#0 lore raw

PATCH v2 1/1 arm64: dts: rockchip: Fix HDMI RX 5V detection pin on CM3588 NAS

The HDMI receiver node uses GPIO3_D4 both as the receiver's HPD output (hdmim1_rx_hpdin) and as its 5V detection input (hpd-gpios and the hdmirx_hpd pin group). The GPIO setting wins, so the receiver can never drive HPD. Sources then see HPD asserted all the time, may read the EDID while the driver is writing it, and never notice EDID updates.

FriendlyElec's vendor device tree for the CM3588 uses GPIO1_D5, active low, for the 5V detection [1]. Use that pin and leave GPIO3_D4 to the HPD function. Tested on a CM3588 NAS with HDMI0 looped back into HDMI RX.

---
Changes in v2:
- Shorten the commit message, keep only the problem and the fix
- Drop the cover letter
- Capitalize "Fix" in the subject
- Add Cc: stable
- Link to v1: https://lore.kernel.org/linux-rockchip/[email protected]/

 .../boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts +2 -2
index f4c34da61c4d..b2df36113d22 100644
@@ -376,7 +376,7 @@ &hdmi_receiver_cma {
 };
 
 &hdmi_receiver {
-	hpd-gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_HIGH>;
+	hpd-gpios = <&gpio1 RK_PD5 GPIO_ACTIVE_LOW>;
 	pinctrl-0 = <&hdmim1_rx_cec &hdmim1_rx_hpdin &hdmim1_rx_scl &hdmim1_rx_sda &hdmirx_hpd>;
 	pinctrl-names = "default";
 	status = "okay";
@@ -571,7 +571,7 @@ hdmi1_tx_on_h: hdmi1-tx-on-h {
 
 	hdmirx {
 		hdmirx_hpd: hdmirx-5v-detection {
-			rockchip,pins = <3 RK_PD4 RK_FUNC_GPIO &pcfg_pull_up>;
+			rockchip,pins = <1 RK_PD5 RK_FUNC_GPIO &pcfg_pull_up>;
 		};
 	};
 

base-commit: a9d78db32fe78bdbe7c66ba77cb7dbb729b885de

Signature · 1 line
2.55.0