Skip to contentSkip to conversation

i2c: acpi: Force Dell XPS 17 9720 touchpad to 100 kHz

PATCH In review Mika Westerberg 3 participants 3 messages Nov 18

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 i2c: acpi: Force Dell XPS 17 9720 touchpad to 100 kHz

The Dell XPS 17 9720 touchpad has the same lagging issue as with others when run at 400 kHz as the ACPI tables describe. This particular system does not use standard ACPI ID but it seems to use "Windows Device ID" VEN_04F3 for whatever reason. Add this one to the 100 kHz quirk list as well.

---
v2: Drop the DMI match, add bugzilla link.

v1 can be found here:

https://lore.kernel.org/linux-i2c/[email protected]/

 drivers/i2c/i2c-core-acpi.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/i2c/i2c-core-acpi.c +6 -0
index 84841ed13487..64fdf8ffb5ff 100644
@@ -377,6 +377,12 @@ static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	{ .id = "ELAN0678" },
 	{ .id = "ELAN06FA" },
 	{ .id = "ELAN1300" },
+	/*
+	 * This is non-standard ACPI ID used by some Dell XPS 17 9720
+	 * systems. They do have the same issue when used with 400 kHz so
+	 * force 100 kHz.
+	 */
+	{ .id = "VEN_04F3" },
 	{ }
 };
 
Signature · 1 line
2.50.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 5 lines · Mika Westerberg

The Dell XPS 17 9720 touchpad has the same lagging issue as with others when run at 400 kHz as the ACPI tables describe. This particular system does not use standard ACPI ID but it seems to use "Windows Device ID" VEN_04F3 for whatever reason. Add this one to the 100 kHz quirk list as well.

LGTM,

Quoted 1 line

Unreferred link tag. What I read on it sounds like also a candidate for Closes tag rather than Link.

Quoted 2 lines
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Reviewed-by on v2 1/1
#2 lore raw
In reply to Mika Westerberg

Hi,

Quoted 10 lines · Mika Westerberg

The Dell XPS 17 9720 touchpad has the same lagging issue as with others when run at 400 kHz as the ACPI tables describe. This particular system does not use standard ACPI ID but it seems to use "Windows Device ID" VEN_04F3 for whatever reason. Add this one to the 100 kHz quirk list as well.

Thanks, patch looks good to me:

Regards,

Hans

Quoted 27 lines

---
v2: Drop the DMI match, add bugzilla link.

v1 can be found here:

https://lore.kernel.org/linux-i2c/[email protected]/

 drivers/i2c/i2c-core-acpi.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/i2c/i2c-core-acpi.c +6 -0
index 84841ed13487..64fdf8ffb5ff 100644
@@ -377,6 +377,12 @@ static const struct acpi_device_id i2c_acpi_force_100khz_device_ids[] = {
 	{ .id = "ELAN0678" },
 	{ .id = "ELAN06FA" },
 	{ .id = "ELAN1300" },
+	/*
+	 * This is non-standard ACPI ID used by some Dell XPS 17 9720
+	 * systems. They do have the same issue when used with 400 kHz so
+	 * force 100 kHz.
+	 */
+	{ .id = "VEN_04F3" },
 	{ }
 };