Skip to contentSkip to conversation

xfs: add tests using xfs_admin to the admin group

PATCH In review Andrey Albershteyn 2 participants 2 messages Nov 19 – Nov 21

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: add tests using xfs_admin to the admin group

So far, only xfs/156 and xfs/157 are in admin group. Let's include all the tests which use this script into the group. This script is not that complex, so, this increased coverage would help with testing '-g admin'.

---
 tests/xfs/158 | 2 +-
 tests/xfs/160 | 2 +-
 tests/xfs/161 | 2 +-
 tests/xfs/287 | 2 +-
 tests/xfs/548 | 2 +-
 tests/xfs/612 | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
tests/xfs/158 +1 -1
index 89bf8c851659..7b218ec09486 100755
@@ -8,7 +8,7 @@
 # everything works properly after the upgrade.
 
 . ./common/preamble
-_begin_fstest auto quick inobtcount
+_begin_fstest auto quick inobtcount admin
 
 # Import common functions.
 . ./common/filter
tests/xfs/160 +1 -1
index 8cc784e7e1dc..d62b305e4d25 100755
@@ -8,7 +8,7 @@
 # timestamps work properly after the upgrade.
 
 . ./common/preamble
-_begin_fstest auto quick bigtime
+_begin_fstest auto quick bigtime admin
 
 # Import common functions.
 . ./common/filter
tests/xfs/161 +1 -1
index c35bcabb5eda..bcbc2f951f9d 100755
@@ -9,7 +9,7 @@
 # commit 16b60cb9e315ed for this test to run properly; v4.06 should do.
 
 . ./common/preamble
-_begin_fstest auto quick bigtime quota
+_begin_fstest auto quick bigtime quota admin
 
 # Import common functions.
 . ./common/filter
tests/xfs/287 +1 -1
index 4537b040f3cd..d8a1e5379721 100755
@@ -8,7 +8,7 @@
 # xfs_db functionality
 #
 . ./common/preamble
-_begin_fstest auto dump quota quick
+_begin_fstest auto dump quota quick admin
 
 # Import common functions.
 . ./common/quota
tests/xfs/548 +1 -1
index af72885a9c6e..779db614c0e6 100755
@@ -8,7 +8,7 @@
 # counters.
 #
 . ./common/preamble
-_begin_fstest auto quick metadata
+_begin_fstest auto quick metadata admin
 
 # Import common functions.
 . ./common/filter
tests/xfs/612 +1 -1
index 4bead570009a..5fc1d0813ac0 100755
@@ -7,7 +7,7 @@
 # Check that we can upgrade v5 only features on a v4 file system
 
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick admin
 
 # Import common functions.
 . ./common/filter
Signature · 1 line
2.54.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andrey Albershteyn

So far, only xfs/156 and xfs/157 are in admin group. Let's include all the tests which use this script into the group. This script is not that complex, so, this increased coverage would help with testing '-g admin'.

---

Good to me,

Quoted 89 lines
 tests/xfs/158 | 2 +-
 tests/xfs/160 | 2 +-
 tests/xfs/161 | 2 +-
 tests/xfs/287 | 2 +-
 tests/xfs/548 | 2 +-
 tests/xfs/612 | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
tests/xfs/158 +1 -1
index 89bf8c851659..7b218ec09486 100755
@@ -8,7 +8,7 @@
 # everything works properly after the upgrade.
 
 . ./common/preamble
-_begin_fstest auto quick inobtcount
+_begin_fstest auto quick inobtcount admin
 
 # Import common functions.
 . ./common/filter
tests/xfs/160 +1 -1
index 8cc784e7e1dc..d62b305e4d25 100755
@@ -8,7 +8,7 @@
 # timestamps work properly after the upgrade.
 
 . ./common/preamble
-_begin_fstest auto quick bigtime
+_begin_fstest auto quick bigtime admin
 
 # Import common functions.
 . ./common/filter
tests/xfs/161 +1 -1
index c35bcabb5eda..bcbc2f951f9d 100755
@@ -9,7 +9,7 @@
 # commit 16b60cb9e315ed for this test to run properly; v4.06 should do.
 
 . ./common/preamble
-_begin_fstest auto quick bigtime quota
+_begin_fstest auto quick bigtime quota admin
 
 # Import common functions.
 . ./common/filter
tests/xfs/287 +1 -1
index 4537b040f3cd..d8a1e5379721 100755
@@ -8,7 +8,7 @@
 # xfs_db functionality
 #
 . ./common/preamble
-_begin_fstest auto dump quota quick
+_begin_fstest auto dump quota quick admin
 
 # Import common functions.
 . ./common/quota
tests/xfs/548 +1 -1
index af72885a9c6e..779db614c0e6 100755
@@ -8,7 +8,7 @@
 # counters.
 #
 . ./common/preamble
-_begin_fstest auto quick metadata
+_begin_fstest auto quick metadata admin
 
 # Import common functions.
 . ./common/filter
tests/xfs/612 +1 -1
index 4bead570009a..5fc1d0813ac0 100755
@@ -7,7 +7,7 @@
 # Check that we can upgrade v5 only features on a v4 file system
 
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick admin
 
 # Import common functions.
 . ./common/filter
Signature · 1 line
2.54.0