Skip to contentSkip to conversation

scsi: pm8001: Fix abort completion status in pm8001_mpi_task_abort_resp()

PATCH New Ian Rogers 1 participant 1 message Nov 19

Subsystems (2)
lore
Share & tools
lore

Ian Rogers

author
#0 lore raw

PATCH 1/1 scsi: pm8001: Fix abort completion status in pm8001_mpi_task_abort_resp()

In pm8001_mpi_task_abort_resp(), the IO_NOT_VALID branch assigns TMF_RESP_FUNC_FAILED (enum tmf_resp, 5) to ts->resp (enum service_response) instead of ts->stat, leaving ts->stat at 0. In addition, switch (status) has no default case, so any other non-zero firmware abort failure status leaves both ts->resp and ts->stat at their zero-initialized values (SAS_TASK_COMPLETE and SAS_SAM_STAT_GOOD), causing sas_execute_internal_abort() to falsely treat a failed abort as TMF_RESP_FUNC_COMPLETE.

Set ts->resp = SAS_TASK_COMPLETE and ts->stat = TMF_RESP_FUNC_FAILED for both IO_NOT_VALID and default failure statuses, matching libsas and hisi_sas expectations.

Found via Clang -Wassign-enum on an x86_64 allyesconfig build. Verified by building drivers/scsi/pm8001/pm8001_hwi.o with LLVM=1 W=1 (-Werror) and -Wassign-enum, and with a standalone C reproducer under ASan/UBSan; not runtime-tested on physical PM8001/PM80xx hardware.

Fixes dbf9bfe61571 ("[SCSI] pm8001: add SAS/SATA HBA driver")
---
 drivers/scsi/pm8001/pm8001_hwi.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/scsi/pm8001/pm8001_hwi.c +6 -1
index 55a01e533fd1..b8c59c152d89 100644
@@ -3478,7 +3478,12 @@ int pm8001_mpi_task_abort_resp(struct pm8001_hba_info *pm8001_ha, void *piomb)
 		break;
 	case IO_NOT_VALID:
 		pm8001_dbg(pm8001_ha, FAIL, "IO_NOT_VALID for tag %#x\n", tag);
-		ts->resp = TMF_RESP_FUNC_FAILED;
+		ts->resp = SAS_TASK_COMPLETE;
+		ts->stat = TMF_RESP_FUNC_FAILED;
+		break;
+	default:
+		ts->resp = SAS_TASK_COMPLETE;
+		ts->stat = TMF_RESP_FUNC_FAILED;
 		break;
 	}
 	spin_lock_irqsave(&t->task_state_lock, flags);
Signature · 1 line
2.56.1.708.g77570a6a1d-goog