Skip to contentSkip to conversation

staging: octeon: Align function parameters

PATCH Superseded S Tarun Kumar Lywait 2 participants 4 messages Nov 15 – Nov 20 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: octeon: Align function parameters

Align the function parameters to the open parantheis and change the parameter "pko_command" to "pko_cmd", so that it doesn't exceed Col 100.

Issue reported by checkpatch:

CHECK: Alignment should match open parenthesis

---
 drivers/staging/octeon/octeon-stubs.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/octeon/octeon-stubs.h +4 -2
index 9c1968b7e..cc1204e20 100644
@@ -1387,8 +1387,10 @@ static inline void cvmx_pko_send_packet_prepare(u64 port, u64 queue,
 { }
 
 static inline enum cvmx_pko_status cvmx_pko_send_packet_finish(u64 port,
-		u64 queue, union cvmx_pko_command_word0 pko_command,
-		union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking)
+							       u64 queue,
+							       union cvmx_pko_command_word0 pko_cmd,
+							       union cvmx_buf_ptr packet,
+							       enum cvmx_pko_lock use_locking)
 {
 	return 0;
 }
Signature · 1 line
2.47.3
maintainer
#1 lore raw
Quoted 1 line · S Tarun Kumar Lywait

Align the function parameters to the open parantheis and change the parameter "pko_command" to "pko_cmd", so that it doesn't exceed Col 100.

But this line does :(

#2 lore raw
Quoted 6 lines · Greg KH
Quoted 1 line · S Tarun Kumar Lywait

Align the function parameters to the open parantheis and change the parameter "pko_command" to "pko_cmd", so that it doesn't exceed Col 100.

But this line does :(

Hi,

I am sending a v2 patch with the correction you mentioned. Thanks

#3 lore raw

PATCH v2 1/1 staging: octeon: Align function parameters

Align the function parameters to the open paranthesis and change the parameter "pko_command" to "pko_cmd", so that it doesn't exceed Col 100.

Issue reported by checkpatch:

CHECK: Alignment should match open parenthesis

---
 drivers/staging/octeon/octeon-stubs.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/octeon/octeon-stubs.h +4 -2
index 9c1968b7e..cc1204e20 100644
@@ -1387,8 +1387,10 @@ static inline void cvmx_pko_send_packet_prepare(u64 port, u64 queue,
 { }
 
 static inline enum cvmx_pko_status cvmx_pko_send_packet_finish(u64 port,
-		u64 queue, union cvmx_pko_command_word0 pko_command,
-		union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking)
+							       u64 queue,
+							       union cvmx_pko_command_word0 pko_cmd,
+							       union cvmx_buf_ptr packet,
+							       enum cvmx_pko_lock use_locking)
 {
 	return 0;
 }
Signature · 1 line
2.47.3