mfd: Fix unmet dependency warning for MFD_TPS68470
Subsystems (4)
PATCH 1/2 mfd: Fix unmet dependency warning for MFD_TPS68470
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly.
WARNING: unmet direct dependencies detected for I2C_DESIGNWARE_PLATFORM
Depends on [n]: I2C [=y] && HAS_IOMEM [=y] && (ACPI [=y] && COMMON_CLK [=n] || !ACPI [=y]) Selected by [y]:
- MFD_TPS68470 [=y] && HAS_IOMEM [=y] && ACPI [=y] && I2C [=y]=y
MFD_TPS68470 is an ACPI only device and selects I2C_DESIGNWARE_PLATFORM. I2C_DESIGNWARE_PLATFORM does not have any configuration today for ACPI support without CONFIG_PCI set.
For sake of a quick fix this introduces a new mandatory dependency to the driver which may survive without it. Otherwise we need to revisit the driver architecture to address this properly.
--- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/Kconfig +1 -1
@@ -1419,7 +1419,7 @@ config MFD_TPS65217 config MFD_TPS68470 bool "TI TPS68470 Power Management / LED chips" - depends on ACPI && I2C=y + depends on ACPI && PCI && I2C=y select MFD_CORE select REGMAP_I2C select I2C_DESIGNWARE_PLATFORM
Signature · 1 line
2.19.0
PATCH 2/2 x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly.
PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been mentioned in the Kconfig.
Add an explicit dependency here.
--- arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/Kconfig +1 -1
@@ -199,7 +199,7 @@ config X86 select IRQ_FORCED_THREADING select NEED_SG_DMA_LENGTH select PCI_DOMAINS if PCI - select PCI_LOCKLESS_CONFIG + select PCI_LOCKLESS_CONFIG if PCI select PERF_EVENTS select RTC_LIB select RTC_MC146818_LIB
Signature · 1 line
2.19.0
Borislav Petkov
maintainerRe: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
Quoted 22 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly.
PCI_LOCKLESS_CONFIGdepends on PCI but this dependency has not been mentioned in theKconfig.Add an explicit dependency here.
Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/Kconfig +0
-0
arch/x86/Kconfig config X86 · line 205
Quoted 8 lines
arch/x86/Kconfig +1
-1@@ -199,7 +199,7 @@ config X86 select IRQ_FORCED_THREADING select NEED_SG_DMA_LENGTH select PCI_DOMAINS if PCI - select PCI_LOCKLESS_CONFIG + select PCI_LOCKLESS_CONFIG if PCI select PERF_EVENTS select RTC_LIB select RTC_MC146818_LIB
AFAICT, this is not really fixing a random config build issue but only correcting the dependency, right?
Signature · 4 lines
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
Quoted 27 lines · Borislav Petkov
Quoted 26 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly.
PCI_LOCKLESS_CONFIGdepends on PCI but this dependency has not been mentioned in theKconfig.Add an explicit dependency here.
Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCIset")
Signed-off-by Sinan Kaya <[email protected]>--- arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/Kconfig +0
-1@@ -199,7 +199,7 @@ config X86 select IRQ_FORCED_THREADING select NEED_SG_DMA_LENGTH select PCI_DOMAINS if PCI - select PCI_LOCKLESS_CONFIG
Quoted 9 lines
arch/x86/Kconfig config X86
Quoted 5 lines
arch/x86/Kconfig +1
-1+ select PCI_LOCKLESS_CONFIG if PCI select PERF_EVENTS select RTC_LIB select RTC_MC146818_LIB --AFAICT, this is not really fixing a random config build issue but only correcting the dependency, right?
This is fixing a warning found by randconfig on this thread 'linux-next: Tree for Jan 16 (PCI config warning?)'
Quoted 6 lines
--
Regards/Gruss,
Boris.Good mailing practices for 400: avoid top-posting and trim the reply.
tip-bot for Sinan Kaya
merge bot[tip:x86/urgent] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
In reply to Sinan Kayax86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
Commit-ID: 625210cfa6c0c26ea422f655bf68288176f174e6 Gitweb: https://git.kernel.org/tip/625210cfa6c0c26ea422f655bf68288176f174e6 Author: Sinan Kaya <[email protected]> AuthorDate: Mon, 21 Jan 2019 23:19:58 +0000 Committer: Borislav Petkov <[email protected]> CommitDate: Tue, 22 Jan 2019 17:06:28 +0100
x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
After commit
5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly.
PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been mentioned in the Kconfig so add an explicit dependency here and fix
WARNING: unmet direct dependencies detected for PCI_LOCKLESS_CONFIG
Depends on [n]: PCI [=n]
Selected by [y]:
- X86 [=y]
--- arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/Kconfig +1 -1
@@ -198,7 +198,7 @@ config X86 select IRQ_FORCED_THREADING select NEED_SG_DMA_LENGTH select PCI_DOMAINS if PCI - select PCI_LOCKLESS_CONFIG + select PCI_LOCKLESS_CONFIG if PCI select PERF_EVENTS select RTC_LIB select RTC_MC146818_LIB
Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
In reply to Sinan KayaQuoted 22 lines · CET Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly.
PCI_LOCKLESS_CONFIGdepends on PCI but this dependency has not been mentioned in theKconfig.Add an explicit dependency here.
Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/Kconfig +0
-0
arch/x86/Kconfig config X86 · line 205
Quoted 8 lines
arch/x86/Kconfig +1
-1@@ -199,7 +199,7 @@ config X86 select IRQ_FORCED_THREADING select NEED_SG_DMA_LENGTH select PCI_DOMAINS if PCI - select PCI_LOCKLESS_CONFIG + select PCI_LOCKLESS_CONFIG if PCI select PERF_EVENTS select RTC_LIB select RTC_MC146818_LIB
Is anyone taking this or should I?
Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
Quoted 5 lines · Rafael J. Wysocki
Quoted 1 line
Is anyone taking this or should I?
This got applied:
https://git.kernel.org/tip/625210cfa6c0c26ea422f655bf68288176f174e6
Quoted 30 lines · CET Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly.WARNING: unmet direct dependencies detected for
I2C_DESIGNWARE_PLATFORM
Depends on [n]: I2C [=y] &&HAS_IOMEM[=y] && (ACPI [=y] &&COMMON_CLK[=n] || !ACPI [=y]) Selected by [y]:
-MFD_TPS68470[=y] &&HAS_IOMEM[=y] && ACPI [=y] && I2C [=y]=y
MFD_TPS68470is an ACPI only device and selectsI2C_DESIGNWARE_PLATFORM.I2C_DESIGNWARE_PLATFORMdoes not have any configuration today for ACPI support withoutCONFIG_PCIset.For sake of a quick fix this introduces a new mandatory dependency to the driver which may survive without it. Otherwise we need to revisit the driver architecture to address this properly.
Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mfd/Kconfig +0
-0
drivers/mfd/Kconfig config MFD_TPS65217 · line 1425
Quoted 8 lines
drivers/mfd/Kconfig +1
-1@@ -1419,7 +1419,7 @@ config MFD_TPS65217 config MFD_TPS68470 bool "TI TPS68470 Power Management / LED chips" - depends on ACPI && I2C=y + depends on ACPI && PCI && I2C=y select MFD_CORE select REGMAP_I2C select I2C_DESIGNWARE_PLATFORM
Is anyone taking this or should I?
Quoted 1 line · Rafael J. Wysocki
Is anyone taking this or should I?
Nobody replied to this yet. I was hoping this series to go through acpi tree like the rest of the other fixes.
Lee Jones
Acked-byQuoted 5 lines · Sinan Kaya
Quoted 1 line · Rafael J. Wysocki
Is anyone taking this or should I?
Nobody replied to this yet. I was hoping this series to go through acpi tree like the rest of the other fixes.
[post-vacation reply]
That's not how these things are usually handled, but I taking into consideration the trivialises of the patch, I don't really mind.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Rafael J. Wysocki
AppliedQuoted 8 lines · CET Lee Jones
Quoted 5 lines · Sinan Kaya
Quoted 1 line · Rafael J. Wysocki
Is anyone taking this or should I?
Nobody replied to this yet. I was hoping this series to go through acpi tree like the rest of the other fixes.
Quoted 6 lines
[post-vacation reply]
That's not how these things are usually handled, but I taking into consideration the trivialises of the patch, I don't really mind.
Acked-by Lee Jones <[email protected]>
I've applied this one, thanks!