lib: add tst_no_corefile to avoid corefile dumping
PATCH v2 1/1 lib: add tst_no_corefile to avoid corefile dumping
If crash is expected in a testcase, we can avoid dumping core file in calling this function.
---
Notes:
v1 --> v2
* add a paramenter to hide the message print
* add notes in test-writing-guidelines.txt
doc/test-writing-guidelines.txt | 14 ++++++++++++-- include/tst_safe_macros.h | 18 ++++++++++++++++++ .../kernel/security/umip/umip_basic_test.c | 2 ++ testcases/kernel/syscalls/ipc/shmat/shmat01.c | 16 +++------------- 4 files changed, 35 insertions(+), 15 deletions(-)
doc/test-writing-guidelines.txt +12 -2
@@ -826,8 +826,8 @@ The 'TST_PROCESS_STATE_WAIT()' waits until process 'pid' is in requested It's mostly used with state 'S' which means that process is sleeping in kernel for example in 'pause()' or any other blocking syscall. -2.2.10 Signal handlers -^^^^^^^^^^^^^^^^^^^^^^ +2.2.10 Signals and signal handlers +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ If you need to use signal handlers, keep the code short and simple. Don't forget that the signal handler is called asynchronously and can interrupt the
@@ -859,6 +859,16 @@ type defined in C99 but this one *DOES NOT* imply 'volatile' (it's just a 'typedef' to 'int'). So the correct type for a flag that is changed from a signal handler is either 'volatile int' or 'volatile sig_atomic_t'. +If a crash (e.g. triggered by signal SIGSEGV) is expected in testing, you can +avoid dumping core file via calling this below tst_no_corefile() function. +Note that this chanage will only effect on that process with this invoke. And +the parameter 'verbose' is used as message print option. + +[source,c] +------------------------------------------------------------------------------- +void tst_no_corefile(int verbose); +------------------------------------------------------------------------------- + 2.2.11 Kernel Modules ^^^^^^^^^^^^^^^^^^^^^
include/tst_safe_macros.h +18 -0
@@ -394,6 +394,24 @@ static inline int safe_setrlimit(const char *file, const int lineno,#define SAFE_SETRLIMIT (resource, rlim) \ safe_setrlimit(__FILE__, __LINE__, (resource), (rlim)) +/* +* Crash is expected, avoid dumping corefile. +* 1 is a special value, that disables core-to-pipe. +* At the same time it is small enough value for +* core-to-file, so it skips creating cores as well. +*/ +static inline void tst_no_corefile (int verbose) +{ +struct rlimit r; + + r.rlim_cur =1 ; + r.rlim_max =1 ; +SAFE_SETRLIMIT (RLIMIT_CORE , &r); + +if (verbose) +tst_res (TINFO ,"Avoid dumping corefile in process(%d)" ,getpid ()); +} +typedef void (*sighandler_t )(int );static inline sighandler_t safe_signal (const char *file,const int lineno,int signum,sighandler_t handler)
testcases/kernel/security/umip/umip_basic_test.c +2 -0
@@ -86,6 +86,8 @@ static void verify_umip_instruction(unsigned int n) pid =SAFE_FORK ();if (pid ==0 ) { +tst_no_corefile (0 ); +switch (n) {case 0 :asm_sgdt ();
testcases/kernel/syscalls/ipc/shmat/shmat01.c +3 -13
@@ -59,19 +59,9 @@ static void *expected_addr(void *in_addr, void *out_addr)static void do_child (int *in_addr,int expect_crash) { -if (expect_crash) { -/* -* Crash is expected, avoid dumping corefile. -* 1 is a special value, that disables core-to-pipe. -* At the same time it is small enough value for -* core-to-file, so it skips creating cores as well. -*/ -struct rlimit r; - - r.rlim_cur =1 ; - r.rlim_max =1 ; -SAFE_SETRLIMIT (RLIMIT_CORE , &r); - } +if (expect_crash) +tst_no_corefile (1 ); + *in_addr =10 ;exit (0 );
Signature · 1 line
2.20.1
PATCH v2 1/1 lib: add tst_no_corefile to avoid corefile dumping
----- Original Message -----
Quoted 46 lines
If crash is expected in a testcase, we can avoid dumping core file in calling this function.
Signed-off-by Li Wang <[email protected]>Cc Jan Stancek <[email protected]>---
Notes:
v1 --> v2
* add a paramenter to hide the message print
* add notes in test-writing-guidelines.txtdoc/test-writing-guidelines.txt | 14 ++++++++++++-- include/tst_safe_macros.h | 18 ++++++++++++++++++ .../kernel/security/umip/umip_basic_test.c | 2 ++ testcases/kernel/syscalls/ipc/shmat/shmat01.c | 16 +++------------- 4 files changed, 35 insertions(+), 15 deletions(-)doc/test-writing-guidelines.txt +0
-0@@ -826,8 +826,8 @@ The 'TST_PROCESS_STATE_WAIT()' waits until process 'pid'is in requested
It's mostly used with state 'S' which means that process is sleeping in kernel
for example in 'pause()' or any other blocking syscall.-2.2.10 Signal handlers
-^^^^^^^^^^^^^^^^^^^^^^
+2.2.10 Signals and signal handlers
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^If you need to use signal handlers, keep the code short and simple. Don't forget that the signal handler is called asynchronously and can interrupt the
doc/test-writing-guidelines.txt +0
-0@@ -859,6 +859,16 @@ type defined in C99 but this one *DOES NOT* imply'volatile' (it's just a
'typedef' to 'int'). So the correct type for a flag that is changed from a signal handler is either 'volatile int' or 'volatilesig_atomic_t'.+If a crash (e.g. triggered by signal SIGSEGV) is expected in testing, you can
doc/test-writing-guidelines.txt +2
-0+avoid dumping core file via calling this below tst_no_corefile() function. +Note that this chanage will only effect on that process with this invoke.
Quoted 1 line
And
I'd rephrase it to:
If a crash (e.g. triggered by signal SIGSEGV) is expected in testing, you can avoid creation of core files by calling tst_no_corefile() function. This takes effect for process (and its children) which invoked it, unless they subsequently modify RLIMIT_CORE.
Note that LTP library will reap any processes that test didn't reap itself, and report any non-zero exit code as failure.
One note below.
Quoted 22 lines
doc/test-writing-guidelines.txt +7
-0+the parameter 'verbose' is used as message print option. + +[source,c] +------------------------------------------------------------------------------- +void tst_no_corefile(int verbose); +------------------------------------------------------------------------------- + 2.2.11 Kernel Modules ^^^^^^^^^^^^^^^^^^^^^include/tst_safe_macros.h +3
-0@@ -394,6 +394,24 @@ static inline int safe_setrlimit(const char *file, const int lineno, #define SAFE_SETRLIMIT(resource, rlim) \ safe_setrlimit(__FILE__, __LINE__, (resource), (rlim)) +/* +* Crash is expected, avoid dumping corefile. +* 1 is a special value, that disables core-to-pipe.
include/tst_safe_macros.h static inline int safe_setrlimit(const char *file, const · line 410
Quoted 10 lines
include/tst_safe_macros.h +10
-0+* At the same time it is small enough value for +* core-to-file, so it skips creating cores as well. +*/ +static inline void tst_no_corefile (int verbose) +{ +struct rlimit r; + + r.rlim_cur =1 ; + r.rlim_max =1 ; +SAFE_SETRLIMIT (RLIMIT_CORE , &r);
SAFE_SETRLIMIT is fine if needs_root = 1. But if test runs as unprivileged user and RLIMIT_CORE is already 0, unprivileged user won't be able to increase it, so we get TBROK here.
PATCH v2 1/1 lib: add tst_no_corefile to avoid corefile dumping
Quoted 10 lines · Jan Stancek
I'd rephrase it to:
If a crash (e.g. triggered by signal SIGSEGV) is expected in testing,
you
can avoid creation of core files by callingtst_no_corefile()function. This takes effect for process (and its children) which invoked it,
unless
they subsequently modifyRLIMIT_CORE.
Quoted 4 lines
Note that LTP library will reap any processes that test didn't reap
itself,
and report any non-zero exit code as failure.
This looks better, I missed the effect to its children before.
Quoted 5 lines
Quoted 5 lines
include/tst_safe_macros.h +5
-0+static inline void tst_no_corefile (int verbose) +{ +struct rlimit r; + + r.rlim_cur =1 ;
Quoted 9 lines
include/tst_safe_macros.h static inline int safe_setrlimit(const char *file, const int lineno, · line 409
Quoted 2 lines
include/tst_safe_macros.h +2
-0+ r.rlim_max =1 ; +SAFE_SETRLIMIT (RLIMIT_CORE , &r);
SAFE_SETRLIMITis fine ifneeds_root= 1. But if test runs as unprivileged user
andRLIMIT_COREis already 0, unprivileged user won't be able to increase it,
so we get TBROK here.
You are right. The SAFE_SETRLIMIT is not good for that achievement. I will make use of the original type and do error handle with TWARN slightly. And then I think we probably need to move it out form tst_safe_mcro.h.
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20190705/75430c48/attachment.htm>