Skip to contentSkip to conversation

Core support for Marvell Armada 375 and 38x

PATCH Superseded Thomas Petazzoni 4 participants 23 messages Feb 13, 2014 – Feb 17, 2014

Subsystems (6)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover Core support for Marvell Armada 375 and 38x

Jason, Andrew, Sebastian, Gregory,

Here comes the v3 of the Armada 375/38x core support.

Changes since v2
================

* Integrated the support of Armada 375 and Armada 38x in the same "board file" as Armada 370/XP, as suggested by Arnd Bergmann. In order to achieve this, I've renamed armada-370-xp.c to armada-mvebu.c, and done corresponding minor cleanups before introducing Armada 375/38x support.

* Made the data abort workaround check for a specific FSR value, as suggested by Arnd Bergmann. Checking for the address is not possible, because it changes from one boot to the other.

* Removed unnecessary duplicated aliases for i2c and spi nodes (between .dtsi and .dts). Requested by Arnd Bergmann.

* Added aliases for network interfaces, like we already have for Armada 370 and XP.

Changes since v1
================

* Merged armada-375.c and armada-38x.c into one file, as suggested by Andrew Lunn.

* Do not require the introduction of new compatible strings in the drivers for the timer, mbus and the 38x system controller (the 375 system controller being different, adding a different compatible string is needed). The .dtsi files have been updated to use several compatible strings: one designating the new SoC, and another one designating the older SoC with which they are compatible as far as we know today. Suggested by Jason Cooper and confirmed by Grant Likely.

* Rename the Kconfig symbol from MACH_ARMADA_380 to MACH_ARMADA_38X, as suggested by Andrew Lunn.

* Use <dt-bindings/gpio/gpio.h> defines instead of hardcoded values in armada-375-db.dts. Suggested by Andrew Lunn.

Original cover letter
=====================

Here is a set of 11 patches that add minimal support for the new Marvell Armada 375 and 38x SoCs. The Armada 375 has already been announced a few months ago by Marvell, and a product brief is available at
http://www.marvell.com/embedded-processors/armada-375/. As far as I know, the Armada 380 and 385 have not yet been announced, but we already have working kernel support for them.

Essentially, the Armada 375 is a dual-core Cortex-A9, which re-uses most of the IP blocks of the Armada XP, except for the network unit and core parts of the SoC, such as the interrupt controller or cache controller (GIC and PL310 are used). They also added an XHCI USB 3.0 controller.

The Armada 380 and 385 also use Cortex-A9 CPU cores (single core for the 380 and dual-core for the 385), but move a little further away than 375 in terms of peripherals: an AHCI-compatible SATA interface, a different MMC/SDIO interface, etc.

This set of patches only add minimal support for these SOCs, as well as support for the peripherals for which no driver changes are needed. We therefore have support for:

* Device Bus
* Clocks
* Interrupt controllers: GIC and MPIC
* GPIO controllers
* I2C buses
* SPI buses
* L2 cache
* MBus controller
* SDIO (for Armada 375 only)
* Pinctrl
* SATA (for Armada 375 only)
* Serial
* System controller
* XOR engines
* PCIe controllers
* Network (for Armada 38x only)

Some of these features require patches to other subsystems, and the patches are being sent to the respective maintainers currently: clock driver patches, pinctrl driver patches, irqchip driver patches, mbus driver patches, etc. There is however no build dependency between the arch/arm/mach-mvebu/ code and those other patches.

We aim at getting this minimal support merged for 3.15.

We have already working code for many more features, such as SMP, coherency support, NAND, SATA and SDIO for Armada 380, etc. We will be sending those additional features once the basic support has been merged.

It is worth noting that contrary to the Marvell 370 and XP support, which has been pushed mainline fairly late in the development cycle of the SOCs, the support for Armada 375 and 38x is now being pushed quite early in the development cycle of the SOCs. We are having mainline support pretty much at the same time as the SOCs are being made available to customers, which is really great!

Best regards,

Thomas

Gregory CLEMENT (2):
ARM: mvebu: add initial support for the Armada 375 SOCs
ARM: mvebu: add Device Tree description of the Armada 375 SoC

Thomas Petazzoni (11):
ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c
ARM: mvebu: rename DT machine structure for Armada 370/XP
ARM: mvebu: make CPU_PJ4B selection a per-SoC choice
ARM: mvebu: add Armada 375 support to the system-controller driver
ARM: mvebu: add workaround for data abort issue on Armada 375
ARM: mvebu: add Device Tree for the Armada 375 DB board
ARM: mvebu: add initial support for the Armada 380/385 SOCs
ARM: mvebu: add Device Tree description of the Armada 380/385 SoCs
ARM: mvebu: add Device Tree for the Armada 385 DB board
ARM: mvebu: update defconfigs for Armada 375 and 38x
Documentation: arm: update Marvell documentation about Armada 375/38x

 Documentation/arm/Marvell/README                   |  12 +-
 .../devicetree/bindings/arm/armada-375.txt         |   9 +
 .../devicetree/bindings/arm/armada-38x.txt         |  10 +
 .../bindings/arm/mvebu-system-controller.txt       |   3 +-
 arch/arm/boot/dts/Makefile                         |   2 +
 arch/arm/boot/dts/armada-375-db.dts                | 107 +++++
 arch/arm/boot/dts/armada-375.dtsi                  | 439 +++++++++++++++++++++
 arch/arm/boot/dts/armada-380.dtsi                  | 117 ++++++
 arch/arm/boot/dts/armada-385-db.dts                | 101 +++++
 arch/arm/boot/dts/armada-385.dtsi                  | 149 +++++++
 arch/arm/boot/dts/armada-38x.dtsi                  | 345 ++++++++++++++++
 arch/arm/configs/multi_v7_defconfig                |   2 +
 arch/arm/configs/mvebu_defconfig                   |   2 +
 arch/arm/mach-mvebu/Kconfig                        |  37 +-
 arch/arm/mach-mvebu/Makefile                       |   2 +-
 .../mach-mvebu/{armada-370-xp.c => armada-mvebu.c} |  62 ++-
 arch/arm/mach-mvebu/system-controller.c            |  14 +-
 17 files changed, 1397 insertions(+), 16 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/armada-375.txt
 create mode 100644 Documentation/devicetree/bindings/arm/armada-38x.txt
 create mode 100644 arch/arm/boot/dts/armada-375-db.dts
 create mode 100644 arch/arm/boot/dts/armada-375.dtsi
 create mode 100644 arch/arm/boot/dts/armada-380.dtsi
 create mode 100644 arch/arm/boot/dts/armada-385-db.dts
 create mode 100644 arch/arm/boot/dts/armada-385.dtsi
 create mode 100644 arch/arm/boot/dts/armada-38x.dtsi
 rename arch/arm/mach-mvebu/{armada-370-xp.c => armada-mvebu.c} (57%)
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH v3 1/13 ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c

In preparation to the introduction of the support of Armada 375 and Armada 38x, this commit renames arch/arm/mach-mvebu/armada-370-xp.c to arch/arm/mach-mvebu/armada-mvebu.c. The armada-mvebu.c name was chosen because:

* As we are going to merge the support for Kirkwood and Dove into mach-mvebu, there will be other files with DT_MACHINE_START structures, so a generic name such as board-dt.c or mvebu.c does not work.

* A simple armada.c does not work, because there are Marvell Armada SOCs that are not part of the MVEBU family. For example, the Marvell Armada 1500 are part of the mach-berlin family, which is a completely separate line of SOCs.

In relation to this file rename, this commit also:

* Renames the hidden Kconfig symbol MACH_ARMADA_370_XP to MACH_ARMADA_MVEBU. This hidden symbol is selected by the various per-SoC visible Kconfig options to trigger the build of armada-mvebu.c.

* Renames a certain number of functions in armada-mvebu.c so that their armada_370_xp prefix is replaced by a armada_mvebu prefix. The .dt_compat array keeps its armada_370_xp prefix because the new SOCs will be introduced with separate .dt_compat arrays, due to the need for different SMP operations.

---
Jason, this commit will create a trivial conflict with the patch that removed armada_370_xp_map_io(), which I submitted a few days. The conflict should be easy to resolve (simply remove the ->map_io function).

---
 arch/arm/mach-mvebu/Kconfig                             |  6 +++---
 arch/arm/mach-mvebu/Makefile                            |  2 +-
 arch/arm/mach-mvebu/{armada-370-xp.c => armada-mvebu.c} | 12 ++++++------
 3 files changed, 10 insertions(+), 10 deletions(-)
 rename arch/arm/mach-mvebu/{armada-370-xp.c => armada-mvebu.c} (89%)
arch/arm/mach-mvebu/Kconfig +3 -3
index 5e269d7..35ef594 100644
@@ -21,7 +21,7 @@ if ARCH_MVEBU
 
 menu "Marvell SOC with device tree"
 
-config MACH_ARMADA_370_XP
+config MACH_ARMADA_MVEBU
 	bool
 	select ARMADA_370_XP_TIMER
 	select HAVE_SMP
@@ -31,7 +31,7 @@ config MACH_ARMADA_370_XP
 config MACH_ARMADA_370
 	bool "Marvell Armada 370 boards"
 	select ARMADA_370_CLK
-	select MACH_ARMADA_370_XP
+	select MACH_ARMADA_MVEBU
 	select PINCTRL_ARMADA_370
 	help
 	  Say 'Y' here if you want your kernel to support boards based
@@ -40,7 +40,7 @@ config MACH_ARMADA_370
 config MACH_ARMADA_XP
 	bool "Marvell Armada XP boards"
 	select ARMADA_XP_CLK
-	select MACH_ARMADA_370_XP
+	select MACH_ARMADA_MVEBU
 	select PINCTRL_ARMADA_XP
 	help
 	  Say 'Y' here if you want your kernel to support boards based
arch/arm/mach-mvebu/Makefile +1 -1
index 878aebe..4386094 100644
@@ -4,7 +4,7 @@ ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \
 AFLAGS_coherency_ll.o		:= -Wa,-march=armv7-a
 
 obj-y				 += system-controller.o mvebu-soc-id.o
-obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o
+obj-$(CONFIG_MACH_ARMADA_MVEBU)  += armada-mvebu.o
 obj-$(CONFIG_ARCH_MVEBU)	 += coherency.o coherency_ll.o pmsu.o
 obj-$(CONFIG_SMP)                += platsmp.o headsmp.o
 obj-$(CONFIG_HOTPLUG_CPU)        += hotplug.o
arch/arm/mach-mvebu/armada-mvebu.c renamed from arch/arm/mach-mvebu/armada-370-xp.c +6 -6
similarity index 89%
rename from arch/arm/mach-mvebu/armada-370-xp.c
rename to arch/arm/mach-mvebu/armada-mvebu.c
index f6c9d1d..40e3a4d 100644
@@ -31,12 +31,12 @@
 #include "coherency.h"
 #include "mvebu-soc-id.h"
 
-static void __init armada_370_xp_map_io(void)
+static void __init armada_mvebu_map_io(void)
 {
 	debug_ll_io_init();
 }
 
-static void __init armada_370_xp_timer_and_clk_init(void)
+static void __init armada_mvebu_timer_and_clk_init(void)
 {
 	of_clk_init(NULL);
 	clocksource_of_init();
@@ -75,7 +75,7 @@ static void __init i2c_quirk(void)
 	return;
 }
 
-static void __init armada_370_xp_dt_init(void)
+static void __init armada_mvebu_dt_init(void)
 {
 	if (of_machine_is_compatible("plathome,openblocks-ax3-4"))
 		i2c_quirk();
@@ -89,9 +89,9 @@ static const char * const armada_370_xp_dt_compat[] = {
 
 DT_MACHINE_START(ARMADA_XP_DT, "Marvell Armada 370/XP (Device Tree)")
 	.smp		= smp_ops(armada_xp_smp_ops),
-	.init_machine	= armada_370_xp_dt_init,
-	.map_io		= armada_370_xp_map_io,
-	.init_time	= armada_370_xp_timer_and_clk_init,
+	.init_machine	= armada_mvebu_dt_init,
+	.map_io		= armada_mvebu_map_io,
+	.init_time	= armada_mvebu_timer_and_clk_init,
 	.restart	= mvebu_restart,
 	.dt_compat	= armada_370_xp_dt_compat,
 MACHINE_END
Signature · 1 line
1.8.3.2
maintainer
#2 lore raw

PATCH v3 1/13 ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c

Quoted 10 lines · On Thursday 13 February 2014 12:04:23 Thomas Petazzoni wrote:

In preparation to the introduction of the support of Armada 375 and Armada 38x, this commit renames arch/arm/mach-mvebu/armada-370-xp.c to arch/arm/mach-mvebu/armada-mvebu.c. The armada-mvebu.c name was chosen because:

* As we are going to merge the support for Kirkwood and Dove into mach-mvebu, there will be other files with DT_MACHINE_START structures, so a generic name such as board-dt.c or mvebu.c does not work.

Quoted 4 lines

* A simple armada.c does not work, because there are Marvell Armada SOCs that are not part of the MVEBU family. For example, the Marvell Armada 1500 are part of the mach-berlin family, which is a completely separate line of SOCs.

Your reasoning for the new name makes a lot of sense, but my personal opinion is that I'd rather leave the name as it is and deal with the fact that it's not the best name. Renaming files often causes unexpected problems, in particular if someone else wants to modify the same file.

Arnd

#3 lore raw

PATCH v3 1/13 ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c

Dear Arnd Bergmann,

Quoted 16 lines · Arnd Bergmann
Quoted 10 lines · On Thursday 13 February 2014 12:04:23 Thomas Petazzoni wrote:

In preparation to the introduction of the support of Armada 375 and Armada 38x, this commit renames arch/arm/mach-mvebu/armada-370-xp.c to arch/arm/mach-mvebu/armada-mvebu.c. The armada-mvebu.c name was chosen because:

* As we are going to merge the support for Kirkwood and Dove into mach-mvebu, there will be other files with DT_MACHINE_START structures, so a generic name such as board-dt.c or mvebu.c does not work.

Quoted 4 lines

* A simple armada.c does not work, because there are Marvell Armada SOCs that are not part of the MVEBU family. For example, the Marvell Armada 1500 are part of the mach-berlin family, which is a completely separate line of SOCs.

Quoted 4 lines

Your reasoning for the new name makes a lot of sense, but my personal opinion is that I'd rather leave the name as it is and deal with the fact that it's not the best name. Renaming files often causes unexpected problems, in particular if someone else wants to modify the same file.

I believe it's a matter of taste here. Having a file named armada-370-xp.c that handles Armada 375 and Armada 38x looks highly confusing to me, and I believe both Gr?gory and Ezequiel were of the same opinion.

The number of changes to this file is very limited, so the probability of having a large number of complicated patches touching the same file being in flight is fairly low.

Maybe we can leave this taste decision to the mach-mvebu maintainers?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
maintainer
#4 lore raw

PATCH v3 1/13 ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c

Quoted 4 lines · Thomas Petazzoni

I believe it's a matter of taste here. Having a file named armada-370-xp.c that handles Armada 375 and Armada 38x looks highly confusing to me, and I believe both Gr?gory and Ezequiel were of the same opinion.

I certainly agree that it's confusing, but we also do this all the time in the kernel.

Quoted 5 lines

The number of changes to this file is very limited, so the probability of having a large number of complicated patches touching the same file being in flight is fairly low.

Maybe we can leave this taste decision to the mach-mvebu maintainers?

Definitely, sorry for being unclear here. I wasn't saying you need to change it, just trying to state my personal preference.

Arnd

#5 lore raw

PATCH v3 1/13 ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c

In reply to Thomas Petazzoni
Quoted 29 lines · Thomas Petazzoni

Dear Arnd Bergmann,

Quoted 16 lines · Arnd Bergmann
Quoted 10 lines · On Thursday 13 February 2014 12:04:23 Thomas Petazzoni wrote:

In preparation to the introduction of the support of Armada 375 and Armada 38x, this commit renames arch/arm/mach-mvebu/armada-370-xp.c to arch/arm/mach-mvebu/armada-mvebu.c. The armada-mvebu.c name was chosen because:

* As we are going to merge the support for Kirkwood and Dove into mach-mvebu, there will be other files with DT_MACHINE_START structures, so a generic name such as board-dt.c or mvebu.c does not work.

Quoted 4 lines

* A simple armada.c does not work, because there are Marvell Armada SOCs that are not part of the MVEBU family. For example, the Marvell Armada 1500 are part of the mach-berlin family, which is a completely separate line of SOCs.

Quoted 4 lines

Your reasoning for the new name makes a lot of sense, but my personal opinion is that I'd rather leave the name as it is and deal with the fact that it's not the best name. Renaming files often causes unexpected problems, in particular if someone else wants to modify the same file.

I believe it's a matter of taste here. Having a file named armada-370-xp.c that handles Armada 375 and Armada 38x looks highly confusing to me, and I believe both Gr?gory and Ezequiel were of the same opinion.

Quoted 5 lines

The number of changes to this file is very limited, so the probability of having a large number of complicated patches touching the same file being in flight is fairly low.

Maybe we can leave this taste decision to the mach-mvebu maintainers?

board-v7.c and then board-v5.c ?

thx,

Jason.

#6 lore raw

PATCH v3 1/13 ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c

Dear Jason Cooper,

Quoted 10 lines · Jason Cooper
Quoted 10 lines
Quoted 4 lines

Your reasoning for the new name makes a lot of sense, but my personal opinion is that I'd rather leave the name as it is and deal with the fact that it's not the best name. Renaming files often causes unexpected problems, in particular if someone else wants to modify the same file.

I believe it's a matter of taste here. Having a file named armada-370-xp.c that handles Armada 375 and Armada 38x looks highly confusing to me, and I believe both Gr?gory and Ezequiel were of the same opinion.

Quoted 7 lines
Quoted 5 lines

The number of changes to this file is very limited, so the probability of having a large number of complicated patches touching the same file being in flight is fairly low.

Maybe we can leave this taste decision to the mach-mvebu maintainers?

board-v7.c and then board-v5.c ?

Why not. But since this kind of change can be done without breaking the DT compatibility, I'd first prefer to see Dove support merged into mach-mvebu/ with its board file named mach-mvebu/dove.c. Then progressively see what can be combined with armada-mvebu.c so that we can merge both of them into board-v7.c.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#7 lore raw

PATCH v3 1/13 ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c

Quoted 17 lines · Thomas Petazzoni
Quoted 16 lines · Jason Cooper
Quoted 15 lines
Quoted 4 lines

Your reasoning for the new name makes a lot of sense, but my personal opinion is that I'd rather leave the name as it is and deal with the fact that it's not the best name. Renaming files often causes unexpected problems, in particular if someone else wants to modify the same file.

I believe it's a matter of taste here. Having a file named armada-370-xp.c that handles Armada 375 and Armada 38x looks highly confusing to me, and I believe both Gr?gory and Ezequiel were of the same opinion.

The number of changes to this file is very limited, so the probability of having a large number of complicated patches touching the same file being in flight is fairly low.

Maybe we can leave this taste decision to the mach-mvebu maintainers?

Quoted 7 lines
Quoted 1 line

board-v7.c and then board-v5.c ?

Why not. But since this kind of change can be done without breaking the DT compatibility, I'd first prefer to see Dove support merged into mach-mvebu/ with its board file named mach-mvebu/dove.c. Then progressively see what can be combined with armada-mvebu.c so that we can merge both of them into board-v7.c.

Actually, just prepared those patches today. Haven't boot tested but compiles cleanly. The patch set will be really small compared to KW patch set (but de-hardcoded pinctrl-dove will be a prerequisite).

I also prefer to move to mach-mvebu/dove.c and then merge with armada-3{78}{05x} a cycle later.

Sebastian

#8 lore raw

PATCH v3 1/13 ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c

Dear Sebastian Hesselbarth,

Quoted 9 lines · Sebastian Hesselbarth
Quoted 5 lines

Why not. But since this kind of change can be done without breaking the DT compatibility, I'd first prefer to see Dove support merged into mach-mvebu/ with its board file named mach-mvebu/dove.c. Then progressively see what can be combined with armada-mvebu.c so that we can merge both of them into board-v7.c.

Actually, just prepared those patches today. Haven't boot tested but compiles cleanly. The patch set will be really small compared to KW patch set (but de-hardcoded pinctrl-dove will be a prerequisite).

Cool! I'm planning on giving a test to your pinctrl patches this afternoon, if all goes well.

Quoted 2 lines

I also prefer to move to mach-mvebu/dove.c and then merge with armada-3{78}{05x} a cycle later.

Yes, I agree. I'm fully convinced by the idea of merging the v7 support together, but we need to proceed step by step to avoid having horrible merge issues during the 3.15 cycle.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#9 lore raw

PATCH v3 1/13 ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c

Quoted 17 lines · Thomas Petazzoni

Dear Sebastian Hesselbarth,

Quoted 9 lines · Sebastian Hesselbarth
Quoted 5 lines

Why not. But since this kind of change can be done without breaking the DT compatibility, I'd first prefer to see Dove support merged into mach-mvebu/ with its board file named mach-mvebu/dove.c. Then progressively see what can be combined with armada-mvebu.c so that we can merge both of them into board-v7.c.

Actually, just prepared those patches today. Haven't boot tested but compiles cleanly. The patch set will be really small compared to KW patch set (but de-hardcoded pinctrl-dove will be a prerequisite).

Cool! I'm planning on giving a test to your pinctrl patches this afternoon, if all goes well.

Quoted 6 lines
Quoted 2 lines

I also prefer to move to mach-mvebu/dove.c and then merge with armada-3{78}{05x} a cycle later.

Yes, I agree. I'm fully convinced by the idea of merging the v7 support together, but we need to proceed step by step to avoid having horrible merge issues during the 3.15 cycle.

Yeah, I don't see how anything can go wrong at all. :)

btw - I'll hold off on pulling this for a new revision. Looks like the only change left in the file name.

thx,

Jason.

#10 lore raw

PATCH v3 1/13 ARM: mvebu: rename armada-370-xp.c to armada-mvebu.c

Dear Jason Cooper,

Quoted 8 lines · Jason Cooper
Quoted 3 lines

Yes, I agree. I'm fully convinced by the idea of merging the v7 support together, but we need to proceed step by step to avoid having horrible merge issues during the 3.15 cycle.

Yeah, I don't see how anything can go wrong at all. :)

btw - I'll hold off on pulling this for a new revision. Looks like the only change left in the file name.

I'll be posting a v4 today. It will contain this rename, and also a few more DT nodes for Armada 375 that enable NAND support, since we have sent the corediv clock patches, which were necessary for NAND support to work.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#11 lore raw

PATCH v3 2/13 ARM: mvebu: rename DT machine structure for Armada 370/XP

In reply to Thomas Petazzoni

Due to a mistake made when merging Armada 370 and Armada XP DT machine structures, the name of the structure was incorrectly chosen as being ARMADA_XP_DT, while the structure also covers Armada 370. Therefore, we rename the structure to ARMADA_370_XP_DT.

---
 arch/arm/mach-mvebu/armada-mvebu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-mvebu/armada-mvebu.c +1 -1
index 40e3a4d..18fbb32 100644
@@ -87,7 +87,7 @@ static const char * const armada_370_xp_dt_compat[] = {
 	NULL,
 };
 
-DT_MACHINE_START(ARMADA_XP_DT, "Marvell Armada 370/XP (Device Tree)")
+DT_MACHINE_START(ARMADA_370_XP_DT, "Marvell Armada 370/XP (Device Tree)")
 	.smp		= smp_ops(armada_xp_smp_ops),
 	.init_machine	= armada_mvebu_dt_init,
 	.map_io		= armada_mvebu_map_io,
Signature · 1 line
1.8.3.2
#12 lore raw

PATCH v3 3/13 ARM: mvebu: make CPU_PJ4B selection a per-SoC choice

In reply to Thomas Petazzoni

Until now, the CPU_PJ4B Kconfig option was selected by MACH_ARMADA_MVEBU, i.e for all Armada MVEBU SOCs. In preparation to the introduction of Cortex-A9 based Armada MVEBU SOCs, this selection is moved down to the Armada 370 and Armada XP specific options.

---
 arch/arm/mach-mvebu/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-mvebu/Kconfig +2 -1
index 35ef594..c934f92 100644
@@ -26,11 +26,11 @@ config MACH_ARMADA_MVEBU
 	select ARMADA_370_XP_TIMER
 	select HAVE_SMP
 	select CACHE_L2X0
-	select CPU_PJ4B
 
 config MACH_ARMADA_370
 	bool "Marvell Armada 370 boards"
 	select ARMADA_370_CLK
+	select CPU_PJ4B
 	select MACH_ARMADA_MVEBU
 	select PINCTRL_ARMADA_370
 	help
@@ -40,6 +40,7 @@ config MACH_ARMADA_370
 config MACH_ARMADA_XP
 	bool "Marvell Armada XP boards"
 	select ARMADA_XP_CLK
+	select CPU_PJ4B
 	select MACH_ARMADA_MVEBU
 	select PINCTRL_ARMADA_XP
 	help
Signature · 1 line
1.8.3.2
#13 lore raw

PATCH v3 4/13 ARM: mvebu: add Armada 375 support to the system-controller driver

In reply to Thomas Petazzoni

The system controller block in the Armada 375 has different register offsets for the system reset and other related functions. Therefore, this commit introduces the new "armada-375-system-controller" compatible string to identify the Armada 375 variant of the system controller.

---
 .../devicetree/bindings/arm/mvebu-system-controller.txt    |  3 ++-
 arch/arm/mach-mvebu/system-controller.c                    | 14 ++++++++++++--
 2 files changed, 14 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/arm/mvebu-system-controller.txt +2 -1
index 081c6a7..d24ab2e 100644
@@ -1,12 +1,13 @@
 MVEBU System Controller
 -----------------------
-MVEBU (Marvell SOCs: Armada 370/XP, Dove, mv78xx0, Kirkwood, Orion5x)
+MVEBU (Marvell SOCs: Armada 370/375/XP, Dove, mv78xx0, Kirkwood, Orion5x)
 
 Required properties:
 
 - compatible: one of:
 	- "marvell,orion-system-controller"
 	- "marvell,armada-370-xp-system-controller"
+	- "marvell,armada-375-system-controller"
 - reg: Should contain system controller registers location and length.
 
 Example:
arch/arm/mach-mvebu/system-controller.c +12 -2
index a7fb89a..1806187 100644
@@ -1,5 +1,5 @@
 /*
- * System controller support for Armada 370 and XP platforms.
+ * System controller support for Armada 370, 375 and XP platforms.
  *
  * Copyright (C) 2012 Marvell
  *
@@ -11,7 +11,7 @@
  * License version 2.  This program is licensed "as is" without any
  * warranty of any kind, whether express or implied.
  *
- * The Armada 370 and Armada XP SoCs both have a range of
+ * The Armada 370, 375 and Armada XP SoCs have a range of
  * miscellaneous registers, that do not belong to a particular device,
  * but rather provide system-level features. This basic
  * system-controller driver provides a device tree binding for those
@@ -47,6 +47,13 @@ static const struct mvebu_system_controller armada_370_xp_system_controller = {
 	.system_soft_reset = 0x1,
 };
 
+static const struct mvebu_system_controller armada_375_system_controller = {
+	.rstoutn_mask_offset = 0x54,
+	.system_soft_reset_offset = 0x58,
+	.rstoutn_mask_reset_out_en = 0x1,
+	.system_soft_reset = 0x1,
+};
+
 static const struct mvebu_system_controller orion_system_controller = {
 	.rstoutn_mask_offset = 0x108,
 	.system_soft_reset_offset = 0x10c,
@@ -61,6 +68,9 @@ static struct of_device_id of_system_controller_table[] = {
 	}, {
 		.compatible = "marvell,armada-370-xp-system-controller",
 		.data = (void *) &armada_370_xp_system_controller,
+	}, {
+		.compatible = "marvell,armada-375-system-controller",
+		.data = (void *) &armada_375_system_controller,
 	},
 	{ /* end of list */ },
 };
Signature · 1 line
1.8.3.2
#14 lore raw

PATCH v3 5/13 ARM: mvebu: add initial support for the Armada 375 SOCs

In reply to Thomas Petazzoni

From: Gregory CLEMENT <[email protected]>

This commit adds the basic support for the Armada 375 SOCs. These SoCs share most of their IP with the Armada 370/XP SoCs. The main difference is the use of a Cortex A9 CPU instead of the PJ4B CPU. The interrupt controller and the L2 cache controller are also different they are respectively the GIC and the PL310.

The support is introduced in armada-mvebu.c, together with Armada 370/XP, but a separate DT structure is added, because Armada 375 will need a different set of SMP operations when the SMP support is introduced.

---
 Documentation/devicetree/bindings/arm/armada-375.txt |  9 +++++++++
 arch/arm/mach-mvebu/Kconfig                          | 14 ++++++++++++++
 arch/arm/mach-mvebu/armada-mvebu.c                   | 11 +++++++++++
 3 files changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/armada-375.txt
Documentation/devicetree/bindings/arm/armada-375.txt new file +9 -0
new file mode 100644
index 0000000..867d0b8
@@ -0,0 +1,9 @@
+Marvell Armada 375 Platforms Device Tree Bindings
+-------------------------------------------------
+
+Boards with a SoC of the Marvell Armada 375 family shall have the
+following property:
+
+Required root node property:
+
+compatible: must contain "marvell,armada375"
arch/arm/mach-mvebu/Kconfig +14 -0
index c934f92..3e228af 100644
@@ -37,6 +37,20 @@ config MACH_ARMADA_370
 	  Say 'Y' here if you want your kernel to support boards based
 	  on the Marvell Armada 370 SoC with device tree.
 
+config MACH_ARMADA_375
+	bool "Marvell Armada 375 boards"
+	select ARM_ERRATA_720789
+	select ARM_ERRATA_753970
+	select ARM_GIC
+	select ARMADA_375_CLK
+	select CPU_V7
+	select MACH_ARMADA_MVEBU
+	select NEON
+	select PINCTRL_ARMADA_375
+	help
+	  Say 'Y' here if you want your kernel to support boards based
+	  on the Marvell Armada 375 SoC with device tree.
+
 config MACH_ARMADA_XP
 	bool "Marvell Armada XP boards"
 	select ARMADA_XP_CLK
arch/arm/mach-mvebu/armada-mvebu.c +11 -0
index 18fbb32..7d1687a 100644
@@ -95,3 +95,14 @@ DT_MACHINE_START(ARMADA_370_XP_DT, "Marvell Armada 370/XP (Device Tree)")
 	.restart	= mvebu_restart,
 	.dt_compat	= armada_370_xp_dt_compat,
 MACHINE_END
+
+static const char * const armada_375_dt_compat[] = {
+	"marvell,armada375",
+	NULL,
+};
+
+DT_MACHINE_START(ARMADA_375_DT, "Marvell Armada 375 (Device Tree)")
+	.init_time	= armada_mvebu_timer_and_clk_init,
+	.restart	= mvebu_restart,
+	.dt_compat	= armada_375_dt_compat,
+MACHINE_END
Signature · 1 line
1.8.3.2
#15 lore raw

PATCH v3 6/13 ARM: mvebu: add workaround for data abort issue on Armada 375

In reply to Thomas Petazzoni

Early versions of Armada 375 SoC have a bug where the BootROM leaves an external data abort pending. The kernel is hit by this data abort as soon as it enters userspace, because it unmasks the data aborts at this moment. We register a custom abort handler below to ignore the first data abort to work around this problem.

---
 arch/arm/mach-mvebu/armada-mvebu.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
arch/arm/mach-mvebu/armada-mvebu.c +25 -0
index 7d1687a..7e50464 100644
@@ -36,6 +36,27 @@ static void __init armada_mvebu_map_io(void)
 	debug_ll_io_init();
 }
 
+/*
+ * Early versions of Armada 375 SoC have a bug where the BootROM
+ * leaves an external data abort pending. The kernel is hit by this
+ * data abort as soon as it enters userspace, because it unmasks the
+ * data aborts at this moment. We register a custom abort handler
+ * below to ignore the first data abort to work around this
+ * problem.
+ */
+static int armada_375_external_abort_wa(unsigned long addr, unsigned int fsr,
+					struct pt_regs *regs)
+{
+	static int ignore_first;
+
+	if (!ignore_first && fsr == 0x1406) {
+		ignore_first = 1;
+		return 0;
+	}
+
+	return 1;
+}
+
 static void __init armada_mvebu_timer_and_clk_init(void)
 {
 	of_clk_init(NULL);
@@ -45,6 +66,10 @@ static void __init armada_mvebu_timer_and_clk_init(void)
 #ifdef CONFIG_CACHE_L2X0
 	l2x0_of_init(0, ~0UL);
 #endif
+
+	if (of_machine_is_compatible("marvell,armada375"))
+		hook_fault_code(16 + 6, armada_375_external_abort_wa, SIGBUS, 0,
+				"imprecise external abort");
 }
 
 static void __init i2c_quirk(void)
Signature · 1 line
1.8.3.2
#16 lore raw

PATCH v3 7/13 ARM: mvebu: add Device Tree description of the Armada 375 SoC

In reply to Thomas Petazzoni

From: Gregory CLEMENT <[email protected]>

The Armada 375 SoC is a new SoC from Marvell, based on a dual core Cortex-A9 and a number of hardware blocks that are common with earlier SoCs from the mvebu family.

The provided Device Tree describes the following parts of the SoC:

* CPUs
* Device Bus
* Clocks
* Interrupt controllers: GIC and MPIC
* GPIO controllers
* I2C buses
* L2 cache
* MBus controller
* SDIO
* Pinctrl
* SATA
* Serial
* SPI buses
* System controller (for reboot)
* Timer
* XOR engines
* PCIe controllers

---
 arch/arm/boot/dts/armada-375.dtsi | 439 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 439 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-375.dtsi
arch/arm/boot/dts/armada-375.dtsi new file +439 -0
new file mode 100644
index 0000000..31de4bf
@@ -0,0 +1,439 @@
+/*
+ * Device Tree Include file for Marvell Armada 375 family SoC
+ *
+ * Copyright (C) 2014 Marvell
+ *
+ * Gregory CLEMENT <[email protected]>
+ * Thomas Petazzoni <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/include/ "skeleton.dtsi"
+
+#define MBUS_ID(target,attributes) (((target) << 24) | ((attributes) << 16))
+
+/ {
+	model = "Marvell Armada 375 family SoC";
+	compatible = "marvell,armada375";
+
+	aliases {
+		gpio0 = &gpio0;
+		gpio1 = &gpio1;
+		gpio2 = &gpio2;
+	};
+
+	clocks {
+		/* 2 GHz fixed main PLL */
+		mainpll: mainpll {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <2000000000>;
+		};
+	};
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <0>;
+		};
+		cpu at 1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <1>;
+		};
+	};
+
+	soc {
+		compatible = "marvell,armada375-mbus", "marvell,armada370-mbus", "simple-bus";
+		#address-cells = <2>;
+		#size-cells = <1>;
+		controller = <&mbusc>;
+		interrupt-parent = <&gic>;
+		pcie-mem-aperture = <0xe0000000 0x8000000>;
+		pcie-io-aperture  = <0xe8000000 0x100000>;
+
+		bootrom {
+			compatible = "marvell,bootrom";
+			reg = <MBUS_ID(0x01, 0x1d) 0 0x100000>;
+		};
+
+		devbus-bootcs {
+			compatible = "marvell,mvebu-devbus";
+			reg = <MBUS_ID(0xf0, 0x01) 0x10400 0x8>;
+			ranges = <0 MBUS_ID(0x01, 0x2f) 0 0xffffffff>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			clocks = <&coreclk 0>;
+			status = "disabled";
+		};
+
+		devbus-cs0 {
+			compatible = "marvell,mvebu-devbus";
+			reg = <MBUS_ID(0xf0, 0x01) 0x10408 0x8>;
+			ranges = <0 MBUS_ID(0x01, 0x3e) 0 0xffffffff>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			clocks = <&coreclk 0>;
+			status = "disabled";
+		};
+
+		devbus-cs1 {
+			compatible = "marvell,mvebu-devbus";
+			reg = <MBUS_ID(0xf0, 0x01) 0x10410 0x8>;
+			ranges = <0 MBUS_ID(0x01, 0x3d) 0 0xffffffff>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			clocks = <&coreclk 0>;
+			status = "disabled";
+		};
+
+		devbus-cs2 {
+			compatible = "marvell,mvebu-devbus";
+			reg = <MBUS_ID(0xf0, 0x01) 0x10418 0x8>;
+			ranges = <0 MBUS_ID(0x01, 0x3b) 0 0xffffffff>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			clocks = <&coreclk 0>;
+			status = "disabled";
+		};
+
+		devbus-cs3 {
+			compatible = "marvell,mvebu-devbus";
+			reg = <MBUS_ID(0xf0, 0x01) 0x10420 0x8>;
+			ranges = <0 MBUS_ID(0x01, 0x37) 0 0xffffffff>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			clocks = <&coreclk 0>;
+			status = "disabled";
+		};
+
+		internal-regs {
+			compatible = "simple-bus";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>;
+
+			L2: cache-controller at 8000 {
+				compatible = "arm,pl310-cache";
+				reg = <0x8000 0x1000>;
+				cache-unified;
+				cache-level = <2>;
+			};
+
+			timer at c600 {
+				compatible = "arm,cortex-a9-twd-timer";
+				reg = <0xc600 0x20>;
+				interrupts = <1 13 0x301>;
+				clocks = <&coreclk 2>;
+			};
+
+			gic: interrupt-controller at d000 {
+				compatible = "arm,cortex-a9-gic";
+				#interrupt-cells = <3>;
+				#size-cells = <0>;
+				interrupt-controller;
+				reg = <0xd000 0x1000>,
+				      <0xc100 0x100>;
+			};
+
+			spi0: spi at 10600 {
+				compatible = "marvell,orion-spi";
+				reg = <0x10600 0x50>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				cell-index = <0>;
+				interrupts = <0 1 0x4>;
+				clocks = <&coreclk 0>;
+				status = "disabled";
+			};
+
+			spi1: spi at 10680 {
+				compatible = "marvell,orion-spi";
+				reg = <0x10680 0x50>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				cell-index = <1>;
+				interrupts = <0 63 0x4>;
+				clocks = <&coreclk 0>;
+				status = "disabled";
+			};
+
+			i2c0: i2c at 11000 {
+				compatible = "marvell,mv64xxx-i2c";
+				reg = <0x11000 0x20>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				interrupts = <0 2 0x4>;
+				timeout-ms = <1000>;
+				clocks = <&coreclk 0>;
+				status = "disabled";
+			};
+
+			i2c1: i2c at 11100 {
+				compatible = "marvell,mv64xxx-i2c";
+				reg = <0x11100 0x20>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				interrupts = <0 3 0x4>;
+				timeout-ms = <1000>;
+				clocks = <&coreclk 0>;
+				status = "disabled";
+			};
+
+			serial at 12000 {
+				compatible = "snps,dw-apb-uart";
+				reg = <0x12000 0x100>;
+				reg-shift = <2>;
+				interrupts = <0 12 4>;
+				reg-io-width = <1>;
+				status = "disabled";
+			};
+
+			serial at 12100 {
+				compatible = "snps,dw-apb-uart";
+				reg = <0x12100 0x100>;
+				reg-shift = <2>;
+				interrupts = <0 13 4>;
+				reg-io-width = <1>;
+				status = "disabled";
+			};
+
+			pinctrl {
+				compatible = "marvell,mv88f6720-pinctrl";
+				reg = <0x18000 0x24>;
+
+				i2c0_pins: i2c0-pins {
+					marvell,pins = "mpp14",  "mpp15";
+					marvell,function = "i2c0";
+				};
+
+				i2c1_pins: i2c1-pins {
+					marvell,pins = "mpp61",  "mpp62";
+					marvell,function = "i2c1";
+				};
+
+				sdio_pins: sdio-pins {
+					marvell,pins = "mpp24",  "mpp25", "mpp26",
+						     "mpp27", "mpp28", "mpp29";
+					marvell,function = "sd";
+				};
+
+				spi0_pins: spi0-pins {
+					marvell,pins = "mpp0",  "mpp1", "mpp4",
+						     "mpp5", "mpp8", "mpp9";
+					marvell,function = "spi0";
+				};
+			};
+
+			gpio0: gpio at 18100 {
+				compatible = "marvell,orion-gpio";
+				reg = <0x18100 0x40>;
+				ngpios = <32>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <0 53 0x4>, <0 54 0x4>,
+					     <0 55 0x4>, <0 56 0x4>;
+			};
+
+			gpio1: gpio at 18140 {
+				compatible = "marvell,orion-gpio";
+				reg = <0x18140 0x40>;
+				ngpios = <32>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <0 58 0x4>, <0 59 0x4>,
+					     <0 60 0x4>, <0 61 0x4>;
+			};
+
+			gpio2: gpio at 18180 {
+				compatible = "marvell,orion-gpio";
+				reg = <0x18180 0x40>;
+				ngpios = <3>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <0 62 0x4>;
+			};
+
+			system-controller at 18200 {
+				compatible = "marvell,armada-375-system-controller";
+				reg = <0x18200 0x100>;
+			};
+
+			gateclk: clock-gating-control at 18220 {
+				compatible = "marvell,armada-375-gating-clock";
+				reg = <0x18220 0x4>;
+				clocks = <&coreclk 0>;
+				#clock-cells = <1>;
+			};
+
+			mbusc: mbus-controller at 20000 {
+				compatible = "marvell,mbus-controller";
+				reg = <0x20000 0x100>, <0x20180 0x20>;
+			};
+
+			mpic: interrupt-controller at 20000 {
+				compatible = "marvell,mpic";
+				reg = <0x20a00 0x2d0>, <0x21070 0x58>;
+				#interrupt-cells = <1>;
+				#size-cells = <1>;
+				interrupt-controller;
+				msi-controller;
+				interrupts = <1 15 0x4>;
+			};
+
+			timer at 20300 {
+				compatible = "marvell,armada-375-timer", "marvell,armada-370-timer";
+				reg = <0x20300 0x30>, <0x21040 0x30>;
+				interrupts-extended = <&gic  0  8 4>,
+						      <&gic  0  9 4>,
+						      <&gic  0 10 4>,
+						      <&gic  0 11 4>,
+						      <&mpic 5>,
+						      <&mpic 6>;
+				clocks = <&coreclk 0>;
+			};
+
+			xor at 60800 {
+				compatible = "marvell,orion-xor";
+				reg = <0x60800 0x100
+				       0x60A00 0x100>;
+				clocks = <&gateclk 22>;
+				status = "okay";
+
+				xor00 {
+					interrupts = <0 22 0x4>;
+					dmacap,memcpy;
+					dmacap,xor;
+				};
+				xor01 {
+					interrupts = <0 23 0x4>;
+					dmacap,memcpy;
+					dmacap,xor;
+					dmacap,memset;
+				};
+			};
+
+			xor at 60900 {
+				compatible = "marvell,orion-xor";
+				reg = <0x60900 0x100
+				       0x60b00 0x100>;
+				clocks = <&gateclk 23>;
+				status = "okay";
+
+				xor10 {
+					interrupts = <0 65 0x4>;
+					dmacap,memcpy;
+					dmacap,xor;
+				};
+				xor11 {
+					interrupts = <0 66 0x4>;
+					dmacap,memcpy;
+					dmacap,xor;
+					dmacap,memset;
+				};
+			};
+
+			sata at a0000 {
+				compatible = "marvell,orion-sata";
+				reg = <0xa0000 0x5000>;
+				interrupts = <0 26 0x4>;
+				clocks = <&gateclk 14>, <&gateclk 20>;
+				clock-names = "0", "1";
+				status = "disabled";
+			};
+
+			mvsdio at d4000 {
+				compatible = "marvell,orion-sdio";
+				reg = <0xd4000 0x200>;
+				interrupts = <0 25 0x4>;
+				clocks = <&gateclk 17>;
+				bus-width = <4>;
+				cap-sdio-irq;
+				cap-sd-highspeed;
+				cap-mmc-highspeed;
+				status = "disabled";
+			};
+
+			coreclk: mvebu-sar at e8204 {
+				compatible = "marvell,armada-375-core-clock";
+				reg = <0xe8204 0x04>;
+				#clock-cells = <1>;
+			};
+
+			coredivclk: corediv-clock at e8250 {
+				compatible = "marvell,armada-375-corediv-clock";
+				reg = <0xe8250 0xc>;
+				#clock-cells = <1>;
+				clocks = <&mainpll>;
+				clock-output-names = "nand";
+			};
+		};
+
+		pcie-controller {
+			compatible = "marvell,armada-370-pcie";
+			status = "disabled";
+			device_type = "pci";
+
+			#address-cells = <3>;
+			#size-cells = <2>;
+
+			msi-parent = <&mpic>;
+			bus-range = <0x00 0xff>;
+
+			ranges =
+			       <0x82000000 0 0x40000 MBUS_ID(0xf0, 0x01) 0x40000 0 0x00002000
+				0x82000000 0 0x44000 MBUS_ID(0xf0, 0x01) 0x44000 0 0x00002000
+				0x82000000 0x1 0       MBUS_ID(0x04, 0xe8) 0 1 0 /* Port 0 MEM */
+				0x81000000 0x1 0       MBUS_ID(0x04, 0xe0) 0 1 0 /* Port 0 IO  */
+				0x82000000 0x2 0       MBUS_ID(0x04, 0xd8) 0 1 0 /* Port 1 MEM */
+				0x81000000 0x2 0       MBUS_ID(0x04, 0xd0) 0 1 0 /* Port 1 IO  */>;
+
+			pcie at 1,0 {
+				device_type = "pci";
+				assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
+				reg = <0x0800 0 0 0 0>;
+				#address-cells = <3>;
+				#size-cells = <2>;
+				#interrupt-cells = <1>;
+				ranges = <0x82000000 0 0 0x82000000 0x1 0 1 0
+					  0x81000000 0 0 0x81000000 0x1 0 1 0>;
+				interrupt-map-mask = <0 0 0 0>;
+				interrupt-map = <0 0 0 0 &gic 0 29 0x4>;
+				marvell,pcie-port = <0>;
+				marvell,pcie-lane = <0>;
+				clocks = <&gateclk 5>;
+				status = "disabled";
+			};
+
+			pcie at 2,0 {
+				device_type = "pci";
+				assigned-addresses = <0x82000800 0 0x44000 0 0x2000>;
+				reg = <0x1000 0 0 0 0>;
+				#address-cells = <3>;
+				#size-cells = <2>;
+				#interrupt-cells = <1>;
+				ranges = <0x82000000 0 0 0x82000000 0x2 0 1 0
+					  0x81000000 0 0 0x81000000 0x2 0 1 0>;
+				interrupt-map-mask = <0 0 0 0>;
+				interrupt-map = <0 0 0 0 &gic 0 33 0x4>;
+				marvell,pcie-port = <0>;
+				marvell,pcie-lane = <1>;
+				clocks = <&gateclk 6>;
+				status = "disabled";
+			};
+
+		};
+	};
+};
Signature · 1 line
1.8.3.2
#17 lore raw

PATCH v3 8/13 ARM: mvebu: add Device Tree for the Armada 375 DB board

In reply to Thomas Petazzoni

The Armada 375 DB board is the development board from Marvell for the Armada 375 SoC. This commit adds a Device Tree description for this board, which enables the following features:

* I2C buses
* SDIO
* Serial port
* SPI bus, with a SPI flash. Note that the SPI bus is disabled by default, because it conflicts with the NAND, and can only work if the board boots out of SPI. Since most boards are shipped to boot out of NAND, we're default to having the SPI bus disabled.
* PCIe interfaces

---
 arch/arm/boot/dts/Makefile          |   1 +
 arch/arm/boot/dts/armada-375-db.dts | 107 ++++++++++++++++++++++++++++++++++++
 2 files changed, 108 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-375-db.dts
arch/arm/boot/dts/Makefile +1 -0
index b9d6a8b..f1eafbd 100644
@@ -126,6 +126,7 @@ dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
 	armada-370-netgear-rn102.dtb \
 	armada-370-netgear-rn104.dtb \
 	armada-370-rd.dtb \
+	armada-375-db.dtb \
 	armada-xp-axpwifiap.dtb \
 	armada-xp-db.dtb \
 	armada-xp-gp.dtb \
arch/arm/boot/dts/armada-375-db.dts new file +107 -0

107 lines not on this page · raw message

Signature · 1 line
1.8.3.2
#18 lore raw

PATCH v3 9/13 ARM: mvebu: add initial support for the Armada 380/385 SOCs

In reply to Thomas Petazzoni

This commit adds the basic support for the Armada 380 and Armada 385 SOCs. These SoCs share most of their IP with the Armada 370/XP SoCs. The main difference is the use of a Cortex A9 CPU instead of the PJ4B CPU. The Armada 380 is a single core Cortex-A9, while the Armada 385 is a dual-core Cortex-A9.

The support is introduced in armada-mvebu.c, together with Armada 370/XP, but a separate DT structure is added, because Armada 38x will need a different set of SMP operations when the SMP support is introduced.

---
 Documentation/devicetree/bindings/arm/armada-38x.txt | 10 ++++++++++
 arch/arm/mach-mvebu/Kconfig                          | 14 ++++++++++++++
 arch/arm/mach-mvebu/armada-mvebu.c                   | 12 ++++++++++++
 3 files changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/armada-38x.txt
Documentation/devicetree/bindings/arm/armada-38x.txt new file +10 -0
new file mode 100644
index 0000000..11f2330
@@ -0,0 +1,10 @@
+Marvell Armada 38x Platforms Device Tree Bindings
+-------------------------------------------------
+
+Boards with a SoC of the Marvell Armada 38x family shall have the
+following property:
+
+Required root node property:
+
+ - compatible: must contain either "marvell,armada380" or
+   "marvell,armada385" depending on the variant of the SoC being used.
arch/arm/mach-mvebu/Kconfig +14 -0
index 3e228af..57f4bde 100644
@@ -51,6 +51,20 @@ config MACH_ARMADA_375
 	  Say 'Y' here if you want your kernel to support boards based
 	  on the Marvell Armada 375 SoC with device tree.
 
+config MACH_ARMADA_38X
+	bool "Marvell Armada 380/385 boards"
+	select ARM_ERRATA_720789
+	select ARM_ERRATA_753970
+	select ARM_GIC
+	select ARMADA_38X_CLK
+	select CPU_V7
+	select MACH_ARMADA_MVEBU
+	select NEON
+	select PINCTRL_ARMADA_38X
+	help
+	  Say 'Y' here if you want your kernel to support boards based
+	  on the Marvell Armada 380/385 SoC with device tree.
+
 config MACH_ARMADA_XP
 	bool "Marvell Armada XP boards"
 	select ARMADA_XP_CLK
arch/arm/mach-mvebu/armada-mvebu.c +12 -0
index 7e50464..fcf4091 100644
@@ -131,3 +131,15 @@ DT_MACHINE_START(ARMADA_375_DT, "Marvell Armada 375 (Device Tree)")
 	.restart	= mvebu_restart,
 	.dt_compat	= armada_375_dt_compat,
 MACHINE_END
+
+static const char * const armada_38x_dt_compat[] = {
+	"marvell,armada380",
+	"marvell,armada385",
+	NULL,
+};
+
+DT_MACHINE_START(ARMADA_38X_DT, "Marvell Armada 380/385 (Device Tree)")
+	.init_time	= armada_mvebu_timer_and_clk_init,
+	.restart	= mvebu_restart,
+	.dt_compat	= armada_38x_dt_compat,
+MACHINE_END
Signature · 1 line
1.8.3.2
#19 lore raw

PATCH v3 10/13 ARM: mvebu: add Device Tree description of the Armada 380/385 SoCs

In reply to Thomas Petazzoni

The Armada 380 and 385 SoCs are new SoCs from Marvell, based on a Cortex-A9 cores (single core for 380, dual core for 385) and a number of hardware blocks that are common with earlier SoCs from the mvebu family.

The provided Device Tree describes the following parts of the SoC:

* CPU
* Device Bus
* Clocks
* Interrupt controllers: GIC and MPIC
* GPIO controllers
* I2C buses
* L2 cache
* MBus controller
* Pinctrl
* Serial
* SPI buses
* System controller (for reboot)
* Timer
* XOR engines
* PCIe controllers
* Network interfaces

---
 arch/arm/boot/dts/armada-380.dtsi | 117 +++++++++++++
 arch/arm/boot/dts/armada-385.dtsi | 149 ++++++++++++++++
 arch/arm/boot/dts/armada-38x.dtsi | 345 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 611 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-380.dtsi
 create mode 100644 arch/arm/boot/dts/armada-385.dtsi
 create mode 100644 arch/arm/boot/dts/armada-38x.dtsi
arch/arm/boot/dts/armada-380.dtsi new file +117 -0
new file mode 100644
index 0000000..5a46ec7
@@ -0,0 +1,117 @@
+/*
+ * Device Tree Include file for Marvell Armada 380 SoC.
+ *
+ * Copyright (C) 2014 Marvell
+ *
+ * Lior Amsalem <[email protected]>
+ * Gregory CLEMENT <[email protected]>
+ * Thomas Petazzoni <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/include/ "armada-38x.dtsi"
+
+/ {
+	model = "Marvell Armada 380 family SoC";
+	compatible = "marvell,armada380", "marvell,armada38x";
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <0>;
+		};
+	};
+
+	soc {
+		internal-regs {
+			pinctrl {
+				compatible = "marvell,mv88f6810-pinctrl";
+				reg = <0x18000 0x20>;
+			};
+		};
+
+		pcie-controller {
+			compatible = "marvell,armada-370-pcie";
+			status = "disabled";
+			device_type = "pci";
+
+			#address-cells = <3>;
+			#size-cells = <2>;
+
+			msi-parent = <&mpic>;
+			bus-range = <0x00 0xff>;
+
+			ranges =
+			       <0x82000000 0 0x80000 MBUS_ID(0xf0, 0x01) 0x80000 0 0x00002000
+				0x82000000 0 0x40000 MBUS_ID(0xf0, 0x01) 0x40000 0 0x00002000
+				0x82000000 0 0x44000 MBUS_ID(0xf0, 0x01) 0x44000 0 0x00002000
+				0x82000000 0 0x48000 MBUS_ID(0xf0, 0x01) 0x48000 0 0x00002000
+				0x82000000 0x1 0     MBUS_ID(0x08, 0xe8) 0 1 0 /* Port 0 MEM */
+				0x81000000 0x1 0     MBUS_ID(0x08, 0xe0) 0 1 0 /* Port 0 IO  */
+				0x82000000 0x2 0     MBUS_ID(0x04, 0xe8) 0 1 0 /* Port 1 MEM */
+				0x81000000 0x2 0     MBUS_ID(0x04, 0xe0) 0 1 0 /* Port 1 IO  */
+				0x82000000 0x3 0     MBUS_ID(0x04, 0xd8) 0 1 0 /* Port 2 MEM */
+				0x81000000 0x3 0     MBUS_ID(0x04, 0xd0) 0 1 0 /* Port 2 IO  */>;
+
+			/* x1 port */
+			pcie at 1,0 {
+				device_type = "pci";
+				assigned-addresses = <0x82000800 0 0x80000 0 0x2000>;
+				reg = <0x0800 0 0 0 0>;
+				#address-cells = <3>;
+				#size-cells = <2>;
+				#interrupt-cells = <1>;
+				ranges = <0x82000000 0 0 0x82000000 0x1 0 1 0
+					  0x81000000 0 0 0x81000000 0x1 0 1 0>;
+				interrupt-map-mask = <0 0 0 0>;
+				interrupt-map = <0 0 0 0 &gic 0 29 0x4>;
+				marvell,pcie-port = <0>;
+				marvell,pcie-lane = <0>;
+				clocks = <&gateclk 8>;
+				status = "disabled";
+			};
+
+			/* x1 port */
+			pcie at 2,0 {
+				device_type = "pci";
+				assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
+				reg = <0x1000 0 0 0 0>;
+				#address-cells = <3>;
+				#size-cells = <2>;
+				#interrupt-cells = <1>;
+				ranges = <0x82000000 0 0 0x82000000 0x2 0 1 0
+					  0x81000000 0 0 0x81000000 0x2 0 1 0>;
+				interrupt-map-mask = <0 0 0 0>;
+				interrupt-map = <0 0 0 0 &gic 0 33 0x4>;
+				marvell,pcie-port = <1>;
+				marvell,pcie-lane = <0>;
+				clocks = <&gateclk 5>;
+				status = "disabled";
+			};
+
+			/* x1 port */
+			pcie at 3,0 {
+				device_type = "pci";
+				assigned-addresses = <0x82000800 0 0x44000 0 0x2000>;
+				reg = <0x1000 0 0 0 0>;
+				#address-cells = <3>;
+				#size-cells = <2>;
+				#interrupt-cells = <1>;
+				ranges = <0x82000000 0 0 0x82000000 0x3 0 1 0
+					  0x81000000 0 0 0x81000000 0x3 0 1 0>;
+				interrupt-map-mask = <0 0 0 0>;
+				interrupt-map = <0 0 0 0 &gic 0 70 0x4>;
+				marvell,pcie-port = <2>;
+				marvell,pcie-lane = <0>;
+				clocks = <&gateclk 6>;
+				status = "disabled";
+			};
+		};
+	};
+};
arch/arm/boot/dts/armada-385.dtsi new file +149 -0

149 lines not on this page · raw message

arch/arm/boot/dts/armada-38x.dtsi new file +345 -0

345 lines not on this page · raw message

Signature · 1 line
1.8.3.2
#20 lore raw

PATCH v3 11/13 ARM: mvebu: add Device Tree for the Armada 385 DB board

In reply to Thomas Petazzoni

The Armada 385 DB board is the development board from Marvell for the Armada 385 SoC. This commit adds a Device Tree description for this board, which enables the following features:

* Network interfaces
* I2C buses
* SDIO
* Serial port
* SPI bus, with a SPI flash
* PCIe interfaces

---
 arch/arm/boot/dts/Makefile          |   1 +
 arch/arm/boot/dts/armada-385-db.dts | 101 ++++++++++++++++++++++++++++++++++++
 2 files changed, 102 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-385-db.dts
arch/arm/boot/dts/Makefile +1 -0
index f1eafbd..bd789fc 100644
@@ -127,6 +127,7 @@ dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
 	armada-370-netgear-rn104.dtb \
 	armada-370-rd.dtb \
 	armada-375-db.dtb \
+	armada-385-db.dtb \
 	armada-xp-axpwifiap.dtb \
 	armada-xp-db.dtb \
 	armada-xp-gp.dtb \
arch/arm/boot/dts/armada-385-db.dts new file +101 -0

101 lines not on this page · raw message

Signature · 1 line
1.8.3.2
#21 lore raw

PATCH v3 12/13 ARM: mvebu: update defconfigs for Armada 375 and 38x

In reply to Thomas Petazzoni

This commit enables the Armada 375 and Armada 38x support in mvebu_defconfig and multi_v7_defconfig.

---
 arch/arm/configs/multi_v7_defconfig | 2 ++
 arch/arm/configs/mvebu_defconfig    | 2 ++
 2 files changed, 4 insertions(+)
arch/arm/configs/multi_v7_defconfig +2 -0
index 845bc74..3c32fc9 100644
@@ -9,6 +9,8 @@ CONFIG_MODULE_UNLOAD=y
 CONFIG_PARTITION_ADVANCED=y
 CONFIG_ARCH_MVEBU=y
 CONFIG_MACH_ARMADA_370=y
+CONFIG_MACH_ARMADA_375=y
+CONFIG_MACH_ARMADA_38X=y
 CONFIG_MACH_ARMADA_XP=y
 CONFIG_ARCH_BCM=y
 CONFIG_ARCH_BCM_MOBILE=y
arch/arm/configs/mvebu_defconfig +2 -0
index 0f4511d..5fc24ae 100644
@@ -10,6 +10,8 @@ CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
 CONFIG_ARCH_MVEBU=y
 CONFIG_MACH_ARMADA_370=y
+CONFIG_MACH_ARMADA_375=y
+CONFIG_MACH_ARMADA_38X=y
 CONFIG_MACH_ARMADA_XP=y
 # CONFIG_CACHE_L2X0 is not set
 # CONFIG_SWP_EMULATE is not set
Signature · 1 line
1.8.3.2
#22 lore raw

PATCH v3 13/13 Documentation: arm: update Marvell documentation about Armada 375/38x

In reply to Thomas Petazzoni

This commit updates the documentation that describes the various families of SOCs produced by Marvell, together with the corresponding available technical documents. It adds Armada 375 and Armada 38x, and adds a link to the product brief for the already supported Armada 370.

---
 Documentation/arm/Marvell/README | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
Documentation/arm/Marvell/README +11 -1
index 5a930c1..963ec44 100644
@@ -83,14 +83,24 @@ EBU Armada family
         88F6710
         88F6707
         88F6W11
+    Product Brief: http://www.marvell.com/embedded-processors/armada-300/assets/Marvell_ARMADA_370_SoC.pdf
+
+  Armada 375 Flavors:
+	88F6720
+    Product Brief: http://www.marvell.com/embedded-processors/armada-300/assets/ARMADA_375_SoC-01_product_brief.pdf
+
+  Armada 380/385 Flavors:
+	88F6810
+	88F6820
+	88F6828
 
   Armada XP Flavors:
         MV78230
         MV78260
         MV78460
     NOTE: not to be confused with the non-SMP 78xx0 SoCs
+    Product Brief: http://www.marvell.com/embedded-processors/armada-xp/assets/Marvell-ArmadaXP-SoC-product%20brief.pdf
 
-  Product Brief: http://www.marvell.com/embedded-processors/armada-xp/assets/Marvell-ArmadaXP-SoC-product%20brief.pdf
   No public datasheet available.
 
   Core: Sheeva ARMv7 compatible
Signature · 1 line
1.8.3.2