video: fbdev: pmagb-b-fb: remove incorrect __exit markups
PATCH 1/1 video: fbdev: pmagb-b-fb: remove incorrect __exit markups
Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes.
Signed-off-by Dmitry Torokhov <[email protected]>
--- drivers/video/fbdev/pmagb-b-fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/pmagb-b-fb.c +2 -2
@@ -353,7 +353,7 @@ static int pmagbbfb_probe(struct device *dev)return err; } -static int __exit pmagbbfb_remove(struct device *dev) +static int pmagbbfb_remove (struct device *dev) {struct tc_dev *tdev =to_tc_dev (dev);struct fb_info *info =dev_get_drvdata (dev);
@@ -388,7 +388,7 @@ static struct tc_driver pmagbbfb_driver = { .name = "pmagbbfb", .bus = &tc_bus_type, .probe = pmagbbfb_probe, - .remove = __exit_p(pmagbbfb_remove), + .remove = pmagbbfb_remove, }, };
Signature · 5 lines
2.11.0.483.g087da7b7c-goog -- Dmitry
Quoted 7 lines · Dmitry Torokhov
Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using
__exitannotations onremove()methods. The only exception is drivers registered withplatform_driver_probe()which specifically disables sysfs bind/unbind attributes.Signed-off-by Dmitry Torokhov <[email protected]>
Patch queued for 4.12, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics