AMD Pstate Driver Core Performance Boost

From: Perry Yuan <[email protected]>

Add gloal global_params to represent current CPU Performance Boost(cpb) state for cpu frequency scaling, both active and passive modes all can support CPU cores frequency boosting control which is based on the BIOS setting, while BIOS turn on the "Core Performance Boost", it will allow OS control each core highest perf limitation from OS side.

If core performance boost is disabled while a core is in a boosted P-state, the core transitions to the highest performance non-boosted P-state, that is the same as the nominal frequency limit.

Reported-by Artem S. Tashkinov" <[email protected]>

Closes https://bugzilla.kernel.org/show_bug.cgi?id=217931

Signed-off-by Perry Yuan <[email protected]>

---
 drivers/cpufreq/amd-pstate.c | 49 ++++++++++++------------------------
 include/linux/amd-pstate.h   | 14 +++++++++++
 2 files changed, 30 insertions(+), 33 deletions(-)

drivers/cpufreq/amd-pstate.c +0 -0

index 08e112444c27..3772f71f525f 100644

drivers/cpufreq/amd-pstate.c +15 -33

 /*
  * AMD Energy Preference Performance (EPP)

@@ -669,43 +670,21 @@ static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)
 	return lowest_nonlinear_freq * 1000;
 }
 
-static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
+static int amd_pstate_boost_init(struct amd_cpudata *cpudata)
 {
-	struct amd_cpudata *cpudata = policy->driver_data;
+	u64 boost_val;
 	int ret;
 
-	if (!cpudata->boost_supported) {
-		pr_err("Boost mode is not supported by this processor or SBIOS\n");
-		return -EINVAL;
-	}
-
-	if (state)
-		policy->cpuinfo.max_freq = cpudata->max_freq;
-	else
-		policy->cpuinfo.max_freq = cpudata->nominal_freq;
-
-	policy->max = policy->cpuinfo.max_freq;
-
-	ret = freq_qos_update_request(&cpudata->req[1],
-				      policy->cpuinfo.max_freq);
-	if (ret < 0)
+	ret = rdmsrl_on_cpu(cpudata->cpu, MSR_K7_HWCR, &boost_val);
+	if (ret) {
+		pr_err_once("failed to read initial CPU boost state!\n");
 		return ret;
+	}
 
-	return 0;
-}
-
-static void amd_pstate_boost_init(struct amd_cpudata *cpudata)
-{
-	u32 highest_perf, nominal_perf;
-
-	highest_perf = READ_ONCE(cpudata->highest_perf);
-	nominal_perf = READ_ONCE(cpudata->nominal_perf);
-
-	if (highest_perf <= nominal_perf)
-		return;
+	global.cpb_supported = !((boost_val >> 25) & 0x1);
+	global.cpb_boost = global.cpb_supported;
 
-	cpudata->boost_supported = true;
-	current_pstate_driver->boost_enabled = true;
+	return ret;
 }
 
 static void amd_perf_ctl_reset(unsigned int cpu)

@@ -848,6 +827,9 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
 	if (ret)
 		goto free_cpudata1;
 
+	/* initialize cpu cores boot state */
+	amd_pstate_boost_init(cpudata);
+
 	min_freq = amd_get_min_freq(cpudata);
 	max_freq = amd_get_max_freq(cpudata);
 	nominal_freq = amd_get_nominal_freq(cpudata);

@@ -899,7 +881,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
 
 	policy->driver_data = cpudata;
 
-	amd_pstate_boost_init(cpudata);
 	if (!current_pstate_driver->adjust_perf)
 		current_pstate_driver->adjust_perf = amd_pstate_adjust_perf;
 

@@ -1310,6 +1291,9 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
 	if (ret)
 		goto free_cpudata1;
 
+	/* initialize cpu cores boot state */
+	amd_pstate_boost_init(cpudata);
+
 	min_freq = amd_get_min_freq(cpudata);
 	max_freq = amd_get_max_freq(cpudata);
 	nominal_freq = amd_get_nominal_freq(cpudata);

@@ -1360,7 +1344,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
 			return ret;
 		WRITE_ONCE(cpudata->cppc_cap1_cached, value);
 	}
-	amd_pstate_boost_init(cpudata);
 
 	return 0;
 

include/linux/amd-pstate.h +14 -0

index d21838835abd..465e9295a60c 100644
@@ -124,4 +124,18 @@ static const char * const amd_pstate_mode_string[] = {
 	[AMD_PSTATE_GUIDED]      = "guided",
 	NULL,
 };
+
+/**
+ * struct global_params - Global parameters, mostly tunable via sysfs.
+ * @cpb_boost:		Whether or not to use boost CPU P-states.
+ * @cpb_supported:	Whether or not CPU boost P-states are available
+ *			based on the MSR_K7_HWCR bit[25] state
+ */
+struct global_params {
+	bool cpb_boost;
+	bool cpb_supported;
+};
+
+extern struct global_params global;
+
 #endif /* _LINUX_AMD_PSTATE_H */

Quoted 25 lines · On středa 7. února 2024 10:21:52 CET Perry Yuan wrote:

From: Perry Yuan <[email protected]>

Add gloal global_params to represent current CPU Performance Boost(cpb) state for cpu frequency scaling, both active and passive modes all can support CPU cores frequency boosting control which is based on the BIOS setting, while BIOS turn on the "Core Performance Boost", it will allow OS control each core highest perf limitation from OS side.

If core performance boost is disabled while a core is in a boosted P-state, the core transitions to the highest performance non-boosted P-state, that is the same as the nominal frequency limit.

Reported-by Artem S. Tashkinov" <[email protected]>

Closes https://bugzilla.kernel.org/show_bug.cgi?id=217931

Signed-off-by Perry Yuan <[email protected]>

---
 drivers/cpufreq/amd-pstate.c | 49 ++++++++++++------------------------
 include/linux/amd-pstate.h   | 14 +++++++++++
 2 files changed, 30 insertions(+), 33 deletions(-)

drivers/cpufreq/amd-pstate.c +0 -0

index 08e112444c27..3772f71f525f 100644

drivers/cpufreq/amd-pstate.c static struct cpufreq_driver amd_pstate_epp_driver; · line 70

Quoted 4 lines

drivers/cpufreq/amd-pstate.c +1 -0

@@ -67,6 +67,7 @@ static struct cpufreq_driver amd_pstate_epp_driver;
 static int cppc_state = AMD_PSTATE_UNDEFINED;
 static bool cppc_enabled;
 static bool amd_pstate_prefcore = true;
+struct global_params global;

Doesn't this require EXPORT_SYMBOL_GPL(global) then? Otherwise with v6.8 I get this:

```
ERROR: modpost: "global" [drivers/cpufreq/amd-pstate-ut.ko] undefined!
```

If so, I'd pretty mush rename this to be less generic, say, amd_pstate_global_params_struct for the struct name itself and amd_pstate_global_params for the actual variable name.

Quoted 116 lines

drivers/cpufreq/amd-pstate.c +15 -33

 /*
  * AMD Energy Preference Performance (EPP)

@@ -669,43 +670,21 @@ static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)
 	return lowest_nonlinear_freq * 1000;
 }
 
-static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
+static int amd_pstate_boost_init(struct amd_cpudata *cpudata)
 {
-	struct amd_cpudata *cpudata = policy->driver_data;
+	u64 boost_val;
 	int ret;
 
-	if (!cpudata->boost_supported) {
-		pr_err("Boost mode is not supported by this processor or SBIOS\n");
-		return -EINVAL;
-	}
-
-	if (state)
-		policy->cpuinfo.max_freq = cpudata->max_freq;
-	else
-		policy->cpuinfo.max_freq = cpudata->nominal_freq;
-
-	policy->max = policy->cpuinfo.max_freq;
-
-	ret = freq_qos_update_request(&cpudata->req[1],
-				      policy->cpuinfo.max_freq);
-	if (ret < 0)
+	ret = rdmsrl_on_cpu(cpudata->cpu, MSR_K7_HWCR, &boost_val);
+	if (ret) {
+		pr_err_once("failed to read initial CPU boost state!\n");
 		return ret;
+	}
 
-	return 0;
-}
-
-static void amd_pstate_boost_init(struct amd_cpudata *cpudata)
-{
-	u32 highest_perf, nominal_perf;
-
-	highest_perf = READ_ONCE(cpudata->highest_perf);
-	nominal_perf = READ_ONCE(cpudata->nominal_perf);
-
-	if (highest_perf <= nominal_perf)
-		return;
+	global.cpb_supported = !((boost_val >> 25) & 0x1);
+	global.cpb_boost = global.cpb_supported;
 
-	cpudata->boost_supported = true;
-	current_pstate_driver->boost_enabled = true;
+	return ret;
 }
 
 static void amd_perf_ctl_reset(unsigned int cpu)

@@ -848,6 +827,9 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
 	if (ret)
 		goto free_cpudata1;
 
+	/* initialize cpu cores boot state */
+	amd_pstate_boost_init(cpudata);
+
 	min_freq = amd_get_min_freq(cpudata);
 	max_freq = amd_get_max_freq(cpudata);
 	nominal_freq = amd_get_nominal_freq(cpudata);

@@ -899,7 +881,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
 
 	policy->driver_data = cpudata;
 
-	amd_pstate_boost_init(cpudata);
 	if (!current_pstate_driver->adjust_perf)
 		current_pstate_driver->adjust_perf = amd_pstate_adjust_perf;
 

@@ -1310,6 +1291,9 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
 	if (ret)
 		goto free_cpudata1;
 
+	/* initialize cpu cores boot state */
+	amd_pstate_boost_init(cpudata);
+
 	min_freq = amd_get_min_freq(cpudata);
 	max_freq = amd_get_max_freq(cpudata);
 	nominal_freq = amd_get_nominal_freq(cpudata);

@@ -1360,7 +1344,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
 			return ret;
 		WRITE_ONCE(cpudata->cppc_cap1_cached, value);
 	}
-	amd_pstate_boost_init(cpudata);
 
 	return 0;
 

include/linux/amd-pstate.h +14 -0

index d21838835abd..465e9295a60c 100644
@@ -124,4 +124,18 @@ static const char * const amd_pstate_mode_string[] = {
 	[AMD_PSTATE_GUIDED]      = "guided",
 	NULL,
 };
+
+/**
+ * struct global_params - Global parameters, mostly tunable via sysfs.
+ * @cpb_boost:		Whether or not to use boost CPU P-states.
+ * @cpb_supported:	Whether or not CPU boost P-states are available
+ *			based on the MSR_K7_HWCR bit[25] state
+ */
+struct global_params {
+	bool cpb_boost;
+	bool cpb_supported;
+};
+
+extern struct global_params global;
+
 #endif /* _LINUX_AMD_PSTATE_H */

-----Original Message-----
From: Oleksandr Natalenko <[email protected]>
Sent: Wednesday, February 7, 2024 10:45 PM
To: [email protected]; Limonciello, Mario <[email protected]>; [email protected]; Huang, Ray <[email protected]>; Shenoy, Gautham Ranjal <[email protected]>; Petkov, Borislav <[email protected]>; Yuan, Perry <[email protected]>
Cc: Deucher, Alexander <[email protected]>; Huang, Shimmer <[email protected]>; Du, Xiaojian <[email protected]>; Meng, Li (Jassmine) <[email protected]>; [email protected]; linux- [email protected]
Subject: Re: [PATCH v3 1/7] cpufreq: amd-pstate: initialize new core precision boost state

Quoted 7 lines · On středa 7. února 2024 10:21:52 CET Perry Yuan wrote:

From: Perry Yuan <[email protected]>

Add gloal global_params to represent current CPU Performance Boost(cpb) state for cpu frequency scaling, both active and passive modes all can support CPU cores frequency boosting control which is based on the BIOS setting, while BIOS turn on the "Core Performance Boost", it will allow OS control each core highest perf limitation from OS

side.

Quoted 13 lines

If core performance boost is disabled while a core is in a boosted P-state, the core transitions to the highest performance non-boosted P-state, that is the same as the nominal frequency limit.

Reported-by Artem S. Tashkinov" <[email protected]>

Closes https://bugzilla.kernel.org/show_bug.cgi?id=217931

Signed-off-by Perry Yuan <[email protected]>

---
 drivers/cpufreq/amd-pstate.c | 49 ++++++++++++------------------------
 include/linux/amd-pstate.h   | 14 +++++++++++
 2 files changed, 30 insertions(+), 33 deletions(-)

Quoted 8 lines

(quoted diff) +0 -0

b/drivers/cpufreq/amd-pstate.c index 08e112444c27..3772f71f525f 100644

drivers/cpufreq/amd-pstate.c +0 -0

@@ -67,6 +67,7 @@ static struct cpufreq_driver amd_pstate_epp_driver;

static int cppc_state = AMD_PSTATE_UNDEFINED; static bool cppc_enabled; static bool amd_pstate_prefcore = true; +struct global_params global;

Doesn't this require EXPORT_SYMBOL_GPL(global) then? Otherwise with v6.8 I get this:

```
ERROR: modpost: "global" [drivers/cpufreq/amd-pstate-ut.ko] undefined!
```

If so, I'd pretty mush rename this to be less generic, say, amd_pstate_global_params_struct for the struct name itself and amd_pstate_global_params for the actual variable name.

Quoted 9 lines

/*
* AMD Energy Preference Performance (EPP) @@ -669,43 +670,21 @@
static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)

    return lowest_nonlinear_freq * 1000;  }

-static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)

drivers/cpufreq/amd-pstate.c static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)

Quoted 8 lines

drivers/cpufreq/amd-pstate.c +2 -3

+static int amd_pstate_boost_init(struct amd_cpudata *cpudata)
 {
-   struct amd_cpudata *cpudata = policy->driver_data;
+   u64 boost_val;
    int ret;
 
-   if (!cpudata->boost_supported) {
-           pr_err("Boost mode is not supported by this processor or

SBIOS\n");

Quoted 43 lines

drivers/cpufreq/amd-pstate.c +7 -26

-           return -EINVAL;
-   }
-
-   if (state)
-           policy->cpuinfo.max_freq = cpudata->max_freq;
-   else
-           policy->cpuinfo.max_freq = cpudata->nominal_freq;
-
-   policy->max = policy->cpuinfo.max_freq;
-
-   ret = freq_qos_update_request(&cpudata->req[1],
-                                 policy->cpuinfo.max_freq);
-   if (ret < 0)
+   ret = rdmsrl_on_cpu(cpudata->cpu, MSR_K7_HWCR, &boost_val);
+   if (ret) {
+           pr_err_once("failed to read initial CPU boost state!\n");
            return ret;
+   }
 
-   return 0;
-}
-
-static void amd_pstate_boost_init(struct amd_cpudata *cpudata) -{
-   u32 highest_perf, nominal_perf;
-
-   highest_perf = READ_ONCE(cpudata->highest_perf);
-   nominal_perf = READ_ONCE(cpudata->nominal_perf);
-
-   if (highest_perf <= nominal_perf)
-           return;
+   global.cpb_supported = !((boost_val >> 25) & 0x1);
+   global.cpb_boost = global.cpb_supported;
 
-   cpudata->boost_supported = true;
-   current_pstate_driver->boost_enabled = true;
+   return ret;
 }
 
 static void amd_perf_ctl_reset(unsigned int cpu) @@ -848,6 +827,9 @@

static int amd_pstate_cpu_init(struct cpufreq_policy *policy)

    if (ret)
            goto free_cpudata1;

drivers/cpufreq/amd-pstate.c static int amd_pstate_cpu_init(struct cpufreq_policy *policy)

Quoted 6 lines

drivers/cpufreq/amd-pstate.c +3 -0

+   /* initialize cpu cores boot state */
+   amd_pstate_boost_init(cpudata);
+
    min_freq = amd_get_min_freq(cpudata);
    max_freq = amd_get_max_freq(cpudata);
    nominal_freq = amd_get_nominal_freq(cpudata); @@ -899,7 +881,6

@@

Quoted 7 lines

static int amd_pstate_cpu_init(struct cpufreq_policy *policy)

    policy->driver_data = cpudata;

-   amd_pstate_boost_init(cpudata);
    if (!current_pstate_driver->adjust_perf)
            current_pstate_driver->adjust_perf =

amd_pstate_adjust_perf;

drivers/cpufreq/amd-pstate.c static int amd_pstate_epp_cpu_init(struct

Quoted 2 lines

drivers/cpufreq/amd-pstate.c +0 -0

@@ -1310,6 +1291,9 @@ static int amd_pstate_epp_cpu_init(struct

cpufreq_policy *policy)

drivers/cpufreq/amd-pstate.c static int amd_pstate_cpu_init(struct cpufreq_policy *policy)

Quoted 9 lines

drivers/cpufreq/amd-pstate.c +3 -0

    if (ret)
            goto free_cpudata1;
 
+   /* initialize cpu cores boot state */
+   amd_pstate_boost_init(cpudata);
+
    min_freq = amd_get_min_freq(cpudata);
    max_freq = amd_get_max_freq(cpudata);
    nominal_freq = amd_get_nominal_freq(cpudata); @@ -1360,7

+1344,6 @@

include/linux/amd-pstate.h static const char * const

Quoted 13 lines

static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)

                    return ret;
            WRITE_ONCE(cpudata->cppc_cap1_cached, value);
    }

drivers/cpufreq/amd-pstate.c +0 -1

-   amd_pstate_boost_init(cpudata);
 
    return 0;

include/linux/amd-pstate.h +0 -0

index d21838835abd..465e9295a60c 100644
@@ -124,4 +124,18 @@ static const char * const

amd_pstate_mode_string[] = {

include/linux/amd-pstate.h static const char * const amd_pstate_mode_string[] = {

Quoted 8 lines

include/linux/amd-pstate.h +5 -0

    [AMD_PSTATE_GUIDED]      = "guided",
    NULL,
 };
+
+/**
+ * struct global_params - Global parameters, mostly tunable via sysfs.
+ * @cpb_boost:             Whether or not to use boost CPU P-states.
+ * @cpb_supported: Whether or not CPU boost P-states are

available

include/linux/amd-pstate.h static const char * const amd_pstate_mode_string[] = { · line 141

Quoted 11 lines

include/linux/amd-pstate.h +9 -0

+ *                 based on the MSR_K7_HWCR bit[25] state
+ */
+struct global_params {
+   bool cpb_boost;
+   bool cpb_supported;
+};
+
+extern struct global_params global;
+
 #endif /* _LINUX_AMD_PSTATE_H */

--
Oleksandr Natalenko (post-factum)

With new freqency boost interface supported, legacy boost control doesn't make sense any more which only support passive mode. so it can remove the legacy set_boost interface from amd-pstate driver in case of there is conflict with new boost control logic.

Signed-off-by Perry Yuan <[email protected]>

---
 drivers/cpufreq/amd-pstate.c | 1 -
 include/linux/amd-pstate.h   | 1 -
 2 files changed, 2 deletions(-)

drivers/cpufreq/amd-pstate.c +0 -1

index 35791efc6e88..1dd523db3871 100644
@@ -1675,7 +1675,6 @@ static struct cpufreq_driver amd_pstate_driver = {
 	.exit		= amd_pstate_cpu_exit,
 	.suspend	= amd_pstate_cpu_suspend,
 	.resume		= amd_pstate_cpu_resume,
-	.set_boost	= amd_pstate_set_boost,
 	.update_limits	= amd_pstate_update_limits,
 	.name		= "amd-pstate",
 	.attr		= amd_pstate_attr,

include/linux/amd-pstate.h +0 -0

index 465e9295a60c..ab7ca26974da 100644

include/linux/amd-pstate.h +0 -0

 	bool	hw_prefcore;
 
 	/* EPP feature related attributes*/

-----Original Message-----
From: Oleksandr Natalenko <[email protected]>
Sent: Wednesday, February 7, 2024 6:11 PM
To: [email protected]; Limonciello, Mario <[email protected]>; [email protected]; Huang, Ray <[email protected]>; Shenoy, Gautham Ranjal <[email protected]>; Petkov, Borislav <[email protected]>; Yuan, Perry <[email protected]>
Cc: Deucher, Alexander <[email protected]>; Huang, Shimmer <[email protected]>; Du, Xiaojian <[email protected]>; Meng, Li (Jassmine) <[email protected]>; [email protected]; linux- [email protected]
Subject: Re: [PATCH v3 6/7] cpufreq: amd-pstate: remove legacy set_boost callback for passive mode

Hello.

Quoted 5 lines · On středa 7. února 2024 10:21:57 CET Perry Yuan wrote:

With new freqency boost interface supported, legacy boost control doesn't make sense any more which only support passive mode. so it can remove the legacy set_boost interface from amd-pstate driver in case of there is conflict with new boost control logic.

Quoted 8 lines

Signed-off-by Perry Yuan <[email protected]>

---
 drivers/cpufreq/amd-pstate.c | 1 -
 include/linux/amd-pstate.h   | 1 -
 2 files changed, 2 deletions(-)

(quoted diff) +0 -0

b/drivers/cpufreq/amd-pstate.c index 35791efc6e88..1dd523db3871

100644

drivers/cpufreq/amd-pstate.c static struct cpufreq_driver amd_pstate_driver =

Quoted 3 lines

drivers/cpufreq/amd-pstate.c +0 -0

@@ -1675,7 +1675,6 @@ static struct cpufreq_driver amd_pstate_driver =

{

Quoted 14 lines

drivers/cpufreq/amd-pstate.c +0 -1

    .exit           = amd_pstate_cpu_exit,
    .suspend        = amd_pstate_cpu_suspend,
    .resume         = amd_pstate_cpu_resume,
-   .set_boost      = amd_pstate_set_boost,
    .update_limits  = amd_pstate_update_limits,
    .name           = "amd-pstate",
    .attr           = amd_pstate_attr,

include/linux/amd-pstate.h +0 -0

index 465e9295a60c..ab7ca26974da 100644
@@ -93,7 +93,6 @@ struct amd_cpudata {
    struct amd_aperf_mperf prev;
 

include/linux/amd-pstate.h struct amd_cpudata { · line 96

Quoted 2 lines

include/linux/amd-pstate.h +0 -1

    u64     freq;
-   bool    boost_supported;

As a result of this removal the kernel-doc for this struct should be amended too because even after this patch is applied the boost_supported field remains documented.

include/linux/amd-pstate.h struct amd_cpudata { · line 98

Quoted 5 lines

include/linux/amd-pstate.h +0 -0

    bool    hw_prefcore;
 
    /* EPP feature related attributes*/

--
Oleksandr Natalenko (post-factum)

[AMD Official Use Only - General]

Hi,

Quoted 50 lines

-----Original Message-----
From: Oleksandr Natalenko <[email protected]>
Sent: Wednesday, February 7, 2024 6:11 PM
To: [email protected]; Limonciello, Mario <[email protected]>; [email protected]; Huang, Ray <[email protected]>; Shenoy, Gautham Ranjal <[email protected]>; Petkov, Borislav <[email protected]>; Yuan, Perry <[email protected]>
Cc: Deucher, Alexander <[email protected]>; Huang, Shimmer <[email protected]>; Du, Xiaojian <[email protected]>; Meng, Li (Jassmine) <[email protected]>; [email protected]; linux- [email protected]
Subject: Re: [PATCH v3 6/7] cpufreq: amd-pstate: remove legacy set_boost callback for passive mode

Hello.

Quoted 5 lines · On středa 7. února 2024 10:21:57 CET Perry Yuan wrote:

With new freqency boost interface supported, legacy boost control doesn't make sense any more which only support passive mode. so it can remove the legacy set_boost interface from amd-pstate driver in case of there is conflict with new boost control logic.

Quoted 8 lines

Signed-off-by Perry Yuan <[email protected]>

---
 drivers/cpufreq/amd-pstate.c | 1 -
 include/linux/amd-pstate.h   | 1 -
 2 files changed, 2 deletions(-)

(quoted diff) +0 -0

b/drivers/cpufreq/amd-pstate.c index 35791efc6e88..1dd523db3871

100644

drivers/cpufreq/amd-pstate.c static struct cpufreq_driver amd_pstate_driver =

Quoted 3 lines

drivers/cpufreq/amd-pstate.c +0 -0

@@ -1675,7 +1675,6 @@ static struct cpufreq_driver amd_pstate_driver =

{

Quoted 14 lines

drivers/cpufreq/amd-pstate.c +0 -1

    .exit           = amd_pstate_cpu_exit,
    .suspend        = amd_pstate_cpu_suspend,
    .resume         = amd_pstate_cpu_resume,
-   .set_boost      = amd_pstate_set_boost,
    .update_limits  = amd_pstate_update_limits,
    .name           = "amd-pstate",
    .attr           = amd_pstate_attr,

include/linux/amd-pstate.h +0 -0

index 465e9295a60c..ab7ca26974da 100644
@@ -93,7 +93,6 @@ struct amd_cpudata {
    struct amd_aperf_mperf prev;
 

Quoted 6 lines

include/linux/amd-pstate.h struct amd_cpudata { · line 96

Quoted 2 lines

include/linux/amd-pstate.h +0 -1

    u64     freq;
-   bool    boost_supported;

As a result of this removal the kernel-doc for this struct should be amended too because even after this patch is applied the boost_supported field remains documented.

The set_boost is callback used by cpufreq.c, the boost_supported is not documented before the patch. We just need to add new sysfs "cpb_boost" introduction in the "/Documentation/admin-guide/pm/amd-pstate.rst" The legacy boost is not supported any more, we have no need to document it again as it is.

Perry.

Quoted 9 lines

include/linux/amd-pstate.h struct amd_cpudata { · line 98

Quoted 5 lines

include/linux/amd-pstate.h +0 -0

    bool    hw_prefcore;
 
    /* EPP feature related attributes*/

--
Oleksandr Natalenko (post-factum)

-----Original Message-----
From: Oleksandr Natalenko <[email protected]>
Sent: Wednesday, February 7, 2024 9:27 PM
To: [email protected]; Limonciello, Mario <[email protected]>; [email protected]; Huang, Ray <[email protected]>; Shenoy, Gautham Ranjal <[email protected]>; Petkov, Borislav <[email protected]>; Yuan, Perry <[email protected]>
Cc: Deucher, Alexander <[email protected]>; Huang, Shimmer <[email protected]>; Du, Xiaojian <[email protected]>; Meng, Li (Jassmine) <[email protected]>; [email protected]; linux- [email protected]
Subject: Re: [PATCH v3 6/7] cpufreq: amd-pstate: remove legacy set_boost callback for passive mode

Quoted 13 lines · Perry

[AMD Official Use Only - General]

Hi,

Quoted 9 lines

-----Original Message-----
From: Oleksandr Natalenko <[email protected]>
Sent: Wednesday, February 7, 2024 6:11 PM
To: [email protected]; Limonciello, Mario <[email protected]>; [email protected]; Huang, Ray <[email protected]>; Shenoy, Gautham Ranjal <[email protected]>; Petkov, Borislav <[email protected]>; Yuan, Perry <[email protected]>
Cc: Deucher, Alexander <[email protected]>; Huang,

Shimmer

Quoted 1 line

Quoted 1 line

<[email protected]>; Du, Xiaojian <[email protected]>;

Meng,

Quoted 42 lines

Quoted 42 lines

Li (Jassmine) <[email protected]>; [email protected]; linux- [email protected]
Subject: Re: [PATCH v3 6/7] cpufreq: amd-pstate: remove legacy set_boost callback for passive mode

Hello.

Quoted 5 lines · On středa 7. února 2024 10:21:57 CET Perry Yuan wrote:

With new freqency boost interface supported, legacy boost control doesn't make sense any more which only support passive mode. so it can remove the legacy set_boost interface from amd-pstate driver in case of there is conflict with new boost control logic.

Quoted 8 lines

Signed-off-by Perry Yuan <[email protected]>

---
 drivers/cpufreq/amd-pstate.c | 1 -
 include/linux/amd-pstate.h   | 1 -
 2 files changed, 2 deletions(-)

(quoted diff) +0 -0

b/drivers/cpufreq/amd-pstate.c index 35791efc6e88..1dd523db3871

100644

Quoted 4 lines

drivers/cpufreq/amd-pstate.c +0 -0

@@ -1675,7 +1675,6 @@ static struct cpufreq_driver

amd_pstate_driver =

{

Quoted 15 lines

    .exit           = amd_pstate_cpu_exit,
    .suspend        = amd_pstate_cpu_suspend,
    .resume         = amd_pstate_cpu_resume,

drivers/cpufreq/amd-pstate.c +0 -1

-   .set_boost      = amd_pstate_set_boost,
    .update_limits  = amd_pstate_update_limits,
    .name           = "amd-pstate",
    .attr           = amd_pstate_attr,

(quoted diff) +0 -0

b/include/linux/amd-pstate.h index 465e9295a60c..ab7ca26974da 100644

include/linux/amd-pstate.h +0 -0

@@ -93,7 +93,6 @@ struct amd_cpudata {
    struct amd_aperf_mperf prev;
 

Quoted 8 lines

Quoted 6 lines

include/linux/amd-pstate.h struct amd_cpudata { · line 96

Quoted 2 lines

include/linux/amd-pstate.h +0 -1

    u64     freq;
-   bool    boost_supported;

As a result of this removal the kernel-doc for this struct should be amended too because even after this patch is applied the boost_supported field remains documented.

The set_boost is callback used by cpufreq.c, the boost_supported is not

documented before the patch.

Quoted 1 line

We just need to add new sysfs "cpb_boost" introduction in the

"/Documentation/admin-guide/pm/amd-pstate.rst"

Quoted 1 line

The legacy boost is not supported any more, we have no need to

document it again as it is.

boost_supported as a field of struct amd_cpudata is documented in the kernel-doc right before the structure, and this bit should be removed like shown below:

boost mode

```

include/linux/amd-pstate.h +0 -0

@@ -56,7 +56,6 @@ struct amd_aperf_mperf {
  * @cur: Difference of Aperf/Mperf/tsc count between last and current

sample
* @prev: Last Aperf/Mperf/tsc count value read from register
* @freq: current cpu frequency value
- * @boost_supported: check whether the Processor or SBIOS supports boost mode
* @hw_prefcore: check whether HW supports preferred core featue.
* Only when hw_prefcore and early prefcore param are true,
* AMD P-State driver supports preferred core featue.

```

Quoted 12 lines

Perry.

Quoted 9 lines

include/linux/amd-pstate.h struct amd_cpudata { · line 98

Quoted 5 lines

include/linux/amd-pstate.h +0 -0

    bool    hw_prefcore;
 
    /* EPP feature related attributes*/

--
Oleksandr Natalenko (post-factum)

--
Oleksandr Natalenko (post-factum)