Skip to contentSkip to conversation

powerpc: use kernel endianness in MSR in 32-bit signal handler

PATCH New Will Springer 1 participant 1 message Jan 3, 2021 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 powerpc: use kernel endianness in MSR in 32-bit signal handler

From: Joseph J Allen <[email protected]>

This mirrors the behavior in handle_rt_signal32, to obey kernel endianness rather than assume a 32-bit process is big-endian. Without this change, any 32-bit little-endian process will SIGILL immediately upon handling a signal.

---
 arch/powerpc/kernel/signal_32.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/powerpc/kernel/signal_32.c +2 -1
index 934cbdf6dd10..75ee918a120a 100644
@@ -929,8 +929,9 @@ int handle_signal32(struct ksignal *ksig, sigset_t *oldset,
 	regs->gpr[3] = ksig->sig;
 	regs->gpr[4] = (unsigned long) sc;
 	regs->nip = (unsigned long)ksig->ka.sa.sa_handler;
-	/* enter the signal handler in big-endian mode */
+	/* enter the signal handler in native-endian mode */
 	regs->msr &= ~MSR_LE;
+	regs->msr |= (MSR_KERNEL & MSR_LE);
 	return 0;
 
 failed:
Signature · 1 line
2.29.2